Received-SPF: pass (google.com: domain of linux-kernel+bounces-210066-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <e41fd460-6b50-4792-9328-3eda370672e4@amd.com>
Date: Tue, 11 Jun 2024 09:31:54 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 08/10] x86/cpufeatures: Add feature bits for AMD
 heterogeneous processor
To: Borislav Petkov <bp@alien8.de>, Perry Yuan <perry.yuan@amd.com>
Cc: gautham.shenoy@amd.com, rafael.j.wysocki@intel.com,
 viresh.kumar@linaro.org, Ray.Huang@amd.com, Alexander.Deucher@amd.com,
 Xinmei.Huang@amd.com, Xiaojian.Du@amd.com, Li.Meng@amd.com,
 linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1718095377.git.perry.yuan@amd.com>
 <7a2817ce6e8e6a2787bed8285dba8d81423d8414.1718095377.git.perry.yuan@amd.com>
 <20240611105216.GAZmgsYC-J_yLfdupF@fat_crate.local>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20240611105216.GAZmgsYC-J_yLfdupF@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MjhUZ0lFRXdsQTR6MHV6R29keFo0SDRJUVBha0h0NFlneGNKRFpYejB3RVJj?=
 =?utf-8?B?VzRMdzRWVi9ITUZ1SGF0bFFxZ3FYMmIrK1JqdUI0cVRxNWJiUDREdVV3SWUv?=
 =?utf-8?B?cGlWcVdIRHB5cjMyRXQrMFFwNGxBZGZIZDZKVmtnOVhSbzdDUkVFcFdpMzhZ?=
 =?utf-8?B?VGtFZVFJYnc4cVUrUEp6RTNBa00wZ0pQVHFob2V1MFRUNXpoRWlVU0g0cVFh?=
 =?utf-8?B?MDJkSjdjcHJoS0ErZS9rZ2lrWEZvZHRZUC82aGExNUZOU3ZUZWFJL0R4VU9H?=
 =?utf-8?B?SkhYWWdpdVA2YktPM2YwQ2lxbDgrbmJhQnpvbTFQOVZVRldEUHRzekRkQ05O?=
 =?utf-8?B?RFMveThtRWV1clBQNGhPeFRtV0crWVM1SldBRlBneFhEcHNFb01ieHdDSkJT?=
 =?utf-8?B?aGc0RG9RM0R6aG9wS2JCd2R4UFVsVVcydlA4S1BtNWp1QVVKckt4cE1yWVB1?=
 =?utf-8?B?R3NmcnZUd0wyVTQ3Rk84VDhScFVPdXFOVGZDUStrRlNHeHhLY3NSbWxpQ012?=
 =?utf-8?B?aU1mN1JxaGk0SUcvSTZVeWNidlZKZW1hVGJwNFB6S2V5NmY5NDk2MW0rRDhj?=
 =?utf-8?B?OEJ3Y1ptQXpkdlMwSXZCTUJSK0liZFhKRi9rMlJQdGpIdFlwb1orTlV4RmpB?=
 =?utf-8?B?Y1RUTy9OM3doRDgyMFpiL3kxY1RTaXJLQ3FBTFo2UDFUYTNzbDJZWG1TZlg0?=
 =?utf-8?B?K0FDcW9lWkFIWG9FU0FqWTlvRUwyakltbHlmaVBXWW5saEUzY1dFY3VKU1lZ?=
 =?utf-8?B?b3IrV0d4SnoyY05RanE4ZG84eXBYbXowanUwUWwwMmNuczNBbElIVGNuVU5B?=
 =?utf-8?B?V2lKZDV4VXl2V3lSQkI4WVcwVm0xc25IOHpaWHBRb05TdWZpcWNoVGVJeUhm?=
 =?utf-8?B?QlhReW5kaFpoNEl4OXg5N2JBK0FKS2VrKzBYcGdxWVNEaHNhWnR0Vk42bU5Y?=
 =?utf-8?B?M1RFUWtIQTE1dUtKKzVJY0ZmUUF3aG1xSUF4NGRaRERrUW0xcjNBR043YlNm?=
 =?utf-8?B?QUJwRzNIUlBQd211SzFKWFpaTlFwZS9CVlJCMnRIZ1BmbGM4R2RJZE9tcnBx?=
 =?utf-8?B?dlREcXc2THkzaEVoYk9oYm5pcUxNbmI5cFpDekZKYmt4S3FyeE5sbWtTRHNS?=
 =?utf-8?B?SkZZeVRwUkJNRnd2NzBXMmlpdGZqanMrd1BRRVB1bndtdDRpRGlNd3BzRXp3?=
 =?utf-8?B?ZVBuSnVzYUE5a0QzWWlnOGZSNUxyNTFTN3JzejdLam5QbXRpN2xEYUl5K0N4?=
 =?utf-8?B?dmVaaG0rNEsyVTl4T2FPQ0xjRzFWSmR4NVpYOFpCUDJDT0dNT3VmU1BpSFNv?=
 =?utf-8?B?Y2Y2SUI2SmZnWEFVeFVpc2lZakRkNjRYWFdFc3Z4ZlRtMFJDRHlpYyt4Vnhx?=
 =?utf-8?B?N2xlbFdGci9kSGk5NG5jWm5DU3FlRzhnK0RqbkNRRU0rTVB6d2JRY2hDcmQ4?=
 =?utf-8?B?dEFCL2orcmE1RGlkZHBJZE1FVVV3RFZGSk1mcjkzQ0ZJNUxEV2x5RnN1V0JS?=
 =?utf-8?B?K01rbVpQK2lPalZINEc3VVJhd2tMeWdlc1MwQ05ZWllNdlJsZ3BLRjBHSEFm?=
 =?utf-8?B?TEhaN1ZHamsybm82TDhVdUFPODc1QU1TcFFlZjBuNG9XU1ljalZlaE13bWI5?=
 =?utf-8?B?UG5iTzh1bU8zOTRBRU1pQTA3RVUzODcvWmpKWWM3YzAwTnpxeklydVB3S0pz?=
 =?utf-8?B?bUVPcEIwbEs3NlEzc0hHTk1jU0JHVGdnN3lEN0xMYlN3dUtOaW5oNGRzNHlu?=
 =?utf-8?B?c3dzQ2dSUzVvbDY0WWk4Q1Y2cytMVDhycVhZcmMvaDFpY095ZDV5R1hibXdz?=
 =?utf-8?B?VldZNmxHSDd3TC9INE5YVXJvNjVZY0lHdmhuK2FBUVQ3LzNLcXJWaFVsdUtH?=
 =?utf-8?B?bGIwOEQzNldvcUwvNVlkVEJoNnFHbzZpOVFZa0hhSVBCSGNsNERZc3k3aGhR?=
 =?utf-8?B?dWdraUd4N0pQWWtLY25hdVBiVit2cFRHR3FoRktqdm1pdHd1WlMwYVRkdFlV?=
 =?utf-8?B?eE56R3NONFJsQmNQYnVuaVMxRWwxdG16c3ZBTFFZTUY1bHlOT09MWloxOW9F?=
 =?utf-8?B?RXRRSVhnc2tubm5kZWhSMnZYYkZXSlVNdmpOeUVLUDdPSjdDTDJOZXd3ckFp?=
 =?utf-8?Q?Ko1WKGTN4h/N9PVPokgd0/03I?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0583cad3-5881-4dde-8a78-08dc8a233fbf
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 14:31:57.9533
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: loW2nlca4860bHlmSegDVqq4gNt5UlaFYtWnO3jWPqYz33wnKG6JquH+NxhDFTcsGRGuwRBn9SCeisd9B7Py0w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6138

On 6/11/2024 05:52, Borislav Petkov wrote:
> On Tue, Jun 11, 2024 at 04:52:24PM +0800, Perry Yuan wrote:
>> Subject: Re: [PATCH v3 08/10] x86/cpufeatures: Add feature bits for AMD heterogeneous processor
> 
> "... Add a heterogeneous core topology feature bit"
> 
> not "feature bits"
> 
>> CPUID leaf 0x80000026 advertises core types with different efficiency rankings
>>
>> Bit 30 indicates the heterogeneous core topology feature, if the bit
>> set, it means not all instances at the current hierarchical level have
>> the same core topology.
>>
>> For better utilization of feature words and help to identify core type,
>> X86_FEATURE_HETERO_CORE_TOPOLOGY is added as a few scattered feature bits.
> 
> This sentence is not needed.
> 
>> PDF p274
>>
>> Link: https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/programmer-references/24593.pdf
> 
> This link will become obsolete, you can say instead
> 
> Search the web for "architecture programmer's manual volume 2 system
> programming docID #25493" in order to find the official document.
> 

Another option is to upload it a non ephemeral location like a kernel 
Bugzilla and link to that.  I do recall there is a bug already opened 
for this purpose in the past.