Received-SPF: pass (google.com: domain of linux-kernel+bounces-210070-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Zi Yan <ziy@nvidia.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: akpm@linux-foundation.org, hughd@google.com, willy@infradead.org,
 david@redhat.com, wangkefeng.wang@huawei.com, ying.huang@intel.com,
 21cnbao@gmail.com, ryan.roberts@arm.com, shy828301@gmail.com,
 ioworker0@gmail.com, da.gomez@samsung.com, p.raghav@samsung.com,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/6] mm: memory: extend finish_fault() to support large
 folio
Date: Tue, 11 Jun 2024 10:38:06 -0400
Message-ID: <DF94C669-963F-4BA7-81A1-B25031D2365A@nvidia.com>
In-Reply-To: <3a190892355989d42f59cf9f2f98b94694b0d24d.1718090413.git.baolin.wang@linux.alibaba.com>
References: <cover.1718090413.git.baolin.wang@linux.alibaba.com>
 <3a190892355989d42f59cf9f2f98b94694b0d24d.1718090413.git.baolin.wang@linux.alibaba.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_5D0B588D-92B6-4D60-92FB-B03AC35FAE69_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?S2t5w3MpvZWScS7iYdK+JGfCmNTwjwyPAm5CMEaAdlitWgmYUP3aS8j7jfAu?=
 =?us-ascii?Q?6EwMP6i+WXGRV50z2bItZefW60lzUhQEKhT7HLTf+hSGfTL/FZ1bxiL+7rGH?=
 =?us-ascii?Q?2TFA5Kt3DiRYuU4McFVvZo+4IpRAjSnVF9qZjYLnr6VtUk+prlHlRqK0EuW4?=
 =?us-ascii?Q?twgTkspX6p3ANwy0z6njber4o3BicEkPjKnD4I+EfmsE/P9yyZQF9uXsLKef?=
 =?us-ascii?Q?X0AGqQfSJM9ghpbgrhQSM7N+JhXASPkaXEs5srDhuPnT3m1LCwdLVIuilk/h?=
 =?us-ascii?Q?prY2KF0CKsczEM83eEJsy2F7GtcmdHlQJHT6X2gsJIxS2j4qkB8fKuFiNiJe?=
 =?us-ascii?Q?CZG/iyU5373HlfujQNFwbRsgJ6NL9DZa0YhflvjgAUVVCv9zJH1n0VuNl1Km?=
 =?us-ascii?Q?RsArbeaQ8ilu9vNH+6WN8vB8MLTNKR1L+wpZ+ack7ss14d6p2qenUW9kDe24?=
 =?us-ascii?Q?YPlc2elV9+FWOK+UtDR1DbQpmyB23bYt1BDOwhGVCVBkxW+wmmrKnPDunXBA?=
 =?us-ascii?Q?zaEwK7oFCJsqsgBQRYNKuPvF82/mbs5+gm++Avz3DNFmuaim1I3yQwrNkFyO?=
 =?us-ascii?Q?wW86VJgTlrRtlbDHkv2T7F9TEiyZaNBCz0HJrxf0LVt1poJLYvYZxcPa+OJT?=
 =?us-ascii?Q?RCYe1Hypsb+HuTw164r3PET17NNu27Z0tixHMuhyVcUkCWKidvcdqLgL14Sw?=
 =?us-ascii?Q?uBJnzWpQrqR1W56ZYhiO6toeUUrE9JhRUuCemQ6bb7W+ux7k5Xc5pfr6wydA?=
 =?us-ascii?Q?xbtagwKkQ67h8h2VSEXJ0nW3sNZG9ptEOePKmODzc7+qsqa19FiIQgqCrylF?=
 =?us-ascii?Q?oMJfmZOwtUqqBswx1KVlAbG3BzeWqe00sEf2w7QN1XN+o+kDAHeKbD1e5Xe5?=
 =?us-ascii?Q?VjyfhLkF/8IcbdJpu+IZDkxQ+2zIwi0rkQNotMt/mg7Qvo/cLwGlxfWd/pV/?=
 =?us-ascii?Q?Maj+bKoOvSDaYA0S/4nGpE+3J+K+w6+loovlxSErn36kx3ltDzNY/MLMfP80?=
 =?us-ascii?Q?/aS3CsWooNQJ5cuSMUTN7S1KOTkgEMsDHd8gt0fYgYBPLmjdWejh1CD5CPrF?=
 =?us-ascii?Q?XdVdbCJc3fW0LV4lsDkT/hoeQq5O9/vv27YKMrnvwQsciW3afQRtHkEgFRp6?=
 =?us-ascii?Q?EU7rG0UqA8WKnwhCP/tzqheva+XWCwNZ2NOeet363JjTyDp1XtrOMpl86xGV?=
 =?us-ascii?Q?WRdDIZLlTiGqnQQHdenDToibrwZFB+kN9BScShAZcKHsdBNvf4RXTHS04h7S?=
 =?us-ascii?Q?K0FwMynhHexAtM5qJzyUpOyJBx+4mnfD3cAehQyAupwJlihmtC4+FdtOZI/W?=
 =?us-ascii?Q?ZhO88H3YX6HZZoOTwceQFh04xVZ1dc49+kKWRqzh0qQVlZ1bRo8Tkk0xDyvg?=
 =?us-ascii?Q?kf5C6tEgd1m41wW8fYoey7inZHsm5KAj2UJRzii4GJ1E92+tSUf+D839Ve+K?=
 =?us-ascii?Q?57MjJlahrAt3eVsV6VNV8dqxOI3UrvBm81F/7GgyNyQUYPUfpu3TzSeEh+W7?=
 =?us-ascii?Q?Z9ZhtpmgHG5aK5QtU5xHi5K1usrUZ1FBNgm4yxu5VJuFkEvirAtOddxahPy3?=
 =?us-ascii?Q?WtzAuwXdKaSXprtmBZ0=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c4491e0b-8cc9-4de5-4b36-08dc8a241d01
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 14:38:09.1335
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: llc8P1FX/WeQqlyTGj9Ymd4L2/FMyz1wvEIPwlFTDzIIPLt9keUbXckMHodD/7t5
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB9058

--=_MailMate_5D0B588D-92B6-4D60-92FB-B03AC35FAE69_=
Content-Type: text/plain

On 11 Jun 2024, at 6:11, Baolin Wang wrote:

> Add large folio mapping establishment support for finish_fault() as a
> preparation, to support multi-size THP allocation of anonymous shmem pages
> in the following patches.
>
> Keep the same behavior (per-page fault) for non-anon shmem to avoid inflating
> the RSS unintentionally, and we can discuss what size of mapping to build
> when extending mTHP to control non-anon shmem in the future.
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
>  mm/memory.c | 57 +++++++++++++++++++++++++++++++++++++++++++----------
>  1 file changed, 47 insertions(+), 10 deletions(-)
>
LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

--=_MailMate_5D0B588D-92B6-4D60-92FB-B03AC35FAE69_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmZoYU4PHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUBY0P/j0UWFAUDT7rr6YC4L6lxJE/Swa8I2CZnL0d
X8XGiOGKVHLPIE9AjnsiThFaZvYeT1aJ3nmlLGESNA7aPNHMzLWcv3geBNZXbzhM
hIz8kR9dLk7JCiFoivW6exkTaODz/K3AJlpbFg4BQzMIJuQf2UM53Zn4SaSvFBn4
ljZOhw2anwcV29+Li+6CFCLwbYtMmPjzEPhn4Af2jCrcSdJyiopi0qjpLM8lnKtD
rHtntj4o1hdvggDIb+Tx3nv2ARFdlbiokZSDwW4gqfLj7tX7nxp+MTA6YOlr8BgP
4niFweX1Ow4ELWPt0p8uZ3agwXd7eYqqBVOqMar5sdz4XvmZyqBOmW+HhYZrlCvh
z/o1IVWk2NtycU5KrDbXeUb9U/D8wa2mMvDDMoAdsaLfj4Dut1EcIdlgGybwXaUa
2SBxYjFsLj2R/A0BZKpLVqHj8VAK88WXya/NZJt2Z0+OCAA0x39vjOTJ3Q7Mh53g
yhQeFQ0NqJ04pNxwJbJfRq59IsRmuhvgmzwoaT89BknPsBMlvGCX7/hcH3zgiH1e
2ssMSH8UIcx9hdppR5Qa2T6KW8NGQuUIcvz7C2OVxswtFV7zuzUvxKxFTPTa6KxD
di8WJX+9ZaRr8MWMbniq75NwTOtvA+dzwwVK7wtBlDGwbJ1OC/tvhk7KU2Tg7V7B
DSyqwM2L
=wvFq
-----END PGP SIGNATURE-----

--=_MailMate_5D0B588D-92B6-4D60-92FB-B03AC35FAE69_=--