Received-SPF: pass (google.com: domain of linux-kernel+bounces-210081-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <43e24489-a3af-4e53-afc6-ff1dd9462ee2@linuxfoundation.org>
Date: Tue, 11 Jun 2024 08:46:39 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] selftests: seccomp: fix format-zero-length warnings
To: Kees Cook <kees@kernel.org>
Cc: Amer Al Shanawany <amer.shanawany@gmail.com>,
 Andy Lutomirski <luto@amacapital.net>, Will Drewry <wad@chromium.org>,
 Shuah Khan <shuah@kernel.org>, linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org,
 Javier Carrasco <javier.carrasco.cruz@gmail.com>,
 kernel test robot <lkp@intel.com>, Shuah Khan <skhan@linuxfoundation.org>
References: <be032a65-e61b-40e0-a982-cb622ccca548@linuxfoundation.org>
 <20240607124117.66769-2-amer.shanawany@gmail.com>
 <a461ba9f-b171-4b49-b282-1f4e2830f31e@linuxfoundation.org>
 <202406100957.750569FFD1@keescook>
Content-Language: en-US
From: Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <202406100957.750569FFD1@keescook>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 6/10/24 10:59, Kees Cook wrote:
> On Fri, Jun 07, 2024 at 02:58:47PM -0600, Shuah Khan wrote:
>> On 6/7/24 06:41, Amer Al Shanawany wrote:
>>> fix the following errors by removing empty print statements:
>>> seccomp_benchmark.c:197:24: warning: zero-length gnu_printf format
>>>    string [-Wformat-zero-length]
>>>     197 |         ksft_print_msg("");
>>>         |                        ^~
>>> seccomp_benchmark.c:202:24: warning: zero-length gnu_printf format
>>>    string [-Wformat-zero-length]
>>>     202 |         ksft_print_msg("");
>>>         |                        ^~
>>> seccomp_benchmark.c:204:24: warning: zero-length gnu_printf format
>>>    string [-Wformat-zero-length]
>>>     204 |         ksft_print_msg("");
>>>         |                        ^~
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Closes: https://lore.kernel.org/oe-kbuild-all/202312260235.Uj5ug8K9-lkp@intel.com/
>>> Signed-off-by: Amer Al Shanawany <amer.shanawany@gmail.com>
>>> ---
>>> Changes v1 -> v2:
>>> removed empty print statements
>>
>> Kees,
>>
>> Is this change okay with you. I didn't see any use for
>> these empty ksft_print_msg().
>>
>> I will take this patch if you are okay with the change.
> 
> Dropping these means that the "#" marks go missing. Currently:
> 
> # Running on:
> # Linux proton 6.5.0-25-generic #25~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Feb 20 16:09:15 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
> 
> with the proposed patch:
> 
> # Running on:
> Linux proton 6.5.0-25-generic #25~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Feb 20 16:09:15 UTC 2 x86_64 x86_64 x86_64 GNU/Linux
> 
> This breaks the TAP syntax for the test, so we should find a different
> solution.
> 
> Perhaps:
> 
> ksft_print_msg("%s", "");
> 
> ?
> 

Thank you Kees. Yes that would work.

Amer, please send me v3 based on Kees's suggestions.

thanks,
-- Shuah