Received-SPF: pass (google.com: domain of linux-kernel+bounces-210069-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 11 Jun 2024 16:36:51 +0200
From: David Sterba <dsterba@suse.cz>
To: Johannes Thumshirn <jth@kernel.org>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: Re: [PATCH 1/3] btrfs: rst: remove encoding field from stripe_extent
Message-ID: <20240611143651.GH18508@suse.cz>
Reply-To: dsterba@suse.cz
References: <20240610-b4-rst-updates-v1-0-179c1eec08f2@kernel.org>
 <20240610-b4-rst-updates-v1-1-179c1eec08f2@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240610-b4-rst-updates-v1-1-179c1eec08f2@kernel.org>
User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12)

On Mon, Jun 10, 2024 at 10:40:25AM +0200, Johannes Thumshirn wrote:
> -#define BTRFS_STRIPE_RAID5	5
> -#define BTRFS_STRIPE_RAID6	6
> -#define BTRFS_STRIPE_RAID1C3	7
> -#define BTRFS_STRIPE_RAID1C4	8
> -
>  struct btrfs_stripe_extent {
> -	__u8 encoding;
> -	__u8 reserved[7];
>  	/* An array of raid strides this stripe is composed of. */
> -	struct btrfs_raid_stride strides[];
> +	__DECLARE_FLEX_ARRAY(struct btrfs_raid_stride, strides);

Is there a reason to use the __ underscore macro? I see no difference
between that and DECLARE_FLEX_ARRAY and underscore usually means that
it's special in some way.