Received-SPF: pass (google.com: domain of linux-kernel+bounces-210104-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 11 Jun 2024 10:58:21 -0400
From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev,
	krzk+dt@kernel.org, linux-kernel@vger.kernel.org,
	linux-mmc@vger.kernel.org, robh@kernel.org, ulf.hansson@linaro.org
Subject: Re: [PATCH v3 1/1] dt-bindings: mmc: Convert fsl-esdhc.txt to yaml
Message-ID: <ZmhmDTOE3GJ7jN2G@lizhi-Precision-Tower-5810>
References: <20240605185046.1057877-1-Frank.Li@nxp.com>
 <b1c51acc-441d-4484-adef-1da368571097@kernel.org>
 <8901d498-d30a-43db-bda2-25d3d1d58e8d@kernel.org>
 <ZmcOyVmI5GhRUuVc@lizhi-Precision-Tower-5810>
 <1a5144e3-aad6-4a1e-ab9f-4c879b050d45@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1a5144e3-aad6-4a1e-ab9f-4c879b050d45@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?40OeXGetQGO06/UehospDsDzDiciWtJRDc2ACFM+jifLBQbHId0SoIe8K/+7?=
 =?us-ascii?Q?eAncSQmZWOXQUCgX2ymUnpv/7y7HhMLZ9xLmgeDV0788+nIhWUZYrl+U9Enu?=
 =?us-ascii?Q?HaizScGc3iftA7Zx2P1B8EOXvkNtmq9YkPc9JS4J7Jdc+6reW5T8ryP6TD2n?=
 =?us-ascii?Q?KuYMiP0moQhCXxWkmKy+3NjN9VxCWiFxbPAPy29WW3ijbj1jlcZbhhhSRAY4?=
 =?us-ascii?Q?dpPXmc4TWVMIItXLZIEIl55gpJEceRgQsc6jnb9wQIp2S0RpXxQ3U6KfYHE0?=
 =?us-ascii?Q?OCaR+VV4k6uHRFHpdE17lfmu6ukCReP/h8BLz56tpEmOvYc/EQMskLPuSBnz?=
 =?us-ascii?Q?w2AzexoC0mGuahPm5Y0Xf4JimGAvbNws5Y4PjYzzJP25lamIv1CGSTfwrIk1?=
 =?us-ascii?Q?TNezi5c7dyl9ZwGdqW3bCkuRQTcDrsHj9wzZXrvmSLKeOxPZ7LyYQgd+RA+U?=
 =?us-ascii?Q?WzKy6KjviAZt9UjKOTszQ4Wtij9bu2DyvylvwnwtkjXYIZSCsud7PilvVwCF?=
 =?us-ascii?Q?cTcY9FtMrLg8lIGsRCj4ff+MZuyW23QLZ88sjA2Xc5ywV1hpi829X8mtG9MQ?=
 =?us-ascii?Q?sINa1dARjRiLx3tMlGkFtdzwiA2jTcoo3r1vwSHizoMX/FNZ+0RVp1btqZK9?=
 =?us-ascii?Q?+lcN/wELa7iprciZNOUqFQdmIr92OlwrrZuAdQCYD2f4PTBWhW2pnDJN+cR+?=
 =?us-ascii?Q?IOy6SurAzpSBFHmL76CW9ErBLFt1h8LMmF5rakWyIQI2WktoooGN4UCaroRn?=
 =?us-ascii?Q?A+kKX5MlnrYvu8+/ka7GOuV1YIAp1LSnfVuKy58S2LOD0qC0rex3bhQHl8ex?=
 =?us-ascii?Q?mJs4dAp9alSgFfnXYDc0oVEsQBMFoLNBKoU17Vpc4AjxP6JkQfuojxx7Hw5V?=
 =?us-ascii?Q?VDEMgFCvFsuip9t/GnPVCBsP9iapUvi3JgETU8MfdKsfrweRqu1Kk7ykUbal?=
 =?us-ascii?Q?6h58mqPT0t51YgUDNm7EFguf+7GgRpZre+VQJMDA2aDRAp2OHN7rCyReYXvg?=
 =?us-ascii?Q?Bkt1ala+1568vSK8Eg1PZAyEM+PyE2dCDMB+ZF59QOJ2i8aHGWNNQkhgA6Lc?=
 =?us-ascii?Q?flCSNoib3lniaO5KBXxSeUCnaiyEgRS0nNn6HzdY5+JSAsSsEdbVZLDHHLu/?=
 =?us-ascii?Q?+zDCvZ5MKnu55+DMiiKwfYM5+MU2mOh5LTPyfgNPTccrNZ5bOP6T1l94ITQ+?=
 =?us-ascii?Q?uUEkWJQuc9R9baOY94Lg/opvZY2aAReJv4q7+DkNITamo/AC8+HxCZ/FKM+8?=
 =?us-ascii?Q?j+8LNVy9vRIMYfrzZ3EC0Zh/+gVphKqLKUxM0A5JOW+m0Dz6I8xnmYAk4vg7?=
 =?us-ascii?Q?iKYCbRuPryWg/AHa+L2sDqBPAas8Da5GNrIsKAH+MBEPBKqrzX7vA/vRgTao?=
 =?us-ascii?Q?GttmDmwgyaUWuIPRNzeIhL6YUmsk2vzO9YxhuaSwe3kxDrKaw6xLYHP7Imiz?=
 =?us-ascii?Q?D2scaToS8SCELeOKd7EW9nyVxLfwT0JEGsJsYn3cEnpPDjxcjqQGylFKSBNO?=
 =?us-ascii?Q?ZxYQxNJcqdZNG74LoMcf7xgYBOJf5spQlWO0KQY/8izp/sQtR627gj+UVt0w?=
 =?us-ascii?Q?DPgR4pRZemH7rZMGS3M=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3bd3e0b-0cdb-40e3-b2c0-08dc8a26f4a3
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 14:58:29.9433
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yfP67R8q/u5LzbKgxLfKkVuMg/oyyNopt5R04RI+CWlUO0vljQQTcCDRYgENWbtXIBpasdsUdr30xMUNCooxWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB10010

On Tue, Jun 11, 2024 at 08:44:51AM +0200, Krzysztof Kozlowski wrote:
> On 10/06/2024 16:33, Frank Li wrote:
> > On Mon, Jun 10, 2024 at 02:29:57PM +0200, Krzysztof Kozlowski wrote:
> >> On 06/06/2024 08:44, Krzysztof Kozlowski wrote:
> >>> On 05/06/2024 20:50, Frank Li wrote:
> >>>> Convert layerscape fsl-esdhc binding doc from txt to yaml format.
> >>>>
> >>>> Addtional change during convert:
> >>>> - Deprecate "sdhci,wp-inverted", "sdhci,1-bit-only".
> >>>> - Add "reg" and "interrupts" property.
> >>>> - Change example "sdhci@2e000" to "mmc@2e000".
> >>>> - Compatible string require fsl,<chip>-esdhc followed by fsl,esdhc to match
> >>>> most existed dts file.
> >>>> - Set clock-frequency to 100mhz in example.
> >>>>
> >>>
> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>
> >> Or not... are you sure that DTS validates? Did you test it? kbuild has a
> >> bit different opinion.
> > 
> > Need additional patch to fix this DTS warnings. It needs convert to yaml
> > firstly. If you like, I can create big patch set to fix all emmc related
> > warnings.
> 
> We kind of been here... I raise the problem and you answer with
> something unspecific requiring me to dig more to prove my point. I am
> not going to play more of that game.
> 
> Did you analyze the errors?

Yes, only strange thing is "voltages-ranges".  mmc-spi-slot.yaml impact the
result. I don't know why mmc-spi-slot.yaml apply to 'ls' platform dts. Any
way, below patch can fix this problem.

diff --git a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
index 36acc40c7d181..51cf2e4270252 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-spi-slot.yaml
@@ -27,7 +27,7 @@ properties:
     maxItems: 1
 
   voltage-ranges:
-    $ref: /schemas/types.yaml#/definitions/uint32-array
+    $ref: /schemas/types.yaml#/definitions/uint32-matrix
     description: |
       Two cells are required, first cell specifies minimum slot voltage (mV),
       second cell specifies maximum slot voltage (mV).
@@ -38,6 +38,8 @@ properties:
       - description: |
           value for maximum slot voltage in mV
         default: 3400
+    minItems: 1
+    maxItems: 8


I will send out all patches soon.


> 
> Best regards,
> Krzysztof
>