Received-SPF: pass (google.com: domain of linux-kernel+bounces-210149-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240611141849.2788693-1-abrestic@rivosinc.com> <6b5392f5-209d-4d3e-b5c3-ba875bf8416d@redhat.com>
In-Reply-To: <6b5392f5-209d-4d3e-b5c3-ba875bf8416d@redhat.com>
From: Andrew Bresticker <abrestic@rivosinc.com>
Date: Tue, 11 Jun 2024 11:24:28 -0400
Message-ID: <CALE4mHotopTeAX05knsfQ6U1tYP+pQjWAbS5KbxKH5exU1frtw@mail.gmail.com>
Subject: Re: [PATCH] mm/memory: Pass head page to do_set_pmd()
To: David Hildenbrand <david@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org, Matthew Wilcox <willy@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 11, 2024 at 10:46=E2=80=AFAM David Hildenbrand <david@redhat.co=
m> wrote:
>
> On 11.06.24 16:18, Andrew Bresticker wrote:
> > The requirement that the head page be passed to do_set_pmd() was added
> > in commit ef37b2ea08ac ("mm/memory: page_add_file_rmap() ->
> > folio_add_file_rmap_[pte|pmd]()") and prevents pmd-mapping in the
> > finish_fault() path if vmf->page is anything but the head page for an
> > otherwise suitable vma and pmd-sized page. Have finish_fault() pass in
> > the head page instead.
> >
> > Fixes: ef37b2ea08ac ("mm/memory: page_add_file_rmap() -> folio_add_file=
_rmap_[pte|pmd]()")
> > Signed-off-by: Andrew Bresticker <abrestic@rivosinc.com>
> > ---
> >   mm/memory.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mm/memory.c b/mm/memory.c
> > index 0f47a533014e..f13b953b507c 100644
> > --- a/mm/memory.c
> > +++ b/mm/memory.c
> > @@ -4764,7 +4764,7 @@ vm_fault_t finish_fault(struct vm_fault *vmf)
> >
> >       if (pmd_none(*vmf->pmd)) {
> >               if (PageTransCompound(page)) {
> > -                     ret =3D do_set_pmd(vmf, page);
> > +                     ret =3D do_set_pmd(vmf, compound_head(page));
> >                       if (ret !=3D VM_FAULT_FALLBACK)
> >                               return ret;
> >               }
>
> That certainly makes the "page !=3D &folio->page" check happy.
>
> It is *likely* incorrect if we would ever have folios > PMD size (which
> we don't have on that path yet).
>
> I assume that the thp_vma_suitable_order() check would detect any kind
> of "different placement of the folio in virtual address space", where we
> could mess up.

thp_vma_suitable_order() checks that the folio fits in the vma, if
that's what you mean.

> Question is: should we instead drop the "page !=3D &folio->page" check
> that I added?

Indeed that's probably better as I'm now noticing that
filemap_map_pmd() has the same issue. Will send a v2.

Thanks.
-Andrew

>
> I think I added that check because I saw the "compound_order(page)"
> check and assumed it would return 0 for tail pages, but missed that we
> get the compound head first.
>
> --
> Cheers,
>
> David / dhildenb
>