Received-SPF: pass (google.com: domain of linux-kernel+bounces-210171-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240608172147.2779890-1-howardchu95@gmail.com> <ZmhsSF1UPcNZX8E_@x1>
In-Reply-To: <ZmhsSF1UPcNZX8E_@x1>
From: Howard Chu <howardchu95@gmail.com>
Date: Tue, 11 Jun 2024 23:43:56 +0800
Message-ID: <CAH0uvoj94J_1BX6H3kpCbw9Djrqf5BTG7XPsDbQSkg=ZBz27-Q@mail.gmail.com>
Subject: Re: [PATCH] perf trace: Fix syscall untraceable bug
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: peterz@infradead.org, mingo@redhat.com, namhyung@kernel.org, 
	mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, 
	irogers@google.com, adrian.hunter@intel.com, kan.liang@linux.intel.com, 
	mic@digikod.net, gnoack@google.com, brauner@kernel.org, 
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-security-module@vger.kernel.org, bpf@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello Arnaldo,

On Tue, Jun 11, 2024 at 11:25=E2=80=AFPM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> On Sun, Jun 09, 2024 at 01:21:46AM +0800, Howard Chu wrote:
> > as for the perf trace output:
> >
> > before
> >
> > perf $ perf trace -e faccessat2 --max-events=3D1
> > [no output]
> >
> > after
> >
> > perf $ ./perf trace -e faccessat2 --max-events=3D1
> >      0.000 ( 0.037 ms): waybar/958 faccessat2(dfd: 40, filename: "ueven=
t")                               =3D 0
>
> Yeah, before there is no output, after, with the following test case:
>
> =E2=AC=A2[acme@toolbox c]$ cat faccessat2.c
> #include <fcntl.h>            /* Definition of AT_* constants */
> #include <sys/syscall.h>      /* Definition of SYS_* constants */
> #include <unistd.h>
> #include <stdio.h>
>
> /* Provide own perf_event_open stub because glibc doesn't */
> __attribute__((weak))
> int faccessat2(int dirfd, const char *pathname, int mode, int flags)
> {
>         return syscall(SYS_faccessat2, dirfd, pathname, mode, flags);
> }
>
> int main(int argc, char *argv[])
> {
>         int err =3D faccessat2(123, argv[1], X_OK, AT_EACCESS | AT_SYMLIN=
K_NOFOLLOW);
>
>         printf("faccessat2(123, %s, X_OK, AT_EACCESS | AT_SYMLINK_NOFOLLO=
W) =3D %d\n", argv[1], err);
>         return err;
> }
> =E2=AC=A2[acme@toolbox c]$ make faccessat2
> cc     faccessat2.c   -o faccessat2
> =E2=AC=A2[acme@toolbox c]$ ./faccessat2 bla
> faccessat2(123, bla, X_OK, AT_EACCESS | AT_SYMLINK_NOFOLLOW) =3D -1
> =E2=AC=A2[acme@toolbox c]$
>
> In the other terminal, as root:
>
> root@number:~# perf trace --call-graph dwarf -e faccessat2 --max-events=
=3D1
>      0.000 ( 0.034 ms): bash/62004 faccessat2(dfd: 123, filename: "bla", =
mode: X, flags: EACCESS|SYMLINK_NOFOLLOW) =3D -1 EBADF (Bad file descriptor=
)
>                                        syscall (/usr/lib64/libc.so.6)
>                                        faccessat2 (/home/acme/c/faccessat=
2)
>                                        main (/home/acme/c/faccessat2)
>                                        __libc_start_call_main (/usr/lib64=
/libc.so.6)
>                                        __libc_start_main@@GLIBC_2.34 (/us=
r/lib64/libc.so.6)
>                                        _start (/home/acme/c/faccessat2)
> root@number:~#
>
> Now to write another test case, this time for the landlock syscall, to
> test your btf_enum patch.
>
> In the future please add the test case so that one can quickly reproduce
> your testing steps.

Thank you for testing this patch, sorry for the inconvenience, I will
attach tests to speed up reproduction in the future. Also, your
simplification looks good, thank you so much.

Thanks,
Howard

>
> - Arnaldo