Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp443271lqp; Tue, 11 Jun 2024 08:51:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUzyXYi9DeTU2D7DKJh8i/aa7rbHVEi02sYvy6virw58S908YgyBtxxhOnIRi4ROHKBpAAvRzy4b45ZQpdzeTxWP1P3kGunCFkWBx6B9g== X-Google-Smtp-Source: AGHT+IHuTiUZ+MZ60Ua6K5DzYCshZ1DdFU6XakS0uSWOKVknjWctZEOVzGrQZkClAB6wVxm7EMjC X-Received: by 2002:a17:906:c419:b0:a6e:f793:fcf6 with SMTP id a640c23a62f3a-a6f34cc5803mr195539066b.16.1718121085242; Tue, 11 Jun 2024 08:51:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718121085; cv=pass; d=google.com; s=arc-20160816; b=XbVtu9NXE8/ZGy1HnhvrkbK4sgCRBzEss2S+fxrZgZFmrCKR6zFqaeUOIijRMYlRWr StNkUAc4mVkQZL8nkmIg8L0QUz2REmVE3jDmTzYtL8IGcJbNxWrRz9Msapf1sWlePoa1 4k/2ORu0hTLmus7wH90KrGwkrA/dq2XGonyjgjLJNRj997qZuGLpgEz4WHG2etcz8lsP HYZc1EsShSG9NoNyynidhA8ItFIL0gKgKpK9fHgckJOf9LKY3CKJ7477nqLw+YETj8GC hqGsUq3zqtTqAFc83X5unEPMcYk7/EmyP6Go32u08XNjK9XEY9oEX+LU3Nko6bNXhKCE 15Yg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:to:from:dkim-signature; bh=ZEVbSLpm/Z3YbHzRAdGjY29U7yyafLlOgKkwbu3Z9/8=; fh=oKyAik634ai0gfrdsHqz+hIjO0hWemLaZVJW1FsE2lI=; b=dStwq4KcetG/zaHp7i2RrciHG4RUasn0ZAcChCjztmr5yX42x6W0qYlWURNFVQOAVK vtlm6pb/YZw0sPN1R09GzPzK6oNsz5xop0hqLPP6EoeYIoieMQYZ7/vNAIM/DfAZBTBR 7Imruo4EuHz047VEOPoP0gwPdvFDJNeWCZk8ICuWWuXjrwMZnd6ozs/zT2CuMLPpg1mb HL03UUdMprmMqRjXdk9oHRjjQtZtOEVRK943P6/sFQJ6RZkIBq19o11tfYQEsn6EC8os cgfBWBG3YMbFGh5fOXGPGrwJMkYIRGtBDQDSD9MrhSMBsdH2SVtYMUg1ETDO69gA3a0B zoRQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="W/teeE0D"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-210178-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210178-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57c9f0e6918si277420a12.95.2024.06.11.08.51.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 08:51:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-210178-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="W/teeE0D"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-210178-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210178-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id EF61F1F228A3 for ; Tue, 11 Jun 2024 15:51:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E081A39ACC; Tue, 11 Jun 2024 15:51:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W/teeE0D" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0687B3B791; Tue, 11 Jun 2024 15:51:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718121065; cv=none; b=XHiqDf+jcan3Lk+8JjJlIlQYWA1sheFeR1jejQ8xS5ut/YSHOXZtvPPf8AOwhRDISZVGANSoQYw/YBjl+iAiT7dCfQ1dc4DqLXITS+WjHQK62bqU062W6Wcd30F4Q3sCy1TOsZj8JGuF3KUfLEPX9W1WC9HqzYnS9UdAHC11VD8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718121065; c=relaxed/simple; bh=EZQe5/HnTww6x2nEO1a/sr9nJZxv9d+5ZjS74clg2LY=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qHdIkr5PRhs5TfNxc3nIG9pg3yPwdVeTHm0KW06H+j4dP8xLKRspwzNLVOcOuuMBGMpU/r+t04PCLRfSW98sQGH94PX6TJ+GjGRK/8iYPN7eqncDELA1Js5D3pYg4BAZCYG6faPicki7fh6vwvYKAZb2XE/ik1jTpdCdQEw2Lgg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W/teeE0D; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0DA0C2BD10; Tue, 11 Jun 2024 15:51:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718121064; bh=EZQe5/HnTww6x2nEO1a/sr9nJZxv9d+5ZjS74clg2LY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=W/teeE0Dmia180ZRLOzNknOOT8F3PQ3R7sM1Y6pEMJOXc3b7PEQDsFe9wX989b47+ 1GgAPNTFpfgnn480HxRYEDrqaPresY0mt9klkEyjRk2CaL42vXC9ewb+0+trt3SNDp VnSxqHj9itgXa2CXSig18SBuRNAh/WJWZKfHszSUSdp5g561EkIN3vNj69bcL3GW1v GTp2LK92t1mxHuvgXe/TNiOnyZ8VBhQRtUwO7mo8/FHbBfFLJSRbBHxdO4yInrfXE9 EmYRdZKraOwez2nZB69FjmE0NgYPDxfWeyjz4/PDqV8kEHdxA6Q8GBljGRqzF2nMv7 0loVbALKvaAIQ== From: Namhyung Kim To: weilin.wang@intel.com, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Ze Gao , Leo Yan , Ravi Bangoria , Dmitrii Dolgov <9erthalion6@gmail.com>, Song Liu , James Clark , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Ian Rogers Subject: Re: [PATCH v3] perf evsel: Refactor tool events Date: Tue, 11 Jun 2024 08:51:00 -0700 Message-ID: <171812103921.884988.5218086373127987409.b4-ty@kernel.org> X-Mailer: git-send-email 2.45.2.505.gda0bf45e8d-goog In-Reply-To: <20240503232849.17752-1-irogers@google.com> References: <20240503232849.17752-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Fri, 03 May 2024 16:28:49 -0700, Ian Rogers wrote: > Tool events unnecessarily open a dummy perf event which is useless > even with `perf record` which will still open a dummy event. Change > the behavior of tool events so: > > - duration_time - call `rdclock` on open and then report the count as > a delta since the start in evsel__read_counter. This moves code out > of builtin-stat making it more general purpose. > > [...] Applied to perf-tools-next, thanks! Best regards, Namhyung