Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp445379lqp; Tue, 11 Jun 2024 08:55:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWmLxabvYrHxuZhBqUkh+DJeEj+aDiH8JQ8Ryz6L5FHM6e2D4hObYo3PaS2hZ/Lh/yrabh1H7pBII1uh7D9kzEW62eqg3lttnB8sC2TqA== X-Google-Smtp-Source: AGHT+IGK6PhNyl2oBDOma9LiZssvf5uFbyVLNS8Yro/hL+SaTdjB286T132BrwFKXboDgqzGlqWR X-Received: by 2002:a2e:96c4:0:b0:2ea:ea29:32b2 with SMTP id 38308e7fff4ca-2eaea293429mr77044571fa.31.1718121333294; Tue, 11 Jun 2024 08:55:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718121333; cv=pass; d=google.com; s=arc-20160816; b=SozItanb78wqPi4MlC5WPQkbdT2NBWBurDEqJiX0ovoIq6tWqU7rXHDvOnUTi7bVET prH+luC3ebVHIlkyKkQw5ig7+D+vxfhmTI36ZB7Qrvf+fyNbazO+oE5EVT32ry8iWRzP qWZCsWCyQIx+ZygC1ISotdiDVlIeRALCfxQCJwMdEJGK9w+qRm1rMAym040ugi/ka7xn 1bzmKq91sDrae8Ix7/w3DRyNLIiQXU+qxY+HdYMeLCfS+fIGBo9qblfTjp5j8qv31BE0 6rJoPmotQLkDlsvZdQ8fn4yhN7xw4VKaJlmIO0BeX88ceEo5etJRpScebS2qLpTXE32T +l4g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=gTBCsfT/FoEZjfkp+/88uvPEW9jcevZaStmZIljnz28=; fh=V9uoOGUyGBeK0GbDOYuclysDz1vHGb2OZQjw6F9AXRc=; b=dUDtuT6z86ZBeyIe4Myt5GWERqxdJNYsmwPdeQrj2jNCEKS1aP6hRqaoJ//tXkRkOZ mR7eA7SdXv80ChNJpWJ3bXQ3HeJeBve0yDpgKxFjewkryg774iYCI9L9Yf1I7Smpce6A VNULC7HjG3e9I59QH5TkOnUe5nQTN438J7NpK59ENnWnk+VvqGMmLo8S3uRM2sLZd8kW +mYaBOhEvSGW1zXPqP5dhETblvMLoCHgvaBM4fsgjQ2Xpdzoc99P6MleVprjwVnyxb7k LMSyVc5RtjzGcHjeH3Vyo/nydjsAw8yCdkdcEt0wrGIq+28zFKYcff6zcKr7JAOcbuAh 4znw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=p8+9jCWL; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-210187-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210187-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57c5f8900f4si4625629a12.274.2024.06.11.08.55.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 08:55:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-210187-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=p8+9jCWL; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-210187-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210187-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E675C1F2275C for ; Tue, 11 Jun 2024 15:55:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CA35539FD0; Tue, 11 Jun 2024 15:55:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="p8+9jCWL" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48C0E1EB31; Tue, 11 Jun 2024 15:55:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718121323; cv=none; b=p4fZBQhu4AGG4AsNjnU65gkskb9+ngRhftsfmhXuqbfW+//vIbG59mJfQc2KhO2/3lJckYUjvkvI0CspzoTBhF6DjLZIAvX8mXnqtAqkzgkny544OL7iY+5/S8BQIslyp/V9+VQ3mnndiPcKxVZDW+bmPp1Lsyk0e7yx3Dojfx8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718121323; c=relaxed/simple; bh=xDDj3IA8z91sfAPS3SuuNuK4ZRTdYmydM2gvEY9GTh0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a0uxQvV875djFqu9tDP4B36zvJBaDEdgfOELPczP32CkOLbg/KIJxzBHa1fl9wCNcblJyPXF/uz7S7LP7aou17NTtGjOVq4fzA5X54U5iY+VOmlPZcLIO5r13xyHMs0YSYYSq4p1Pl0wvjZR74f2E8ZEREKZj4HhAHKPcz+gQ2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=p8+9jCWL; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=gTBCsfT/FoEZjfkp+/88uvPEW9jcevZaStmZIljnz28=; b=p8+9jCWLUAlDHl8wNaDONdQrIm q6q8bfJKklSncqLW2rB9ZyY1x+WqjIyWjNu0aQh4GhJgCWe2EhoD1tHb+qBjad44aYQ958Jh4fPAp cBLKyhlz6aAomd82N9LxZrtuHNDeLYVJHtWeurVziwr+bVgZrxa8R0UI9Pjh3lzA1hV4=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sH3q4-00HOxJ-6R; Tue, 11 Jun 2024 17:55:12 +0200 Date: Tue, 11 Jun 2024 17:55:12 +0200 From: Andrew Lunn To: Sean Anderson Cc: Radhey Shyam Pandey , netdev@vger.kernel.org, Jakub Kicinski , linux-kernel@vger.kernel.org, Russell King , Michal Simek , Paolo Abeni , Eric Dumazet , "David S . Miller" , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v2] net: xilinx: axienet: Use NL_SET_ERR_MSG instead of netdev_err Message-ID: <49b57b18-c7ba-4059-ab1d-b337017ea8e4@lunn.ch> References: <20240611154116.2643662-1-sean.anderson@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611154116.2643662-1-sean.anderson@linux.dev> On Tue, Jun 11, 2024 at 11:41:16AM -0400, Sean Anderson wrote: > This error message can be triggered by userspace. Use NL_SET_ERR_MSG so > the message is returned to the user and to avoid polluting the kernel > logs. Additionally, change the return value from EFAULT to EBUSY to > better reflect the error (which has nothing to do with addressing). > > Signed-off-by: Sean Anderson Reviewed-by: Andrew Lunn Andrew