Received-SPF: pass (google.com: domain of linux-kernel+bounces-210209-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240611050626.1223155-1-irogers@google.com>
In-Reply-To: <20240611050626.1223155-1-irogers@google.com>
From: Namhyung Kim <namhyung@kernel.org>
Date: Tue, 11 Jun 2024 09:03:25 -0700
Message-ID: <CAM9d7chyxF5LMz+-RQevD5N-vtg-VwaRq3+0kugeN8-vwLzHuA@mail.gmail.com>
Subject: Re: [PATCH v2] perf record: Ensure space for lost samples
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, 
	Arnaldo Carvalho de Melo <acme@kernel.org>, Mark Rutland <mark.rutland@arm.com>, 
	Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, 
	Adrian Hunter <adrian.hunter@intel.com>, Kan Liang <kan.liang@linux.intel.com>, 
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Milian Wolff <milian.wolff@kdab.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Ian,

On Mon, Jun 10, 2024 at 10:06=E2=80=AFPM Ian Rogers <irogers@google.com> wr=
ote:
>
> Previous allocation didn't account for sample ID written after the
> lost samples event. Switch from malloc/free to a stack allocation.
>
> Reported-by: Milian Wolff <milian.wolff@kdab.com>
> Closes: https://lore.kernel.org/linux-perf-users/23879991.0LEYPuXRzz@mili=
an-workstation/
> Signed-off-by: Ian Rogers <irogers@google.com>

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung