Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp460683lqp; Tue, 11 Jun 2024 09:16:24 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVgRIDoqnSipIoA7y3QoXRu6p53FWqEGlMF/+vVCAf7fboT6Dl3eZFU/RWLlYFqdR2oEJ9H6ZYM7KVoyX4INRQEwruFU602Rukx+TL4Bg== X-Google-Smtp-Source: AGHT+IE6shY82EL4kBMutQgQNyi7GWbpwGotlzoJNycRYzEFTtsFt9oakkGeIVY363l4pmnz2K9T X-Received: by 2002:a05:6902:503:b0:dfb:207:dc75 with SMTP id 3f1490d57ef6-dfb0207de82mr12624985276.58.1718122583561; Tue, 11 Jun 2024 09:16:23 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718122583; cv=pass; d=google.com; s=arc-20160816; b=ouznNiu97mn6GxG3pvQjBbiIs2E73XNgPxWWcuznu8EeW7LtSMFZCWkk/An0dHwQnI SNh3fUE9L+lA0WuyliS5/57tT2l++2A+4cjysAcsg9Okggymlywboe1Ijdv4OFVdIxJ3 hbFbKW1kHy6CrLswlyGOZc7n5+Dm1ot9C8Rdp7uOwei3vcqgB8jehlmm8fTNTwInG5bG d4lNchF1JgzEvvTKtPWaF/15G6idhxig4mlhZeutPWkE6QxZV53124XX2gFNf6KtMzFY CRl0LTCwT6WoLXq+nsnQ0trxQf749iDwOx6hBjnm72usLe4WnzQ7a4P1Zg55gXh2XhiI pkXQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=/2DtWye0xQVu5UQ5g0C9fy3z7hFmUEgXG/9sgaT2RjQ=; fh=4mWvKYDvTF3Fn61klR4N/vzL5f8+oGsagwDFr5dEIVw=; b=hlkLNv9EWB5IpXjtCPlresqurD8At1imq67RjH43hNWXUMEzIIzlJzJ2CyqwYfkAct 8f2ix50QbYp6fXYE0wDv6/PKDsDzZ+YFkuCVU1rCbPYTpfmb3+FP70lWpwQ6pUPLkwah gu7P738YXOQ88+Rc34/xRpJGG9fGShBsVzgMRBXY5yfi8d2L/zYxNzuEp7ztyJYS4LNn nv64S/QCRn+gqz4EcT5S2jvDKY+LiRlV7zpeR4xcBCS2IpCupXIwPZH50Oqr8WqaoQKL K/QjmiaW4zSNmDo6xuBR2e+sicJkc3rAjB+sLBFK4EHiqylYmeO95OhilmE5YtOyXPa6 qNHQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=V6nL0zbx; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-210221-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210221-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 71dfb90a1353d-4eb4ad646efsi2483397e0c.244.2024.06.11.09.16.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 09:16:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-210221-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=V6nL0zbx; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-210221-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210221-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 35DEB1C23739 for ; Tue, 11 Jun 2024 16:16:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B00CE3B192; Tue, 11 Jun 2024 16:16:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="V6nL0zbx" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AE5064B for ; Tue, 11 Jun 2024 16:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718122576; cv=none; b=l26Vit5dAKM5d1cFFICsnHo8TrcSGuOOASCGeAjCWZ0gRACRl05xWbFa6KPXZemhqx0n14uufpZexFLXFp4TZUcsEcHRWvah4+XVDsFkytAlE41bieyH0nPPSzwiEyvqhxSJktRIdi94f/CYAZTARyUnPNDxGc0Z0Feisr/hYWU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718122576; c=relaxed/simple; bh=yBpclnzqSK1jb5wfooQUPCNEsbQ8QjuphOLndAYkDy4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B+uarXFmwYhynqLjcRd4VFZ6XedHyS34xrLjGq0tJ8RZeC28yMMHDCUKSHH7qxk6Q9iSGl6E8y0p4a1IYd74AIwvJhabXCKoks6w+Bkx8GyJmi8Tbj9QwG100bBopA30m34Iaox+cyDvB+6frXIcV81snUdWb2wdgUvN5MRYOvM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=V6nL0zbx; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718122575; x=1749658575; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=yBpclnzqSK1jb5wfooQUPCNEsbQ8QjuphOLndAYkDy4=; b=V6nL0zbxYFgprnh0rrXpcjNoU3TwRZ1Uf2OP/9aFn61ryV0fEVBoa9AC k62wqJdLyKNvcODBSjI8ZkQCCtXZ7yzODo1//4zGbVCu9nI+pa0HH3yo+ 4sgq/n7tNGE7knqBssZ4uENJ/I0OsyeznvIP7WnQc/6PjBztYb377ndgI MoXuTZIzE3d1LcylEY6UPrfH5rndzHujZBN/Gbtj+NNoeNnVTfV+UhFN0 IYo7v66spb7k3gmpui4BzCtUqsrq8Nj2nwBp6cx4M5eyVRq62H55B8Ql5 PccCfrBqGG5v7vZtAGRiB3Y0DjcN3YcRKSTQUlwwjyEckL0nXWV4AsRW5 w==; X-CSE-ConnectionGUID: nWMLb1fNQ7KgmUtFddDAqw== X-CSE-MsgGUID: 32PcYUx4QgqLHyal+zYqdw== X-IronPort-AV: E=McAfee;i="6600,9927,11100"; a="26246824" X-IronPort-AV: E=Sophos;i="6.08,230,1712646000"; d="scan'208";a="26246824" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2024 09:16:15 -0700 X-CSE-ConnectionGUID: 719DU7RMRoWc2+Zcauo1Bw== X-CSE-MsgGUID: KW7AOX3vRhu57s5YAoxOUQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,230,1712646000"; d="scan'208";a="39545133" Received: from djiang5-mobl3.amr.corp.intel.com (HELO [10.125.110.130]) ([10.125.110.130]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2024 09:16:14 -0700 Message-ID: Date: Tue, 11 Jun 2024 09:16:13 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/tdx: Generate SIGBUS on userspace MMIO To: "Kirill A. Shutemov" , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" Cc: linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, cho@microsoft.com, decui@microsoft.com, John.Starks@microsoft.com References: <20240528100919.520881-1-kirill.shutemov@linux.intel.com> <4df2ebee-40c0-4ea3-8909-13b90f049ff1@intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <4df2ebee-40c0-4ea3-8909-13b90f049ff1@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/10/24 06:55, Dave Hansen wrote: >> Enlightened userspace may choose to handle MMIO on their own if the >> kernel does not emulate it. >> >> Handle the EPT_VIOLATION exit reason for userspace and deliver SIGBUS >> instead of SIGSEGV. SIGBUS is more appropriate for the MMIO situation. > Is any userspace _actually_ doing this? Sure, SIGBUS is more > appropriate but in practice unprepared userspace crashes either way. I also can't help but wonder if there's a better way to do this. Just thinking out loud.... Ideally, we'd reject creating a potentially troublesome VMA at mmap() time. That's way better than, for instance, panic()'ing at some random place in the middle of program execution. But I guess that's likely not possible because someone could be doing a VM_MIXEDMAP VMA that only has normal private pages and never _actually_ needs or has a shared page mapped. I'd still love to know what actual kernel drivers and actual userspace would be involved in this whole dance. It's still way too theoretical for me.