Received-SPF: pass (google.com: domain of linux-kernel+bounces-210307-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <be0dc105-e205-4b0e-9bd4-49690249fd26@acm.org>
Date: Tue, 11 Jun 2024 10:09:12 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4] block: Add ioprio to block_rq tracepoint
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Dongliang Cui <dongliang.cui@unisoc.com>, axboe@kernel.dk,
 mhiramat@kernel.org, mathieu.desnoyers@efficios.com, ebiggers@kernel.org,
 ke.wang@unisoc.com, hongyu.jin.cn@gmail.com, niuzhiguo84@gmail.com,
 hao_hao.wang@unisoc.com, linux-block@vger.kernel.org,
 linux-kernel@vger.kernel.org, akailash@google.com, cuidongliang390@gmail.com
References: <20240611073519.323680-1-dongliang.cui@unisoc.com>
 <86eb3dd0-77a1-4d1d-8e62-38c46bd7563a@acm.org>
 <20240611125440.6d095270@gandalf.local.home>
Content-Language: en-US
From: Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20240611125440.6d095270@gandalf.local.home>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 6/11/24 9:54 AM, Steven Rostedt wrote:
> On Tue, 11 Jun 2024 09:26:54 -0700
> Bart Van Assche <bvanassche@acm.org> wrote:
> 
>> On 6/11/24 12:35 AM, Dongliang Cui wrote:
>>> +#define IOPRIO_CLASS_STRINGS \
>>> +	{ IOPRIO_CLASS_NONE,	"none" }, \
>>> +	{ IOPRIO_CLASS_RT,	"rt" }, \
>>> +	{ IOPRIO_CLASS_BE,	"be" }, \
>>> +	{ IOPRIO_CLASS_IDLE,	"idle" }, \
>>> +	{ IOPRIO_CLASS_INVALID,	"invalid"}
>>
>> Shouldn't this array be defined in a C file instead of in a header file?
> 
> The way the TRACE_EVENT() macro works, this will not work in a C file.

Hmm ... if the above array is terminated with a { -1, NULL } sentinel and if
__print_symbolic() is changed into trace_print_symbols_seq(p, ...) then the above
array can be moved into a C file, isn't it?

Thanks,

Bart.