Received-SPF: pass (google.com: domain of linux-kernel+bounces-210394-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Liam R. Howlett" <Liam.Howlett@oracle.com>
To: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Vlastimil Babka <vbabka@suse.cz>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        Suren Baghdasaryan <surenb@google.com>,
        "Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: [PATCH 8/8] mm/mmap: Use split munmap calls for MAP_FIXED
Date: Tue, 11 Jun 2024 14:02:00 -0400
Message-ID: <20240611180200.711239-9-Liam.Howlett@oracle.com>
In-Reply-To: <20240611180200.711239-1-Liam.Howlett@oracle.com>
References: <20240611180200.711239-1-Liam.Howlett@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?jf6GsIjh9iPCsDf95Q2U6lVvbXAcNzHt270ExBOBbkiEX5tHYcGoKOO7ekGY?=
 =?us-ascii?Q?u/USv2EjicyMWwX2OG2PwYtZ5LGTpKWD1SlJnBPB/iHm3ZaAy8fy53H8kXT3?=
 =?us-ascii?Q?YGRluxup3LlPIEpn9Pf4+t4Yu/vG29DcNEVp9ltuU0YGGCiUsbjPw/WtwAZ3?=
 =?us-ascii?Q?TQYMq0MVJa3RiSloypc4DFcruXiXjy2FOi8rMyeuZtqTl7RWTyoi/bCL4t2F?=
 =?us-ascii?Q?af3xfYQQnGGcZUp863HDLOBNt/I26vRcNVJuHeA4iryikEn6TYN9yFkOTMzk?=
 =?us-ascii?Q?fKuN+t6ZOby7Zyd8A9Z3TBPz94Kiy0L+Ql30UjlaJH6pkPegPlQtu7Xj2R/5?=
 =?us-ascii?Q?vzw28YMAwmcatFmo8FKhXqtcL5Zs6HmQFOJ16R5H+JzNhXXS23Q5jU3ST4mj?=
 =?us-ascii?Q?CmFZFbnIx09DlLyeeGx/M6z4wqT4VFzNrlbMJaEqTEjpa6hfC9vD8OfMYiaC?=
 =?us-ascii?Q?Px7Y705+NMzTqgbd1qGh5KmxIKtRBQwEweRSTt6dRVw+MfbGpmNySj80rHTi?=
 =?us-ascii?Q?0BlzfWwQNlMM35uPWgABir0gyhYKjUpnXQ9T1cBc750aDyqh4cmRzulJOikG?=
 =?us-ascii?Q?YZrmIWQDXhQvHGaYzTxycc9EHuD4VPXBq0b5A5hGCT6lAy9Ib6jZegl2bfgj?=
 =?us-ascii?Q?PLqeHheNy/TT7IBl6UNX/2xwnbtuKJ2eGkGIL/Yn2TsmBF0R6d2gvA0EOZ8N?=
 =?us-ascii?Q?DoAMwBD+s9iZKcJz2wrG33RrCcCN58lL8JZVtsjasI8T4h3o7AEBPbjf4tB6?=
 =?us-ascii?Q?8NuWbxddR1whGlR6+7RoGe44+bNuen++ifyq3AvOyAIJcrT5YndNS8saL608?=
 =?us-ascii?Q?HjhiT7RPcaSSYeATO/Aian3D1/Wc0Aeuzg66HHKiIns1SlGnKXLyTaz5BHM8?=
 =?us-ascii?Q?QctJ5tALB+7Ypxywzx76Uln0x2o+1x4Nytv8FixLKY06ht+RQFXNublvQS7a?=
 =?us-ascii?Q?vMlYQkz7lKg3QLir/rrfvtWmo0mm6s1eL+HVKIsQxIHKs6vITtvpSDIHXc/d?=
 =?us-ascii?Q?RytWKQcg8tyicjqxK35HE6ot1nJjB5IEUxTkVwZeNNcHr7mxRkC05xA8wNlk?=
 =?us-ascii?Q?bog+uJiLUaDax5VQAVAlVZ5RkTRP/ltglqXLaSgQhvEtzbkIJtZRWGvWcJDw?=
 =?us-ascii?Q?Uf6In3luN03PNIYjQ7JDnIElG4i42ALfGywU98TAb5n4ucyijC6Zwr3/uA5P?=
 =?us-ascii?Q?uoluN2wV3u/alibFabcEGZIzahogMUw8fkQKHX4JciJiHpH4A/fWpwsupV/b?=
 =?us-ascii?Q?OMm2PRscEYnceSHsSJ1O31uzwOv0IMin/TVrKQNvFRUTgXb7IRHdEwGtLd4d?=
 =?us-ascii?Q?QOG/tqKfBQSwVDe6QAJ/4CFDKmmbQFszgXE+hD1npJkBT5ag8Xfk9vAUq588?=
 =?us-ascii?Q?y8CY1DU4xgaeDuWF5+RxYnBAeXcgHWw1s4fgN9kD2QlBQ7AKJSc7ZJ4Ocrxm?=
 =?us-ascii?Q?mBD4XsSnNpGLaa397G5pM1HD714BAln7oCeexj4hS56CtDeqqM9M+cpayKUp?=
 =?us-ascii?Q?8VleBkSlMtXZ702vfsJ5+9wnRhs8tiLV7LjF0GI6Rf/iDjR2sUOtAEGQOiBi?=
 =?us-ascii?Q?pRCSFXZRWSeShzma1hRmMwnHVhcMcaQFnWvfLF/v+F+rE2UONJDptvGicYn8?=
 =?us-ascii?Q?Gw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	7q9HAcuNcMq8hsO6KfBq/ofsMhgpU52EATv2ACEoE4VuOZFHhnMBmxwsjzK9tkfYdCp7Aj0xBceKvVJOMfBDOG+/Y8hzlFqDDmEL7X0YrrYCkJYnCsRZL8IVZQVy+sFb6HBcnAq51F6gq+z2Auw0Gf86svGZH17Eu6Dkvqgr1//MEmhIcq/sQADMiTQpjylDHMGcZkZehs4aYNWQnX+HwxC0Bcb9bcN92teJ3bu7Hns+AuL1BEyMzVgVzwIK+q2C2Au6UH3nuPwtVDuHABd9wJhrY9l1N0k6bI+wuB3sbLKp2PrGm2U2KA+yaY5/7fZTcJ0OFCNpTUaECj5T8kGNFJHS9MlbGkFoky/gYyAvxt7U9/mi1hu+Rnc13mi8IzXcuwAL74vUNDTSShhUcxWOENnE3DAoKfAhcRebQ3+2lI6rn+iY+qaQpYVOcBKt54KNrknRhnmeQpetSku/UcTEeeIc9EpKjbV73KFQot0OCEHSMyNgdNLhBYNRFIRZyaxPIc+s/Q6rIkBXIQ8eUZNIeu7bTyWET8N0cXE7ax8iHe1/gNSDZHvoVHieQOu+pDEwBo7Q8oMadcCKTjfrjWjGPy3e05sBERfEtVmN9C5tIaQ=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d7a2ba15-4c2e-4087-8e95-08dc8a40a77a
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 18:02:27.3447
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Kr0Ij3bgVe8GBlOBLnEtPBT3gZ41HtUZWy2KEc5B0O03RqAswbTkVUL9LW0Dh00i6c+5wBrNySworcHoGB56FQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR10MB7817
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-11_09,2024-06-11_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 adultscore=0
 mlxscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406110123
X-Proofpoint-ORIG-GUID: JH-8Vu6UdR-jT6FDVW5I5Pt1QCmeYvYq
X-Proofpoint-GUID: JH-8Vu6UdR-jT6FDVW5I5Pt1QCmeYvYq

Use vms_gather_munmap_vmas() and vms_complete_munmap_vmas() to prepare
and execute the unmapping after the new area is written to the maple
tree.  Delaying the unmapping avoids RCU readers seeing a gap in the
vmas, which isn't supposed to exist logically.

Gathering the vmas that will be unmapped allows for the accounting work
to be calculated prior to checking if there is enough memory.  Using the
number calculated during vms_gather_munmap_vmas() allows code to be
reduced in mmap_region().  This removes the only caller to
count_vma_pages_range(), so the function has been dropped.

This does have the side effect of allowing vmas to be split for unmap
and fail may_expand_vm(), but the number of pages covered will not
change.

The validate_mm() call in vma_expand() must be dropped as the MAP_FIXED
munmap may be in progress.  There is still a validate_mm() call at the
end of mmap_region(), which calls vma_expand().

Note that do_vmi_munmap() was previously used to munmap, which checked
alignment and overflow.  These checks were unnecessary as do_mmap()
already checks these cases, and arch/mips/kernel/vdso.c
arch_setup_additional_pages() uses predefined values that must already
pass these checks.

Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
 mm/mmap.c | 85 +++++++++++++++++++++++++++----------------------------
 1 file changed, 42 insertions(+), 43 deletions(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index 5334077964b9..e9f91b7b17b6 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -364,23 +364,6 @@ anon_vma_interval_tree_post_update_vma(struct vm_area_struct *vma)
 		anon_vma_interval_tree_insert(avc, &avc->anon_vma->rb_root);
 }
 
-static unsigned long count_vma_pages_range(struct mm_struct *mm,
-		unsigned long addr, unsigned long end)
-{
-	VMA_ITERATOR(vmi, mm, addr);
-	struct vm_area_struct *vma;
-	unsigned long nr_pages = 0;
-
-	for_each_vma_range(vmi, vma, end) {
-		unsigned long vm_start = max(addr, vma->vm_start);
-		unsigned long vm_end = min(end, vma->vm_end);
-
-		nr_pages += PHYS_PFN(vm_end - vm_start);
-	}
-
-	return nr_pages;
-}
-
 static void __vma_link_file(struct vm_area_struct *vma,
 			    struct address_space *mapping)
 {
@@ -692,7 +675,6 @@ int vma_expand(struct vma_iterator *vmi, struct vm_area_struct *vma,
 	vma_iter_store(vmi, vma);
 
 	vma_complete(&vp, vmi, vma->vm_mm);
-	validate_mm(vma->vm_mm);
 	return 0;
 
 nomem:
@@ -2870,47 +2852,61 @@ unsigned long mmap_region(struct file *file, unsigned long addr,
 	struct vm_area_struct *next, *prev, *merge;
 	pgoff_t pglen = len >> PAGE_SHIFT;
 	unsigned long charged = 0;
+	struct vma_munmap_struct vms;
+	struct ma_state mas_detach;
 	unsigned long end = addr + len;
 	unsigned long merge_start = addr, merge_end = end;
 	bool writable_file_mapping = false;
 	pgoff_t vm_pgoff;
-	int error;
+	int error = -ENOMEM;
 	VMA_ITERATOR(vmi, mm, addr);
 
-	/* Check against address space limit. */
-	if (!may_expand_vm(mm, vm_flags, len >> PAGE_SHIFT)) {
-		unsigned long nr_pages;
+	vma = vma_find(&vmi, end);
+	if (vma) {
+		struct maple_tree mt_detach;
 
-		/*
-		 * MAP_FIXED may remove pages of mappings that intersects with
-		 * requested mapping. Account for the pages it would unmap.
-		 */
-		nr_pages = count_vma_pages_range(mm, addr, end);
+		/* Prevent unmapping a sealed VMA.  */
+		if (unlikely(!can_modify_mm(mm, addr, end)))
+			return -EPERM;
 
-		if (!may_expand_vm(mm, vm_flags,
-					(len >> PAGE_SHIFT) - nr_pages))
+		mt_init_flags(&mt_detach, vmi.mas.tree->ma_flags & MT_FLAGS_LOCK_MASK);
+		mt_on_stack(mt_detach);
+		mas_init(&mas_detach, &mt_detach, 0);
+		/* arch_unmap() might do unmaps itself.  */
+		arch_unmap(mm, addr, end);
+		init_vma_munmap(&vms, &vmi, vma, addr, end, uf,
+				/* unlock = */ false);
+		/* Prepare to unmap any existing mapping in the area */
+		if (vms_gather_munmap_vmas(&vms, &mas_detach))
 			return -ENOMEM;
+		next = vms.next;
+		prev = vms.prev;
+		vma = NULL;
+		vma_iter_prev_range(&vmi);
+	} else {
+		vms.end = 0; /* vms.end == 0 indicates there is no MAP_FIXED */
+		vms.nr_pages = 0;
+		next = vma_next(&vmi);
+		prev = vma_prev(&vmi);
 	}
 
-	/* Unmap any existing mapping in the area */
-	error = do_vmi_munmap(&vmi, mm, addr, len, uf, false);
-	if (error == -EPERM)
-		return error;
-	else if (error)
-		return -ENOMEM;
-
 	/*
-	 * Private writable mapping: check memory availability
+	 * Check against address space limit.
+	 * MAP_FIXED may remove pages of mappings that intersects with
+	 * requested mapping. Account for the pages it would unmap.
 	 */
+	if (!may_expand_vm(mm, vm_flags, (len >> PAGE_SHIFT) - vms.nr_pages))
+		goto no_mem;
+
+	/* Private writable mapping: check memory availability */
 	if (accountable_mapping(file, vm_flags)) {
 		charged = len >> PAGE_SHIFT;
+		charged -= vms.nr_pages; /* MAP_FIXED removed memory */
 		if (security_vm_enough_memory_mm(mm, charged))
-			return -ENOMEM;
+			goto no_mem;
 		vm_flags |= VM_ACCOUNT;
 	}
 
-	next = vma_next(&vmi);
-	prev = vma_prev(&vmi);
 	if (vm_flags & VM_SPECIAL) {
 		if (prev)
 			vma_iter_next_range(&vmi);
@@ -2957,10 +2953,8 @@ unsigned long mmap_region(struct file *file, unsigned long addr,
 	 * not unmapped, but the maps are removed from the list.
 	 */
 	vma = vm_area_alloc(mm);
-	if (!vma) {
-		error = -ENOMEM;
+	if (!vma)
 		goto unacct_error;
-	}
 
 	vma_iter_config(&vmi, addr, end);
 	vma_set_range(vma, addr, end, pgoff);
@@ -3082,6 +3076,8 @@ unsigned long mmap_region(struct file *file, unsigned long addr,
 	vm_flags_set(vma, VM_SOFTDIRTY);
 
 	vma_set_page_prot(vma);
+	if (vms.end)
+		vms_complete_munmap_vmas(&vms, &mas_detach);
 
 	validate_mm(mm);
 	return addr;
@@ -3107,6 +3103,9 @@ unsigned long mmap_region(struct file *file, unsigned long addr,
 unacct_error:
 	if (charged)
 		vm_unacct_memory(charged);
+no_mem:
+	if (vms.end)
+		abort_munmap_vmas(&mas_detach);
 	validate_mm(mm);
 	return error;
 }
-- 
2.43.0