Received-SPF: pass (google.com: domain of linux-kernel+bounces-210417-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <1b07a0c6-c973-45b5-94f7-f9234e244a11@intel.com>
Date: Tue, 11 Jun 2024 11:21:48 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] igb: Add support for firmware update
To: "Chien, Richard (Options Engineering)" <richard.chien@hpe.com>, "Richard
 chien" <m8809301@gmail.com>, "davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>, "kuba@kernel.org"
	<kuba@kernel.org>, "pabeni@redhat.com" <pabeni@redhat.com>
CC: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@intel.com>, "intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
References: <20240609081526.5621-1-richard.chien@hpe.com>
 <4f2ec2fb-5d31-4a90-9ef6-a036d16a5cb4@intel.com>
 <PH7PR84MB15819CF12F71CB6D55F50576E8C72@PH7PR84MB1581.NAMPRD84.PROD.OUTLOOK.COM>
Content-Language: en-US
From: Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <PH7PR84MB15819CF12F71CB6D55F50576E8C72@PH7PR84MB1581.NAMPRD84.PROD.OUTLOOK.COM>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXZwR1ExM25Ha05MeDdFSCtmbzF6eE45TDRGclNMM3dVLzNwY2U1ZHdKYjVn?=
 =?utf-8?B?MFBYazR3bVNBeGRiRzdYQkxuY0FnU005SXE4d2gvQ0VGenFldlJlL285K0U1?=
 =?utf-8?B?aWNkWlVUZFFQY1BzTG94bVlhc2tXVi94dzFVYldnTENNY2NVR3ZRT2szN0t0?=
 =?utf-8?B?Yk41Zzg1WFBQMjFzbld0dlhkcjJPcG1oVVVpT0ViaFVsWUMrTy9PcThrZFVy?=
 =?utf-8?B?RzJQcmdBeWpJMHlLWmN0SUFMbkN0ck91TGxRRyt6bzQwUzFJWlRVTWNzVXly?=
 =?utf-8?B?WDh1OEZWenZrL0dncy9jOWVFOGtNaXVSenZwKy9yK2N4cW5OSHVUbVFNY0NG?=
 =?utf-8?B?ZUpyRjAzRTYwK3JEbzlaRlJJZjBaSkF4TFBnMEZKNTk0ajVDcnc2Vm16QjhU?=
 =?utf-8?B?RC83ZDY2bW4xWTZJTnMxcHlJbjZodjlyaGd6TjlNWmEvelh3WjlFajFmdGNv?=
 =?utf-8?B?WnRUSU5aSUtXb2ZwK0pHVEF4ZjZOSTg3eE1OdXRBQjlCcWVIZ3luU1NQRVhZ?=
 =?utf-8?B?NThpSFlsWWZEdnNzR0JoR2ZIaUt4VXcwTDZ6c2xhR3NoWHJGSkVHcFJHWlN1?=
 =?utf-8?B?QnZ5azZoenRzZElrUGJaNHc1dExyMkF0QysvVURBbHVEdlZVV0pmUEQ3NGRj?=
 =?utf-8?B?RHNCRDEyMjdYcW5iL3FGRHRDOFpjbTV5VmM2TVhuaGJJOEZGbVkxWjg1R29B?=
 =?utf-8?B?eDVRcEtrc3E3dVN2NmpMbTZBZnhMV0UrSnNEV2ZnZjRiMVgwY1RKSmZUTnBF?=
 =?utf-8?B?cm5kSXBiRVBCMUw2blkzOFh6eThUTS9TZmNwOVJYZ0RZY1dEUVdZOSs0TTdW?=
 =?utf-8?B?RVcxdjBnZkhzVjUvZDhzU2ZsRVlrbGlDcnhMdEdxYXVhUGhtbmRXaVVlS0Rp?=
 =?utf-8?B?VC9MU2l2cDhleHVSNkoxcnpBUlFmcisvR28zMVpNcmUybkl3VXVQT0VEU2pN?=
 =?utf-8?B?Zk1CQjhwUmJweWNxZUZRVEFMTjN1d0p3K1lkUTNvOHVkY1MxS1Z6QnlHK2J0?=
 =?utf-8?B?bWJEY0FYSk9DMy9vdDRMMGxuVVU5Nnd1T1dFUlhnNGs3dllNL2c5ZUx6c3cx?=
 =?utf-8?B?MmR3MmpZa0tqbzBGUm5IbXlZcjJINkZUU0pzaDZJWER0cE5wQ1d2L01ta051?=
 =?utf-8?B?SU9tQ21iNlVYZ2tXWlowWTRmUXNkMjZHMFMzaUJqZU15c1hpUmdka1lCRWtI?=
 =?utf-8?B?QlYrQ09WbEVXR0RJTGZGOGY4UjArMXA1U3Q4ekMrOGJLbGZuQ0FOOHI4TlZJ?=
 =?utf-8?B?V0FaV2RnK0ZkQ0QzTjc1M2UyTmhHeXdzb3hQbC81MDVnWDdvS0VSaERRYTU1?=
 =?utf-8?B?MUFMRXg5dVd4U1J6OWtxbEhmMjhVbjVaVzA1RTdEQjZLU0hheU1xNnA1dGRm?=
 =?utf-8?B?MDNCK3VOYW5yYWFuU0h0MVdFUGZ1SXlvMHBIQ3Q0TzQvd01LeEJ4KzhXSk1O?=
 =?utf-8?B?N2ZSR0RuT1MwYzJzSVZuZ3N0S0ZsV2xpcWhXS1o0eGhFSzM5b3NSUkV1VUFW?=
 =?utf-8?B?TFlPRmUwWXRMRkk0eUFpZDlXZndLZkV4dnNxVlZLeUJsQ1lnbTZqQlpyYThw?=
 =?utf-8?B?ajRCbEZwSlhBR1NpcHZKMG1MSmZVMWg0UkdZblpDWk14d2xYRkZQVFZKWDhS?=
 =?utf-8?B?U0Y0QkFmQUt1SUFCOEw0OEZxS0NDT0xXN0YzTEhjL3FNVTVtM1lwdm1hQlFl?=
 =?utf-8?B?cTYwL2FRU3NmV3dWQzVFN1pqN1ArNmVsRjhWWEFhSENJR2dQbExTSit0UFc5?=
 =?utf-8?B?MUdVM0xEbGRGa2Q4b2I3QS96L2U0ZTQ4Z0JQeUFQcFFZb25hUndoaEhtUXVy?=
 =?utf-8?B?TmdtRU9VdVNwVXU3Yy9TVlJqOE1zbUdLTGtJQVd0RXM1UzZvMnljejJrSkdj?=
 =?utf-8?B?ZFFTYTlyaEF0MjRBQ2xoMWdUNG1MMkdoU1pRc2tuVGFLOWdQMnJVbkIxajZF?=
 =?utf-8?B?Q2RwS1VMU29DMXdwdWFEaGUwZTVxMjgyS3poQ0ltKzdxZW82OVlUa2trS0hY?=
 =?utf-8?B?U3pOMjhQOWMvQmRTMWxiaDZPempqdkJwTHV4K1RzV1hQK1RIb3FnRENaY21D?=
 =?utf-8?B?cGF4VDd2MEJVdE1hSTE4VWVIOFh5c3B5dms2bEVSUEFBQW9Ham9hUU9mc2NM?=
 =?utf-8?B?bzFMUnhKVlFKbTliYzNXZmhYUG5ReTkvRjhrbXgrdEFBY3JFRHZ6a2ZGR0pv?=
 =?utf-8?B?Snc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6212c0e6-9e1b-49ea-1984-08dc8a435ca4
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 18:21:50.2600
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L1apIibgB12ZYJOO6IrqXcM8XfIhYhqo9t/SipNsmEwgC4b1EqdDRakyXKnohiu+WLLLtKnrSYYamgsTIJnsxFUke2LyEYaO9dSCvm3EGq0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6868
X-OriginatorOrg: intel.com


On 6/11/2024 12:55 AM, Chien, Richard (Options Engineering) wrote:
>> However, this implementation is wrong. It is exposing the
>> ETHTOOL_GEEPROM and ETHTOOL_SEEPROM interface and abusing it to
>> implement a non-standard interface that is custom to the out-of-tree Intel
>> drivers to support the flash update utility.
>>
>> This implementation was widely rejected when discovered in i40e and in
>> submissions for the  ice driver. It abuses the ETHTOOL_GEEPROM and
>> ETHTOOL_SEEPROM interface in order to allow tools to access the hardware.
>> The use violates the documented behavior of the ethtool interface and breaks
>> the intended functionality of ETHTOOL_GEEPROM and ETHTOOL_SEEPROM.
> 
> Thank you for your detailed explanation.
> 
>> The correct way to implement flash update is via the devlink dev flash
>> interface, using request_firmware, and implementing the entire update
>> process in the driver. The common portions of this could be done in a shared
>> module.
> 
> In that case, does Intel have a plan to implement this mechanism
> in in-kernel drivers?
> 

I'm not aware of active plans right now :(

>> Attempting to support the broken legacy update that is supported by the out-
>> of-tree drivers is a non-starter for upstream. We (Intel) have known this for
>> some time, and this is why the patches and support have never been
>> published.
> 
> Although the utility in question has been enhanced to perform firmware
> update against Intel 1G/10G NICs by using the /dev/mem, this method
> would not work when the secure boot is enabled. Considering out-of-band
> firmware update (via the BMC) is not supported for Intel 1G/10G NICs, it
> would be desirable to have the support for the devlink dev flash interface
> in in-kernel drivers (igb & ixgbe).
> 

Yes it would be great. I've tried explaining why the existing support
can't go upstream, and why this would be valuable. Unfortunately it
hasn't led to action internally. I'm also not sure if all of the flash
update logic is in anything released under public open source license,
which makes it challenging for someone outside in the community to work
on this.

> Thanks
> Richard
>