Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp535723lqp; Tue, 11 Jun 2024 11:28:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWgWZWrUIHsZzAl14ZgMYBNR8PdXJoYtsosjI1kRKqsw09x685smAdx6LECqvTM7htZx+3MsfWczHFHZQo+/101jOfGXfVb4Zg/ui3bLw== X-Google-Smtp-Source: AGHT+IGYuPHxyyZTyXLwRCz0V+Kw/kWOGj7C5cUNQ8g8KIBhM4i3EOX3ipCBTF0MlNguJ+NgjVbP X-Received: by 2002:a50:ab0d:0:b0:572:4fc3:3a28 with SMTP id 4fb4d7f45d1cf-57c5092fbbfmr7707897a12.23.1718130512548; Tue, 11 Jun 2024 11:28:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718130512; cv=pass; d=google.com; s=arc-20160816; b=b1PBKPuRi6muNdZLcmTjZfRF30QdZ+myYWCvSn3YLQapz1Ef4e9ku9laSRiyswIi5S mR1Xo+Ol85WEu51MqywH9CmT4YKgoHKQjJh2I0dzFbVQ74Gw3NLXqgRPhyR26Z+q1BUe IjE7DFBozoMP4TXAtWDYO2YiKJ3mgGUt7uSwUSzpUYYJOaICtd4UfidwOqCZ/H9ucMiU HMEXZTiNXOFLjhg0FPUBZg8yRsw4v/Fcxd1K9TdLu6eO7ZsMBTO2H+xcoS5RzvNxif8n 11DuobKl39e+nZyGmzbxmGQ/PO4XihwqOSpIpLJl27xMzAFvjM5KwrmXb5ZWR/dPnzCX Ec+A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=RE0BX38O2e4iKPwls2XO8azcBN6m/R+kr5AEuufuGYo=; fh=B/aLX7ce36KSn1x2oGaDI8cdVcpS68+53T9e4kScr8o=; b=pvKPyjIYkb2dsOyGgTzE0BkMCHZbBuioflDY/PBkG6Kwb2np1P7lesm9WAU0rEcq+v dqkiDOTffcoo1/KOkMD8d5WdCKfJqqGq/FCo8hxwgVGiYVCfe3/ELQZJPR32OLz1j5RO eh821DbvC+q4rsqYnNEG8s6rbkmtM3NdWce5CgShUykIQHXP87BCk9F2Wq8WYMrtx2ab 7joKaxrQ8gtQ/WHvBSdCrlHoXUg3xgE3xtxDicRgRdlvjt7d3Wvq/rsV9I1uEs14GNeb MRvZfIMJnsApq2N/Sd3eC9Ml5OTkwB342r/lVo2DpfxR6NlzvJdkbd3glxG57m1eJEE9 IyFQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qiSLN0yi; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-210423-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210423-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57c764c2570si3213732a12.516.2024.06.11.11.28.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 11:28:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-210423-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qiSLN0yi; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-210423-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210423-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id EE4E21F25FB5 for ; Tue, 11 Jun 2024 18:28:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C67FD7E112; Tue, 11 Jun 2024 18:27:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qiSLN0yi" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFC7C7CF34; Tue, 11 Jun 2024 18:27:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718130473; cv=none; b=K28EhsuDIUTWNjHMrUveZS5lPdoDbop14YAeuzYl9J8Rg5zxUOwbvvvD3fw5UcdadlkSDIObRF7jPpSl9TptjOjQFeDLSRz+uf7QCqi7TKAN2W0nfttlHL4Dqi38AOpfBolXG+kMqhK31BPeNavEO2MwOowzpxSpGT//gYWrab8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718130473; c=relaxed/simple; bh=fHhEfvWwtK4Eff3/jfxyCWlEtDu1mJZZ8Zh4eSjSY4I=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=ul49M/kgVRRV9sowdXpxA4Q0O4CshMcnXL1LzITmlsnhm/lLD4o43IaLU2YTd4cAqGiBTIT3T/cbCm726nCBlHJYaoynhd1AekR6gtyugnzokH79tdyvnSaKg5PHCNedgs3KeMyPd4vOpWwIR50n6syZ3oRTPpXYbi6T/q6O66Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qiSLN0yi; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 354CBC2BD10; Tue, 11 Jun 2024 18:27:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718130472; bh=fHhEfvWwtK4Eff3/jfxyCWlEtDu1mJZZ8Zh4eSjSY4I=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=qiSLN0yig0Kk9SOV1JSy2LZr0Qb1ltbpkrqFVZ9uobGkmDTylZAKyqghKRKMPjuL6 yQ5SnDS75wQWZ+Ds14pAoo8/1JNOM452z4DTdcmZEwz6+UcAfUFJEBFzXezzGyx4Qs cWaGTYVYEiNTsnrVtL067+nCFa+Q2+ijfD5ZdkIcgntIMFEyFjbj38jDyZDeozL7ly Pfb9rO19MYu5cA56esMVymwGZa3tUzkaYYdDtjH5VR81fz+Neo+uZG8Qj/f7x1kedZ 1s7F/ONtHbQ8496IeuZn5jHI8AKZMAe/AsxLJkt8eZ1YEcpdzNrB6ZZ5QpiJl4mIoa Da3sReZ3DKI+w== From: Vinod Koul To: Dave Jiang , Logan Gunthorpe , Nikita Shubin Cc: Andy Shevchenko , Nikita Shubin , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux@yadro.com In-Reply-To: <20240528-ioatdma-fixes-v2-0-a9f2fbe26ab1@yadro.com> References: <20240528-ioatdma-fixes-v2-0-a9f2fbe26ab1@yadro.com> Subject: Re: [PATCH v2 0/3] dmaengine: ioatdma: Fix mem leakage series Message-Id: <171813046978.475489.11233301770503633665.b4-ty@kernel.org> Date: Tue, 11 Jun 2024 23:57:49 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13.0 On Tue, 28 May 2024 09:09:22 +0300, Nikita Shubin wrote: > Started with observing leakage in patch 3, investigating revealed much > more problems in probing error path. > > Andy you are always welcome to review if you have a spare time. > > Thank you Andy and Markus for your comments. > > [...] Applied, thanks! [1/3] dmaengine: ioatdma: Fix leaking on version mismatch commit: 1b11b4ef6bd68591dcaf8423c7d05e794e6aec6f [2/3] dmaengine: ioatdma: Fix error path in ioat3_dma_probe() commit: f0dc9fda2e0ee9e01496c2f5aca3a831131fad79 [3/3] dmaengine: ioatdma: Fix kmemleak in ioat_pci_probe() commit: 29b7cd255f3628e0d65be33a939d8b5bba10aa62 Best regards, -- Vinod Koul