Received-SPF: pass (google.com: domain of linux-kernel+bounces-210427-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Martin Oliveira <martin.oliveira@eideticom.com>
To: linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
	Leon Romanovsky <leon@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Tejun Heo <tj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Logan Gunthorpe <logang@deltatee.com>,
	Martin Oliveira <martin.oliveira@eideticom.com>,
	Mike Marciniszyn <mike.marciniszyn@intel.com>,
	Shiraz Saleem <shiraz.saleem@intel.com>,
	Michael Guralnik <michaelgur@nvidia.com>,
	Artemy Kovalyov <artemyko@nvidia.com>
Subject: [PATCH v2 2/4] mm/gup: handle ZONE_DEVICE pages in folio_fast_pin_allowed()
Date: Tue, 11 Jun 2024 12:27:30 -0600
Message-ID: <20240611182732.360317-3-martin.oliveira@eideticom.com>
In-Reply-To: <20240611182732.360317-1-martin.oliveira@eideticom.com>
References: <20240611182732.360317-1-martin.oliveira@eideticom.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?snBOHwcygg3ghtGStEnwZeut5s/ucWDTffUeYOj0/XiePGJcChY+GeAguWri?=
 =?us-ascii?Q?PHjMft0sYKlz0fngc2dvxIlKny8GXIS7shkH37g5jynub55pM3o9byVgYui/?=
 =?us-ascii?Q?kEqn1egQi4x0TJRJh8hV73MZa9Qs/kt/jlq2PBuIQrgVJ+gTGg9jdQffXGU4?=
 =?us-ascii?Q?qoN54mmFAwNIuIXtNFUhqd1wxmjgTui2lNbesL+h0TzT4/lmRd6Np0Z5hzhJ?=
 =?us-ascii?Q?14aqyx4VWR8QUqfe98dNA3MUrmerr/+5mBve/0Q3i3P658tiDlDA3/29+fGr?=
 =?us-ascii?Q?obSlxMdygWbinmj6kX85AB3JnM2xh40vnji3Rco8vNVCjpyrv+EMGuZBB81n?=
 =?us-ascii?Q?nlLgf+HeUpunT9xcCha0pmKcz1ZjSPvgNCjkNGlT1qzhrvgfSr3n4+ieR7RM?=
 =?us-ascii?Q?W7IaiRh0QBbnusVWXjR9MIdGSF5NMTLVYt39hNvoqoBdwhPhiWzo9a61YXzQ?=
 =?us-ascii?Q?5eWZmbLVLnPQnYWrJQ9lpk2EWEnCaPPcF5Oepo2NeKzffdYkkL7dMQmPo5Ce?=
 =?us-ascii?Q?Jsc0+gOl6zI8uVXAB472ILvbTrgAH0XRQrewhPK8MT+MLXOjIQ5voKjM0s4Z?=
 =?us-ascii?Q?9rGd9EUwLiq5bDzZ/jNSuyZgyV88OBTDVXHYWSGVy9Q3mh8dB/cklzcLdGIL?=
 =?us-ascii?Q?5zcju4lqOGeRcVPzNEOGHM11eORFqk+UZTXDYE5pvJ8Jc8BvERb8mC4rPc3x?=
 =?us-ascii?Q?DKNX2Qor995DT5Z49tTsVSAZC59o9NLvUhNVmc4iB6rsdO2a1Fw3oHaNEJtH?=
 =?us-ascii?Q?uo9zg6j8QWq1rdvzEOYBxMoVZZ3+kGkUxjkOKWx59b6diWbYai4ZTGMi8EEg?=
 =?us-ascii?Q?zEaRTmsaQB25xuZY3iYY3fz5NfLYLnWpIGt7UBHnSoY+SF3AHj6M0qxiWa0M?=
 =?us-ascii?Q?s0FPSoW0Im4XrTSIsd4DEKKpEYiBz0xqhgPhjaD7Xj/4zXCAOKNKnwXYSxr5?=
 =?us-ascii?Q?p7AnTHcWxoGveMM/UxBYAPpNggzltZ9fPy3ZqR0C3cxBAJ1HPCB7UyHGbtTs?=
 =?us-ascii?Q?2vw6u74UdnlUlews/zBn0sgUGmyzfWsNN/gp8tw94K+k30HRh4oBpF//PvqT?=
 =?us-ascii?Q?n3G+cGvqqPWpLss10kPX0o5n5B3gJsJroflb/wY5D5Qt5AtRy1uC/68ky0Rh?=
 =?us-ascii?Q?LIXLNTgyZslG16S8+NMWFGSYfocQXROg55aeW7COoIAsXUbqE4j2IUxvloB6?=
 =?us-ascii?Q?1fPJeLHw/p56f8dqEL60VJtkXWTsI3hGa3OjKm6aJ/6T9UeGJWG/US2NbqrC?=
 =?us-ascii?Q?mMjq1H+F8DMRnMnLJltL6dLwfaBzKTSxdCr/b+u9jWCUFUY3Zuy8N1TNz0Vm?=
 =?us-ascii?Q?NVA5CQf0y0czx7tn1LpakoCDymTDD5OQVly98pWv5qJE5XqUq4a625WTCEhx?=
 =?us-ascii?Q?pIjzDJk/rCkwBbFl+btVpEv3XYfior1mqa0RZROMKHyNUAqh+oVhfyRQp9dW?=
 =?us-ascii?Q?L85b5gDkK/Jwenc8cqQ+Gfm/kSs7wmD9EXtDNqgIWBN/kYliRsvJAK24+4hb?=
 =?us-ascii?Q?pF6k3GQcHSzBGBsGVcnuLwEO5Oq4YnY5sGjAStYMqTNsyWCB+yBlkSSgEGQy?=
 =?us-ascii?Q?GM1FaJv/A/Dh7SFIi3T8lZ9SYauFQT3LFv/ITGrsqqG6H8kj2K6I1j+1lpOG?=
 =?us-ascii?Q?zripXR9+tIRr03db0QQHSIM=3D?=
X-OriginatorOrg: eideticom.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78715319-eaaf-458b-c874-08dc8a44392e
X-MS-Exchange-CrossTenant-AuthSource: MW3PR19MB4250.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 18:28:00.2550
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3490cd4b-0360-4377-abb1-15f8c5af8fc2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 28F4sPdzuvBC2Gu7EfwX1vd1OefLwuatUANqLPCkgcNSXLk/1YNGYZcFKH3LbMYIFwF0Skd7GwqtwXn8w/S5WdIvm6Hl160g+3/tnL8/PuQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR19MB6105

folio_fast_pin_allowed() does not support ZONE_DEVICE pages because
currently it is impossible for that type of page to be used with
FOLL_LONGTERM. When this changes in a subsequent patch, this path will
attempt to read the mapping of a ZONE_DEVICE page which is not valid.

Instead, allow ZONE_DEVICE pages explicitly seeing they shouldn't pose
any problem with the fast path.

Co-developed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Martin Oliveira <martin.oliveira@eideticom.com>
---
 mm/gup.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/mm/gup.c b/mm/gup.c
index ca0f5cedce9b2..00d0a77112f4f 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -2847,6 +2847,10 @@ static bool gup_fast_folio_allowed(struct folio *folio, unsigned int flags)
 	if (folio_test_hugetlb(folio))
 		return true;
 
+	/* It makes no sense to access the mapping of ZONE_DEVICE pages */
+	if (folio_is_zone_device(folio))
+		return true;
+
 	/*
 	 * GUP-fast disables IRQs. When IRQS are disabled, RCU grace periods
 	 * cannot proceed, which means no actions performed under RCU can
-- 
2.43.0