Received-SPF: pass (google.com: domain of linux-kernel+bounces-210429-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Martin Oliveira <martin.oliveira@eideticom.com>
To: linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
	Leon Romanovsky <leon@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Tejun Heo <tj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Logan Gunthorpe <logang@deltatee.com>,
	Martin Oliveira <martin.oliveira@eideticom.com>,
	Mike Marciniszyn <mike.marciniszyn@intel.com>,
	Shiraz Saleem <shiraz.saleem@intel.com>,
	Michael Guralnik <michaelgur@nvidia.com>,
	Artemy Kovalyov <artemyko@nvidia.com>
Subject: [PATCH v2 1/4] kernfs: remove page_mkwrite() from vm_operations_struct
Date: Tue, 11 Jun 2024 12:27:29 -0600
Message-ID: <20240611182732.360317-2-martin.oliveira@eideticom.com>
In-Reply-To: <20240611182732.360317-1-martin.oliveira@eideticom.com>
References: <20240611182732.360317-1-martin.oliveira@eideticom.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?kxDb86xEIu6gBK+xTW9UQeEoACkzP+L5RU2ItoycO5rkrLoaHfJ/cFLdu2Pj?=
 =?us-ascii?Q?icQz05WM/T89bY2LA2xRxqOW3UpqLSQsAiQGyAd42IOBw1laCCDQW4ciLTLk?=
 =?us-ascii?Q?7qTbkjcVhIYVez9Fxcz99hE5WOlRVAtuJzA5sTjVVw+fPohjDdjMfAYu4X1D?=
 =?us-ascii?Q?RTN3QEpDIPgDl5IqvfueTccOvUusGWpOswrjAvjmM4Ot2RfCXKav6NzAFYxv?=
 =?us-ascii?Q?pYxmxCoyEBDWphH2zoF9kSLDGI3kfrnyq5bpxFWi1zouI0TE0cDqT/y5jrFb?=
 =?us-ascii?Q?Q3XH6+8zBoyQnSrRsH4v5XU+JA/aAlqUPY8dmJwqmfQuO4MVRcSt4aXwRVfu?=
 =?us-ascii?Q?0gKLrtBwDjUaFgbCN2/C/NvQUwwSosWB1sFuDYfjZwgOiGRaospBOF2zLV+2?=
 =?us-ascii?Q?Udzz4zp+KieGjKjwUj0/+S2uoQMUQJbsueMP7hYojdR6asS2hYaaB6EQppRD?=
 =?us-ascii?Q?HmHlm9cmQy0LzmAWkjKeCL66ndJT2u6RCwu521COrQobbYZp0wHlb3dzc5Do?=
 =?us-ascii?Q?MUo1K1HSz4WRdvdLXWra7J0rSLiI7VbM/y/k4Opf+47oGzLYD+2Db+eNeTKv?=
 =?us-ascii?Q?d0vF4De5RZPzRI39PRpmusIvqgrFSxI6BMf3vZALpIOeXWrsEz2yfCFlp3Dt?=
 =?us-ascii?Q?HvGQfH06dUrkV8HyvZnYfrwYNQlNhEKBi1BwbI+/rhXKULwddzCqyzFcm4bx?=
 =?us-ascii?Q?j5lktifhKzGK5RtXXFEPjG820E3Dv4Cxj3w/ldsWP6ACVbhu8pjI3N4LQ6Xl?=
 =?us-ascii?Q?EoMPA+4VcdBlcmOyt3K0w8Uu4ZmeP+zWKfGQGNoAOgrGwysnglbdiM0j71y3?=
 =?us-ascii?Q?u7FPe1rAJO35s0uOO+P97RGSCx1nNPn9/SIYNLKsMH2QOt1yVmfOkhY1fP8C?=
 =?us-ascii?Q?vA0XSRlkzzGoUC7Fhqt4/3g+/ec+mmWHicCXBx/KFKLTLliNQzE3tNDlLwhn?=
 =?us-ascii?Q?93p/mcffGoHrKrA9/J3+JXwiIuCKfWrD64ceBSbrIrM6fhstQatIDZJD9jL3?=
 =?us-ascii?Q?2HqV7lFGaQolxTN8QPEnAOk6eiC3x5kpkVFuX0grY9rEGtjmePSRlvVueSOV?=
 =?us-ascii?Q?4rs4h6YJkcHi2eq6o59yEdPp3BqOyoNCxD7JT0XqUgv+esO/xs+xkL4jZRX+?=
 =?us-ascii?Q?uVrHS6B9w70/pyOeP2CsXJHrW1J0qy28/tHmsZEDegE8gFGVgzKHpne0uWch?=
 =?us-ascii?Q?i7dl3Ssjkj5A556/enKcGIhZuOEQen/qZR+dppwpYDpJh5gDZ/TvnemYS6FX?=
 =?us-ascii?Q?Hnh9QJL6QUIByka59POHkJOS1/vkUiYiouH8rn/pUDzt1KpdD2pWOVQXMGEr?=
 =?us-ascii?Q?YLKGNfrOevFgCMCSx98Dfi8JaaNpxDv9euNIvJj37+8K7N6IIhQOhTXERdMc?=
 =?us-ascii?Q?To+MA6v9ut2AWRZSmZP8Iewjn9oP734mBwaa5DCZbG59G4FdOpoC/dRODA14?=
 =?us-ascii?Q?vrEI4o2VV/QsDvSTVlPIES+0sIV9U6KdMstpVBLWJGsxT+L8b0n92+CU6pxg?=
 =?us-ascii?Q?DE1gSaS71t7P56q5//JTIEVDUM/IRCmkM4DZVzkWpzgLrhlkDvxJe1VldeNS?=
 =?us-ascii?Q?R65DZPebILySktodKBI5WTDezb5b1VleFwfAogwNyTBHczQTt08WrqYumOi7?=
 =?us-ascii?Q?76YSqWX6+rctC42gpRw95gs=3D?=
X-OriginatorOrg: eideticom.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 81a4b7ca-b8aa-44c5-03a7-08dc8a4438d5
X-MS-Exchange-CrossTenant-AuthSource: MW3PR19MB4250.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 18:27:59.6764
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3490cd4b-0360-4377-abb1-15f8c5af8fc2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EnirLeYvlppbgpUVSXko/D+lRAutQq/Zf8NzJpbZTnDh4YryJzpTnYiR2icHv0LL3PvEftfMb4bt43wJUrXcu/fIvfDHXohJtP40drGiHXc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR19MB6105

The .page_mkwrite operator of kernfs just calls file_update_time().
This is the same behaviour that the fault code does if .page_mkwrite is
not set.

Furthermore, having the page_mkwrite() operator causes
writable_file_mapping_allowed() to fail due to
vma_needs_dirty_tracking() on the gup flow, which is a pre-requisite for
enabling P2PDMA over RDMA.

There are no users of .page_mkwrite and no known valid use cases, so
just remove the .page_mkwrite from kernfs_ops and return -EINVAL if an
mmap() implementation sets .page_mkwrite.

Co-developed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Martin Oliveira <martin.oliveira@eideticom.com>
---
 fs/kernfs/file.c | 26 +++-----------------------
 1 file changed, 3 insertions(+), 23 deletions(-)

diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c
index 8502ef68459b9..a198cb0718772 100644
--- a/fs/kernfs/file.c
+++ b/fs/kernfs/file.c
@@ -386,28 +386,6 @@ static vm_fault_t kernfs_vma_fault(struct vm_fault *vmf)
 	return ret;
 }
 
-static vm_fault_t kernfs_vma_page_mkwrite(struct vm_fault *vmf)
-{
-	struct file *file = vmf->vma->vm_file;
-	struct kernfs_open_file *of = kernfs_of(file);
-	vm_fault_t ret;
-
-	if (!of->vm_ops)
-		return VM_FAULT_SIGBUS;
-
-	if (!kernfs_get_active(of->kn))
-		return VM_FAULT_SIGBUS;
-
-	ret = 0;
-	if (of->vm_ops->page_mkwrite)
-		ret = of->vm_ops->page_mkwrite(vmf);
-	else
-		file_update_time(file);
-
-	kernfs_put_active(of->kn);
-	return ret;
-}
-
 static int kernfs_vma_access(struct vm_area_struct *vma, unsigned long addr,
 			     void *buf, int len, int write)
 {
@@ -432,7 +410,6 @@ static int kernfs_vma_access(struct vm_area_struct *vma, unsigned long addr,
 static const struct vm_operations_struct kernfs_vm_ops = {
 	.open		= kernfs_vma_open,
 	.fault		= kernfs_vma_fault,
-	.page_mkwrite	= kernfs_vma_page_mkwrite,
 	.access		= kernfs_vma_access,
 };
 
@@ -482,6 +459,9 @@ static int kernfs_fop_mmap(struct file *file, struct vm_area_struct *vma)
 	if (vma->vm_ops && vma->vm_ops->close)
 		goto out_put;
 
+	if (vma->vm_ops->page_mkwrite)
+		goto out_put;
+
 	rc = 0;
 	if (!of->mmapped) {
 		of->mmapped = true;
-- 
2.43.0