Received-SPF: pass (google.com: domain of linux-kernel+bounces-210430-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Martin Oliveira <martin.oliveira@eideticom.com>
To: linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
	Leon Romanovsky <leon@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Tejun Heo <tj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Logan Gunthorpe <logang@deltatee.com>,
	Martin Oliveira <martin.oliveira@eideticom.com>,
	Mike Marciniszyn <mike.marciniszyn@intel.com>,
	Shiraz Saleem <shiraz.saleem@intel.com>,
	Michael Guralnik <michaelgur@nvidia.com>,
	Artemy Kovalyov <artemyko@nvidia.com>
Subject: [PATCH v2 3/4] mm/gup: allow FOLL_LONGTERM & FOLL_PCI_P2PDMA
Date: Tue, 11 Jun 2024 12:27:31 -0600
Message-ID: <20240611182732.360317-4-martin.oliveira@eideticom.com>
In-Reply-To: <20240611182732.360317-1-martin.oliveira@eideticom.com>
References: <20240611182732.360317-1-martin.oliveira@eideticom.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?e7pxCw0br0O09d/cMsORV34IFbPwK6UAPoCGnmdDD2mtZ2c8X0pAhRytykLY?=
 =?us-ascii?Q?XYDZModGkc5U+9gL/H6+E3eb9VVLJfFUd1lxCLi4PVu45vJAUb2mksRNu61T?=
 =?us-ascii?Q?atyW/77ImJWNiqEgCEbAElF14Vihyvc/Z7h0g5MEjx1zxzJvI9fb5n6ilTim?=
 =?us-ascii?Q?V6R+jLceaG/74SP5ShKE5p5VVc6KqMIdt75rKFdTn1zF9sWWgt5eyAFF19QO?=
 =?us-ascii?Q?vKPYKfwLvJuCkj5S0T7tXvbl7f+o2cmNThoDy3+LzZolMQpnfN40H7RKWqGx?=
 =?us-ascii?Q?W62+u6Qj8MG5HV8wM7+wd8VKtpknvilZKr3qGh6QZX/1kagIYudm74Tw8qct?=
 =?us-ascii?Q?L1DD+kql0cY3eIEYNi45pq4eF/NzDonGwchOTAwjgRR56GpN/Y8wgXP70G4U?=
 =?us-ascii?Q?CMQrCp2AMEssY4q2UTJ7tdZcvhfZrf+TASQkWVCZutOzv+knlaJYLCdN9VcB?=
 =?us-ascii?Q?7wk/L63CCVgYmNcBKJqCj3W73xu9DDn5aZ59IGfq/Rke7lDhRX0aDksiZyfl?=
 =?us-ascii?Q?Ar2LMjOquiblqBwZBsWLRCwoETrjZ9vA2zU5g0swcqp87zn+iFhP8MVT2Hd1?=
 =?us-ascii?Q?BhXrwGfZG5YvJ4B/2wFlZSqaimwP/NAq+sE6xECUoq8T2eeQCVo2P1Fa/HRU?=
 =?us-ascii?Q?Q79dW7JdeWDnefl1MWGjHViYMaG2JvJKjeO+t1bLZYuqwxLrtJ1P537Dya0/?=
 =?us-ascii?Q?PBsTaccEQBy/PDc3ek51dyhh4qr39vH2GUXO4qY9rDy1cr6vfgoYB2SQCOa8?=
 =?us-ascii?Q?ek04rK/BsGZ0AmtG7X1p5llE0SrPNp3/PesxVEDEzmhtVHvbuftdMvOZxBnA?=
 =?us-ascii?Q?A1uR5qCOwGKhT0iu5iifZOdQmWGIyD2Oob9szxhgC4pjt7lIeTS+1zENAs/9?=
 =?us-ascii?Q?FqqvQ+IKiLZuLWYNLW8VUD/5en7Bjb6CTTotG6QSAUHWujTlTZ/DuzWdgszz?=
 =?us-ascii?Q?hjyvYlQE7FkX41OEQQYqtW02BGYcLq5JBPCwFtUwPmQktzBp4HrUYuEP486a?=
 =?us-ascii?Q?yqtKIMhAZ65LCcAWPmLbGe9qmmrUuKHm4qFWfSdTYlFnxYiJGD8xYgdeWF0j?=
 =?us-ascii?Q?5u+3lTya3tECX3tOJYrDp8qlm5pSmAy3I5YWAYLeup6sWS8MPN5gW+z2nmSf?=
 =?us-ascii?Q?zZ8VOsLjkyhZF5O9tayvXL7ABDEbeT7lmIsdsvBgbon+hzSd3AmrfIaTygBG?=
 =?us-ascii?Q?VJMhabdIThczd2cQQV+PLTCIWZ22VmXmMd8T0mfk1Cu1UsC77lqDNfysUY/I?=
 =?us-ascii?Q?Pv8gRxxzYkXCyxBtaXyleNhuApizpedhVPae7hgNupLJ+XCRJ+U6RKKD46Bo?=
 =?us-ascii?Q?mayZXnbfxzwclHQeN4L+hPD80rCCDIY2r3ZbqjvwlPXQtIwdPp0sQy1yxAuw?=
 =?us-ascii?Q?sZkjvpPBwzt7biDGoWzY1+ZHmPI+1iL6y2C3jcBoRpOrDgnZdEwKfrs76lBC?=
 =?us-ascii?Q?guQRgRYY8rnGzmsnD5Q5VF0ASs3hJkhpJiyA+DVYD74QBALXiwT6SXrXufJQ?=
 =?us-ascii?Q?4EUL7TnEgq39d8poqYztVZw+ecKthodOr6ygUUqg/t74w9sb0J5IINCS+1BY?=
 =?us-ascii?Q?b56E2/w18NCtB8zh3OBu960t2kZHCdTcOgPljAiC33kJlDAfaIbe87MRnPRO?=
 =?us-ascii?Q?6Vcucf6CgnZQath6KxJY/7M=3D?=
X-OriginatorOrg: eideticom.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b11f0199-e03d-49db-795c-08dc8a443989
X-MS-Exchange-CrossTenant-AuthSource: MW3PR19MB4250.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 18:28:00.8665
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3490cd4b-0360-4377-abb1-15f8c5af8fc2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v7F/UZ/nD4KIBmuJSzxA0TBQ4H8LNiL1N9KMB+uORylsg68kMyuG2DlTJPvBZwHJNtE5QOWaAWxuUa7eLvi4rUQBjqEWyvAp/93gKRYZZ7M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR19MB6105

This check existed originally due to concerns that P2PDMA needed to copy
fsdax until pgmap refcounts were fixed (see [1]).

The P2PDMA infrastructure will only call unmap_mapping_range() when the
underlying device is unbound, and immediately after unmapping it waits
for the reference of all ZONE_DEVICE pages to be released before
continuing. This does not allow for a page to be reused and no user
access fault is therefore possible. It does not have the same problem as
fsdax.

The one minor concern with FOLL_LONGTERM pins is they will block device
unbind until userspace releases them all.

Co-developed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Martin Oliveira <martin.oliveira@eideticom.com>

[1]: https://lkml.kernel.org/r/Yy4Ot5MoOhsgYLTQ@ziepe.ca
---
 mm/gup.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/mm/gup.c b/mm/gup.c
index 00d0a77112f4f..28060e41788d0 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -2614,11 +2614,6 @@ static bool is_valid_gup_args(struct page **pages, int *locked,
 	if (WARN_ON_ONCE((gup_flags & (FOLL_GET | FOLL_PIN)) && !pages))
 		return false;
 
-	/* We want to allow the pgmap to be hot-unplugged at all times */
-	if (WARN_ON_ONCE((gup_flags & FOLL_LONGTERM) &&
-			 (gup_flags & FOLL_PCI_P2PDMA)))
-		return false;
-
 	*gup_flags_p = gup_flags;
 	return true;
 }
-- 
2.43.0