Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp537039lqp; Tue, 11 Jun 2024 11:31:04 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU4XIBpmOuRZRWDBFF2Gz2fvcbV2kNEolVzzF4aksF8zaRB7bLs2zNbDqsS9NUKxSVqcnqjSo5lAloS/nKAGOUV29mds+hwolZOdUpfBg== X-Google-Smtp-Source: AGHT+IESZE4YOzKZ2SfG1LmYQ6YeUchWJtoIpyYznd/LlDRvdlj8/qkc/6BOReL+bfAmuLWpmo5X X-Received: by 2002:a17:906:7ac6:b0:a5c:d67a:e8ef with SMTP id a640c23a62f3a-a6cd665b5f2mr748758166b.31.1718130664133; Tue, 11 Jun 2024 11:31:04 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718130664; cv=pass; d=google.com; s=arc-20160816; b=ht4rjReRvU2/GNEqS25YR0r87fDkJiWrkDsIrl2GIfNw6OuLiLDR/RMuk+3qE+O3l8 /H/nET8e32C7iSngVHjSFPwyZPnrNsS+BJ1vbbIU5CmuG+07ovhiMMkPaJxETijextqa vTCemZP62OHUJMsjnqliNpbznGOPsOQ9eLVahuSlel7Alr4hYWtu6Syvg7L8ZfUxSR9B /vCU775W6SzBw31HuXVka78GidO7XyfzN7zcQXTfHTbC0NYpF3pmIVKWD+g9VjX4/hAZ Z52HitGVaR5BBvT97f41QcbjaWzMzt4hwQyHHEAhjwK4Dh58qGoQEU4TGjN7TSJHi8X4 zq7g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=NqkNzVZsvOqgNGmN5Rtjl382EBPw4xctECBekxYTogU=; fh=kmYbAAWA0tdNetJllqdM+lpuN3XmWObH54BkBBplhio=; b=w4e+K0/+pPKih/NNUNpq1l7DwnbrJ5Q3keIjzFDwwxF2Vwq03qYZ1CnJOyVPA0g/QE AAdI1HufRH9jXregWxHozvUUnjktjmIx6MQ+Nqh53Ca3WBduRr02A7dP2HV4vzlAxZtD jJR/rkcgwDRwFeg8pdlvybWgQdEGfm7AT2x2W/mES26d/hJ4nVUVIbbJKJh+fgy+MCS0 wK1XQq3AKpHMmuLXb9fewEXql4MeKx+qrkBI3XO5AFgOVOK7TrMKBDfWvlhYjxjzw0jq Na4mf1Id5nkzUHyqIlQJ2ttk1KoHoEWBPbHKjYEfB6mImyUBwZ+Ue9MK91mWqig2C8ke jp7w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QRrCui99; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-210433-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210433-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a6c805874f6si590404366b.138.2024.06.11.11.31.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 11:31:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-210433-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QRrCui99; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-210433-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210433-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D6CB21F24D0C for ; Tue, 11 Jun 2024 18:31:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 551BB15531E; Tue, 11 Jun 2024 18:28:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QRrCui99" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B5D61552F5; Tue, 11 Jun 2024 18:28:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718130495; cv=none; b=tC0fcHOFuFUhe134Ar7jo+MMV83gYHGUUOzLqKZa4bRNlo63Y+jbEUDbpBDmJFCEe+r5WamxH9SZ8zZ8TzAtkvnvjA0j7top+YR+EpyJpoHVJnKrFWiGmZmhQsskOU96P44V6xP/4WNn40axiazWOUNN1Buz/KpAKPdDV3wHm90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718130495; c=relaxed/simple; bh=8D3OQHswbC2P361Pk4nAjaQ8dTehgzedq3gMFTInLtc=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=cE+igpbn5jp43T7bFVz0bOcLXSRLMuM62kI9zUUM04zkuXJWOK/kjUSX7rOlMtTEOQsUR9JrWJ6CPp/eNRq0INWQ9fHJXwPLIVJw874azOLzCQdIctZq/wLKCmvUYLr4swvMJHGvYeFJpvUJ3+uj7OUDqvvQxpFwbrI2u13SxXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QRrCui99; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7EE4C4AF1C; Tue, 11 Jun 2024 18:28:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718130495; bh=8D3OQHswbC2P361Pk4nAjaQ8dTehgzedq3gMFTInLtc=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=QRrCui992V9IfdotZKly/zbhK6eD25lwtUDek98rtgLGr6C7q2VaeEx6JygXMohDS 7S622XaPYVzjgwUQuVnxHbsb5BPIZKKiP+ympjpTo6Ju+BjrZ6MEhOP0seWSa/ldWx 7A5r5dRBSCmxBa0ftYEHWhayd0RSU+V/KI0ByjeVL9Rs67i+rXWM9+ECU/GywtX7Ts /6GpLQNa4ck+zjpvj1vULY55QFhVEOLs9Y0LYTxDHDGUSDjRTCuC7RiMK4lHQ3h5NU w0hqXaSJccrn88AxxjfJ/IXW9rCzhgjUBWZNfOOSReI5SWomtzwFpoT3MrMrgSzOrd 3vgffo+LR/6Fw== From: Vinod Koul To: Stefan Roese , Olivier Dautricourt Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Eric Schwarz In-Reply-To: <20240608213216.25087-1-olivierdautricourt@gmail.com> References: <20240608213216.25087-1-olivierdautricourt@gmail.com> Subject: Re: [PATCH v2 1/3] dmaengine: altera-msgdma: use irq variant of spin_lock/unlock while invoking callbacks Message-Id: <171813049334.475662.18180872896770044456.b4-ty@kernel.org> Date: Tue, 11 Jun 2024 23:58:13 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13.0 On Sat, 08 Jun 2024 23:31:46 +0200, Olivier Dautricourt wrote: > As we first take the lock with spin_lock_irqsave in msgdma_tasklet, Lockdep > might complain about this. Inspired by commit 9558cf4ad07e > ("dmaengine: zynqmp_dma: fix lockdep warning in tasklet") > > Applied, thanks! [1/3] dmaengine: altera-msgdma: use irq variant of spin_lock/unlock while invoking callbacks commit: 261d3a85d959841821ca0d69f9d7b0d4087661c4 [2/3] dmaengine: altera-msgdma: cleanup after completing all descriptors commit: d3ddfab0969b19a7dee3753010bb3ea94a0cccd1 [3/3] dmaengine: altera-msgdma: properly free descriptor in msgdma_free_descriptor commit: 54e4ada1a4206f878e345ae01cf37347d803d1b1 Best regards, -- Vinod Koul