Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp543612lqp; Tue, 11 Jun 2024 11:44:23 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWzg7fL4LziKdITQauErGa0s/gXyFvFTCGotEpibeJJ5gX0bq8eVzrbnZtAJRlkmgUr8MBPFWLizNQDmvGbkgsC4mMGyNQ9J+dIn3mzDA== X-Google-Smtp-Source: AGHT+IHCc8hDsqW4jHzDZ15iuLCTJC0j0RyTvawwHsBmw0si2IhwWmUTI5uxJ4Ej8quE6+xEdtpl X-Received: by 2002:a05:6a20:431b:b0:1b7:406c:107d with SMTP id adf61e73a8af0-1b85ac05f7emr4627731637.27.1718131462830; Tue, 11 Jun 2024 11:44:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718131462; cv=pass; d=google.com; s=arc-20160816; b=G70ST7UZShUdV2JB8E/H3lY7mP34do/szY6/aM2U8LY0jHFf72a+5QSMmMmRTX0Xq4 +Rca9+vy/o0CLmZTyScxGBp2tjRzozVYW2oO9T+6k9iBL9PGmM+hH+BuD+/puMv7KwGp w3x1aSlTmn5hf/U3EgsG5sn5mEzauRDXc9T668NQZwdnAKkDjpN9GbLtKdSedYQtXyOb rYVV/yOxBlA08lLzh1XRIeop/ygxx2j79E+rIPDwQ+3OhlFLr5EeFnCOTATAbx+5Qcdc BGsLJk8U2CMNlJ9n3+u+Le1guQ2MIsWNpm6lJpSTI0MF3Hm2Y9Fh4UtRQg0wvhn5VqNx BSiA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=8UxkyDNRv4iTaSeg51ZurPpcmITJlSpeJYuxhXeEekg=; fh=+++tLUQjTq/1IhZxoq6WM4Sipq0tfuOo9/hZyoVEeJg=; b=pBKNV3dYpuz7tEsi1ZmUom2fwj5coipMIbCiD2CJdBUGryJE16KdrYBWWtGsv8Dcc/ a7wgTs/ZOGgNgKXJTwCNarQW+i5U7H+bx4JSOEtPn7MlMJpL9mQIZyg4NfHsN9ieOOov fVA92RQMH7k3rcIcT3ERos7O+jIxWOJiPTmqjJAYzUd1CCxuAXXo9wN2Hu77E9wBchhD XFXhiE1FwvJT9AyKriLSlpEDiTw553QBhx6LTb/RVrxk6hfEBhgsi8Ip6biiViclwa4u +WxlMDA4xCuh70JoCcaRyX31DoUkL2Cehv4qrjmVajnbtXZco3qeSPNi3XBmGyVcsIzs 5CLA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mDdPztC5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-210440-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210440-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d2e1a72fcca58-7056a146479si4246355b3a.43.2024.06.11.11.44.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 11:44:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-210440-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mDdPztC5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-210440-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210440-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1F0A228AB67 for ; Tue, 11 Jun 2024 18:32:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 72FF173473; Tue, 11 Jun 2024 18:28:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mDdPztC5" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8110B156872; Tue, 11 Jun 2024 18:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718130514; cv=none; b=fwqcDf2JDcTswo9sR262JQ1mVGDFaG26DZT7RcaLyg1D7YLnKKted9mVDj7V+tUogyxUx4PLavT+OsqBtGZySbGGuOEK0TJGaa4lbtRTsQJGFriCI1t5ywp1OTrqVBbP+NSid+Zc6GyzAahnJR8X2ADPfTUZvSIPgtPZL51RHPY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718130514; c=relaxed/simple; bh=j3EYgUxpMjgfmmR2THkxXKYiD0+fISTsMnZ5sXS6YPY=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=QCBRmt9DP+x4lv6HkqmZcITLVx78Ig5/K89bgjsj7hPWJJkXpELB6H4rsE/X8HxlKHAy9Q6xXEnEt/gUQut3w+Y/rTGBV+ZapM62AhRuKWJ4SAc7PFOaS6PGSqnFNKr2luDTQYHMu9Dzu8TWXp2FtuXSszGm+DvhKALe18AOb1c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mDdPztC5; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47895C2BD10; Tue, 11 Jun 2024 18:28:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718130514; bh=j3EYgUxpMjgfmmR2THkxXKYiD0+fISTsMnZ5sXS6YPY=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=mDdPztC5Q9KtE1SqqHauRE3BQg2MM2rrMDU4tC68RRnWORRZsLKH+2pPXe/3i47qv 56gI+s0U7nydon6CMJ2CYkFL08lmCDdO6C0io/g2ci5JOG+rqoqAW1CIERXEtYzUci TcwQCAWNi9dXnRmGFecR88Dhl2PxtZ/nHm4Tg99Zio4suBuTDOjOI1xJH3vTzWcsxz H+XoPVH/a1BGzTs1bNDNgwKreBDeFJSG+KyxgnFsulF+EGaU7fWIR00FRTuDOodGYz nlfY/Jmg7bqfOlxVC8de7kuER5aLoKH7xjOH0IirfnvoGKRHU0IEzIamI2q7qULW6S HiKBknUNLassA== From: Vinod Koul To: Dan Carpenter Cc: Yangtao Li , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org In-Reply-To: <8be473eb-65e0-42b4-b574-e61c3a7f62d8@moroto.mountain> References: <8be473eb-65e0-42b4-b574-e61c3a7f62d8@moroto.mountain> Subject: Re: [PATCH] dmaengine: qcom: gpi: clean up the IRQ disable/enable in gpi_reset_chan() Message-Id: <171813051191.475662.11143295801968577894.b4-ty@kernel.org> Date: Tue, 11 Jun 2024 23:58:31 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13.0 On Thu, 09 May 2024 14:02:11 +0300, Dan Carpenter wrote: > The calls write_lock/unlock_irq() disables and re-enables the IRQs. > Calling spin_lock_irqsave() and spin_lock_restore() when the IRQs are > already disabled doesn't do anything and just makes the code confusing. > > Applied, thanks! [1/1] dmaengine: qcom: gpi: clean up the IRQ disable/enable in gpi_reset_chan() commit: f8f530ba429a334fe1a28714787f8a98e90777ec Best regards, -- Vinod Koul