Received-SPF: pass (google.com: domain of linux-kernel+bounces-210463-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
Date: Tue, 11 Jun 2024 20:48:19 +0200
From: Dragan Simic <dsimic@manjaro.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley
 <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
 linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
 imx@lists.linux.dev
Subject: Re: [PATCH v4 0/8] arm64: dts: convert fsl,esdhc.txt to yaml and fix
 layerscape dts warning
In-Reply-To: <20240611-ls_waring_esdhc-v4-0-d0d8a5b3f3cb@nxp.com>
References: <20240611-ls_waring_esdhc-v4-0-d0d8a5b3f3cb@nxp.com>
Message-ID: <ea54d6b7794fbbd81df7653b4e988915@manjaro.org>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit

Hello Frank,

Please see my comment below.

On 2024-06-11 18:01, Frank Li wrote:
> Start from v4 because fsl.esdhc.txt to yaml already sent out as v3.
> 
> Change from v3 to v4
> - Add dts warning fixes
> - Add mmc-spi-slot's voltage range fix, (not sure why it apply to
> layserscape's dts file.
> - clock-frequency is not required property
> - add dma-conherence: true in binding doc
> 
> Now only "bit-endian" proptery warning left.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Frank Li (8):
>       dt-bindings: mmc: Convert fsl-esdhc.txt to yaml
>       dt-bindings: mmc: mmc-spi-slot: Change voltage-ranges to 
> uint32-matrix
>       arm64: dts: ls1012a: Chang node name from 'esdhc' to 'mmc'
>       arm64: dts: ls1043a: Chang node name from 'esdhc' to 'mmc'
>       arm64: dts: ls1046a: Chang node name from 'esdhc' to 'mmc'
>       arm64: dts: ls1088a: Chang node name from 'esdhc' to 'mmc'
>       arm64: dts: ls208ax: Chang node name from 'esdhc' to 'mmc'
>       arm64: dts: lx2160a: Chang node name from 'esdhc' to 'mmc'

s/Chang /Change / -- in all patch subjects

>  .../devicetree/bindings/mmc/fsl,esdhc.yaml         | 105 
> +++++++++++++++++++++
>  .../devicetree/bindings/mmc/fsl-esdhc.txt          |  52 ----------
>  .../devicetree/bindings/mmc/mmc-spi-slot.yaml      |  17 ++--
>  arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi     |   4 +-
>  arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi     |   2 +-
>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi     |   2 +-
>  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi     |   2 +-
>  arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi     |   2 +-
>  arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi     |   8 +-
>  9 files changed, 125 insertions(+), 69 deletions(-)
> ---
> base-commit: d35b2284e966c0bef3e2182a5c5ea02177dd32e4
> change-id: 20240610-ls_waring_esdhc-93136a5dd794
> 
> Best regards,
> ---
> Frank Li <Frank.Li@nxp.com>