Received-SPF: pass (google.com: domain of linux-kernel+bounces-210465-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <7e24a4f2-5f4a-4ed2-ac98-d60158e8e461@amd.com>
Date: Tue, 11 Jun 2024 13:50:03 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 03/10] cpufreq: amd-pstate: show CPPC debug message if
 CPPC is not supported
To: Perry Yuan <perry.yuan@amd.com>, gautham.shenoy@amd.com
Cc: rafael.j.wysocki@intel.com, viresh.kumar@linaro.org, Ray.Huang@amd.com,
 Borislav.Petkov@amd.com, Alexander.Deucher@amd.com, Xinmei.Huang@amd.com,
 Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <cover.1718095377.git.perry.yuan@amd.com>
 <41d5573ed19525f95d79d2af46bd1cce5779d6a1.1718095377.git.perry.yuan@amd.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <41d5573ed19525f95d79d2af46bd1cce5779d6a1.1718095377.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TUpPVjRlZzBnUlMrMWRReXg0Zmd4WWhQam1uSmpzb1lFeCtWVk5yditSSFlu?=
 =?utf-8?B?UGhGLzBGZ0RYeEpXN2d6N3RqbVhUbGF6TEtYRVdiQS9WYW1obmpSczlMd1Jq?=
 =?utf-8?B?QnJJN0V0eDJYUDFqSkRidEZEQTdydmJwaS9MYTd3S2Q3YWl5aWpiNmJlb1FC?=
 =?utf-8?B?V2tYMjdpKzAyZ3ZlV0wvSSs0cEllNmpIUEdIb29MSHNTREttUWF6QzcrRURQ?=
 =?utf-8?B?R3hKVy96dUJnNE9heU9iTFVKcmlreWdwTnNiUER1d3h2cmhIS01tWWNNaElx?=
 =?utf-8?B?OTdRd1IvNW51RHNhUEJkdVJqb3JLM0hxTGhOYmdUcEZvWVlSMHZpQ1BaUjc0?=
 =?utf-8?B?TzdLNnh6UXhIYVZBbFJqVDhKTTdrSDZHZXlKMnMzN2VPMS9LNytZVEZVckxF?=
 =?utf-8?B?N1ZvTzRqOVFEVVdIUzJCZzBqS2RkSkEvaEpaWFI5czhWZVBRUGJUanZnMC8z?=
 =?utf-8?B?VEYyMHVwYjIyWmU2Q0RmdU56K2FFbzZWMHdvVHFSSkRpZEQzQmF4OVRsVFB2?=
 =?utf-8?B?Q3BDclZscXVtaVA5bExIWGR6SkxGSWE5R2kwdVRuRUlrK21sUFRBUTJVSEcy?=
 =?utf-8?B?MUJyakNNTGM2MFhObjJaeGxEME96aXk3YWFpWFdlbE12RHdzcXR0RDVYS2pV?=
 =?utf-8?B?d2JJdDRqTjJaaEhFa204YjJwcSt5VFlYSS9yYXRBQWlrUDA2OUlZdjFWR0pH?=
 =?utf-8?B?akhDNU9pbk94TGpaL1hlOE55YzdOZmF4bHJRVDNFV3lHUW1xVGRVVmR5VGJm?=
 =?utf-8?B?d01IU3paa0lwU2d4TnUwVUZsVEZzVm5BdndrOFBCbjd0Y3NWZWZvMFlCMjcw?=
 =?utf-8?B?RWhURllwMnJaR2dkY1djY0gyeTJBaExVSGRrT3N2Mm1jTFlMSnhNOWlZK2NW?=
 =?utf-8?B?Wm5Pc2Y4bmp5RVB2dzN2RUpRVWoxV0xZUnoyT3FMT1NWZ05OaWhTTjUvT2h1?=
 =?utf-8?B?bTFIQmpkNXRKNllTQ2VHUUZHTm1abTBnSVJYUGdyNXZ5bmFhS1RyTFFHNzM3?=
 =?utf-8?B?WXppQ2xjYytpWDkwckJkb0ExUmpCRnY5d3hhQUN3cGFOZXRRNXdSOUVQcEZR?=
 =?utf-8?B?THJlK3JtVml4Z2dqSElNV1BOV3ZJRjN2SkxKb2VQZmhJbk90UlgxZWUybkx5?=
 =?utf-8?B?SG9rSjIyQk5pOFJZTVJYRks5SDFPaEVNKzRoM0VicjVJWXZMSGVQNW1iRlpS?=
 =?utf-8?B?SlpsbEtDUk5uZE0xSjF4Y1JrMG56K0pGU0Q5YzR4UFltTmo4bXpQbUxsVy96?=
 =?utf-8?B?ZTE0WDQ0QXZUYmtHSXJtOWZwaGZDdTBOZm9ZZ1RLUWNBUElNMVFpZ01QT2I0?=
 =?utf-8?B?VEZZY3FmODRJZzBsK3YzTlk4WW9GSWFLY3lvTFlibFoxaGZlNm9xSC8wY0hu?=
 =?utf-8?B?OHZCVVFHRERrenp6WjgyOFFjL3AzN29xNWRRS2dHb2R4RUdUZFlpKzFTcW8y?=
 =?utf-8?B?Y1ZtaVBLejhrSWFlTm5nWlNVNHNSZ1I2WnUwYmQ5NW53ZWMyWmg1VVNpV1Nv?=
 =?utf-8?B?SW5Td0t2bjVVZEFFZlpjVVZzM0MzQzNGb0pMcTZaeXJVdkhPbHRoVHBMRkor?=
 =?utf-8?B?KzFVMUhLbEtsZE8rT1YxbWVaVnZvL3V1eGwwcmNhMXF2ck1ZdlZsbjNCUzY3?=
 =?utf-8?B?dWw1YXVreTc2VEJrRXo4V2ZPbTd3L2pmZ2lWb2tQcjRCajhhWlZxeWtNb0xR?=
 =?utf-8?B?eHpKYUFKWHVlMUFNeUg5TWsrVzM0U0ZScnZ5ckdzU2hUcUZ0YzhZbkFUeGRQ?=
 =?utf-8?B?NndNeENvVEs5MG9zbGhUbExGM0RyakxQUnpQYUJBaE1pczNCTTNzQXc3cU1P?=
 =?utf-8?B?N1B5bEI1VmkrTmw2aFVxSVAwVHNJL1FMUCsvMWNRWW5EZzczZUg0a1pqdWVt?=
 =?utf-8?B?enl5WG05MmhOa0ErYjZOcjRRUHV4Nyt2TUNJNjMxRHZDQWdFcWgydUM4eGlB?=
 =?utf-8?B?NisrOEw4UFJ6RlkxUXQyRHdBaitTRGUya0JCdWNoOGhlKzZMd1FtS3FMVldw?=
 =?utf-8?B?N0VOUEdyeE9XV3hrR3RKakFDOCsydUNZaDNDRVJLWVhwViszb2VzNGgwelpW?=
 =?utf-8?B?NEc3OWcvalBRNElLczVXT3hJdDZFWFBRUHc1RitoVkVqdTlESFU3Y3h0am1q?=
 =?utf-8?Q?PQzguZp2Uo9M8LLFlsDlaAalI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0853f7be-8bfa-4e7d-8494-08dc8a474ff7
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 18:50:07.0305
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /V3YWjKYWLNdmrJiKkyrElBabweqTvjmhxQwMfsLvn30ZoiyMkgs34XqzPcYvfbUfNccyVtftssiRSX69JVuFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8836

On 6/11/2024 03:52, Perry Yuan wrote:
> Add CPU ID checking in case the driver attempt to load on systems where
> CPPC functionality is unavailable. And the warning message will not
> be shown if CPPC is not supported.
> 
> It will also print debug message if the CPU has no CPPC support that
> helps to debug the driver loading failure issue.
> 
> Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
> Closes: https://lore.kernel.org/linux-pm/CYYPR12MB8655D32EA18574C9497E888A9C122@CYYPR12MB8655.namprd12.prod.outlook.com/T/#t
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

Acked-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   drivers/cpufreq/amd-pstate.c | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 36b1964ca8d3..f166b3b94091 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1740,6 +1740,20 @@ static int __init amd_pstate_set_driver(int mode_idx)
>   	return -EINVAL;
>   }
>   
> +/**
> + * CPPC function is not supported for family ID 17H with model_ID ranging from 0x10 to 0x2F.
> + * show the debug message that helps to check if the CPU has CPPC support for loading issue.
> + */
> +static bool amd_cppc_supported(void)
> +{
> +	if ((boot_cpu_data.x86 == 0x17) && (boot_cpu_data.x86_model < 0x30)) {
> +		pr_debug_once("CPPC feature is not supported by the processor\n");
> +		return false;
> +	}
> +
> +	return true;
> +}
> +
>   static int __init amd_pstate_init(void)
>   {
>   	struct device *dev_root;
> @@ -1748,6 +1762,11 @@ static int __init amd_pstate_init(void)
>   	if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD)
>   		return -ENODEV;
>   
> +	/* show debug message only if CPPC is not supported */
> +	if (!amd_cppc_supported())
> +		return -EOPNOTSUPP;
> +
> +	/* show warning message when BIOS broken or ACPI disabled */
>   	if (!acpi_cpc_valid()) {
>   		pr_warn_once("the _CPC object is not present in SBIOS or ACPI disabled\n");
>   		return -ENODEV;