Received-SPF: pass (google.com: domain of linux-kernel+bounces-210467-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <7e39d303-933a-4715-893b-5d11474ecf70@amd.com>
Date: Tue, 11 Jun 2024 13:50:21 -0500
User-Agent: Mozilla Thunderbird
From: Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH v3 02/10] cpufreq: amd-pstate: remove unused variable
 nominal_freq
To: Perry Yuan <perry.yuan@amd.com>, gautham.shenoy@amd.com
Cc: rafael.j.wysocki@intel.com, viresh.kumar@linaro.org, Ray.Huang@amd.com,
 Borislav.Petkov@amd.com, Alexander.Deucher@amd.com, Xinmei.Huang@amd.com,
 Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <cover.1718095377.git.perry.yuan@amd.com>
 <9278090e44050a43692173461eb7a915c123618e.1718095377.git.perry.yuan@amd.com>
Content-Language: en-US
In-Reply-To: <9278090e44050a43692173461eb7a915c123618e.1718095377.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YTVsL2pmdmNuSHE1RjV4eFFic3FwZ1hQblJLWGZIaHhEMG1uRDZUNlEwSlJL?=
 =?utf-8?B?WkhVNi9ldi85OUNIcUVZTDd1MFlwbW93eDRleTRTbktibEZqbU5DL1RtVCtz?=
 =?utf-8?B?UjdKbXJROVJtQTNwSWs2Vy9TL3FYYm5FNnJCZlVuSkRmdlA4Q2VZd3ZySVRX?=
 =?utf-8?B?MkF2SUpyb0NMM1Y3V3hJbitPUTVyMEFlZ1lyWDBJdnpsc1B4Q003UnJuN3dq?=
 =?utf-8?B?cXR2WXhNNTJURWJ4TDgrSGZ3UEdDdWV6MnhTaEN2L29YVnRGNVBydWRQV09Y?=
 =?utf-8?B?VVhuVWpwb1dwSFd6N3VkbTRoS08zSGJDa1YyclJ0bzBNRFZVK3dUMmhoOWsy?=
 =?utf-8?B?NXBGUDVxU2dhR0lralVsUEtta0ptNlBsbGVUZXAvaTdDQXZlRzR6UmpiUDNI?=
 =?utf-8?B?YUpHSStlM0p1VkpQemJpbGNUWHh2cjkrbmtjeGU2L0t6ZUdkNlBiVTRuUStM?=
 =?utf-8?B?RC9PbGNwQUhRT01PVGtyTDZIaGZnUXBIZ0tQQjNOSE5ObEVuSVAxQjZhMDRF?=
 =?utf-8?B?VCtad2E1T2xlRlZUYXR1U2NvOGJvL1RNa1hGdmRtajlBVnpGdm5NUVBtRFhE?=
 =?utf-8?B?d2NNRko2MlVSQWNoSDlFS2U4ZVc5QUQrNjl0SGxCR0t0d1RtTVQ3ZzVpcVBD?=
 =?utf-8?B?RzFPYzhRUVZydzZ3UnNhKzJwZG03blVUc2J3QWI5RDJyWk1ydUZWb2pBb2pS?=
 =?utf-8?B?eGc5RmZndy8yc1hLNWw5U2IzQmxVNU94aDNuSUJKMkxZYTF3SGIxQzlyYUhK?=
 =?utf-8?B?TXZRUDZ0dkpKb0hvdTc4OGpJQllIY082S1NSSHJiUTdHNG1sSUMvWU15VDZo?=
 =?utf-8?B?clhldDR0dHJwRWpqVGxzVVZlbnNka1Ric0hjMXkxdnAzNnloK2xqb0FGazJX?=
 =?utf-8?B?VjV6d25lc2ZxOC9JcnpsTElybDZVRTZWYm12ZzFJVUFTbWZsVURVdlN1UVFh?=
 =?utf-8?B?bjIzdGtXZzNQMXFYYmJBV0RzczBSbnczb2sxYnNRb1lNN0dTYk5NRmtWUnFK?=
 =?utf-8?B?aHc5SUdQSXBUQUV4SWtiZXF3K2J1ZUhHL1FxTVpvN3hqRVExYlRIcDE4U0dX?=
 =?utf-8?B?Sitoc1lZTVZES2JveTBnVURlbTBpYkVJRzdKT0JKRXFMUGxvaXo1R2JkUGNW?=
 =?utf-8?B?alV1RFJoM2FKdEZFMjJGZ3JmN0J4M0tTNUpYUVhZYmhTM0puV3QzTCt2T3kr?=
 =?utf-8?B?UHpWODY4ZUw4MHhzbHRxbnpubC9PSnkxU2k3dE11MkpIL2lOQUVrWlpjcXVV?=
 =?utf-8?B?QjFlaUhWMWVwM0ZNNVBZTlNpbnVMYi9ZTEs2ZUErUTdrcTZoOXN4T0ZEVzBq?=
 =?utf-8?B?RStOMUxBOW1VWktxdUVKM2I2azNFM1M3dEE0YktNQTlGeklOMjJpYS9FTjBy?=
 =?utf-8?B?WjRpc0dQVk9tOHZJK05ibHI3aEtlVVAxS094THBISkdPSS9hNzBjRi9Ib1Qx?=
 =?utf-8?B?NHhKcTFWL3lmRjBCUWdZWVZYL0NZUkY4N2pjcVFZMTAzZmtqM29BeXRjeFJ5?=
 =?utf-8?B?S1M0aUgxOXhFR0djUnA1WERIWTZodUxHdklPYWpvYyt0SVNLMWpPRUMwazBB?=
 =?utf-8?B?bDIyWGFkSVIzTlREY1VXREFCdytMSUhXUjRwNkIzNkZPNmovZHAydWoycWx4?=
 =?utf-8?B?b20vK1ZrRWtIbzFBb1A1SWZTd0w0TTl0K29KZlJ5OTMwWnlGdlZld0NTTkZp?=
 =?utf-8?B?blR6U2tjS0Voa0ZFVVozQ1orWDBZMk1zVkltZXJjQk85eXR3Q2V3YnRQY3p4?=
 =?utf-8?B?UkU1bXREUzlaOG16Tm1iN1NMVzE5Y0gvT0tkM1hhS1RZeXBCbzF0b29RRHdU?=
 =?utf-8?B?VGEzUTZFR2JleFd4ckdIaEd0azc4cEcxZE0venIwWnQyRDlyRW9MektTTzh2?=
 =?utf-8?B?ZHhkL25aYVNlVnlJdlZOYUFKMWkrVkdiOXczNkhYVjU1aDR3THNqbVBtbmlx?=
 =?utf-8?B?SnlQTlBTS2YyZlpzV2NwWSs5blJLcWZqc0VrQ3Y1a2dwREl0Mm1LS3hjM2Y5?=
 =?utf-8?B?QXNzeG84Y041VWtEdzF6UlgvY1BpSmtzbzZKa25VczZ2cU1YMW8wTnQ0eUhj?=
 =?utf-8?B?OGl3NklPT2xhZFJXK0F0cUphYnpwMzJCYlN5VmR3dG5qYWt3L3JGWWJMdUdL?=
 =?utf-8?Q?Du4QPTo/fvT0L8VR4EoOSG+Qo?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c8af488a-8d6d-42b5-d320-08dc8a47596a
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 18:50:22.9169
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iR/1Gs5a1T8M8yTm0imywWhIfkvG86DpxniZyX715h9Cl822EwqmvFelYEZTwhxGiy2GGQeWLYfX1SSQZO37Pw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9425

On 6/11/2024 03:52, Perry Yuan wrote:
> removed the unused variable `nominal_freq` for build warning.
> This variable was defined and assigned a value in the previous code,
> but it was not used in the subsequent code.
> 
> Closes: https://lore.kernel.org/oe-kbuild-all/202405080431.BPU6Yg9s-lkp@intel.com/
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

Acked-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   drivers/cpufreq/amd-pstate.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 37fce0569d06..36b1964ca8d3 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -944,7 +944,7 @@ static int amd_pstate_init_freq(struct amd_cpudata *cpudata)
>   
>   static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>   {
> -	int min_freq, max_freq, nominal_freq, ret;
> +	int min_freq, max_freq, ret;
>   	struct device *dev;
>   	struct amd_cpudata *cpudata;
>   
> @@ -975,7 +975,6 @@ static int amd_pstate_cpu_init(struct cpufreq_policy *policy)
>   
>   	min_freq = READ_ONCE(cpudata->min_freq);
>   	max_freq = READ_ONCE(cpudata->max_freq);
> -	nominal_freq = READ_ONCE(cpudata->nominal_freq);
>   
>   	policy->cpuinfo.transition_latency = amd_pstate_get_transition_latency(policy->cpu);
>   	policy->transition_delay_us = amd_pstate_get_transition_delay_us(policy->cpu);
> @@ -1395,7 +1394,7 @@ static bool amd_pstate_acpi_pm_profile_undefined(void)
>   
>   static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>   {
> -	int min_freq, max_freq, nominal_freq, ret;
> +	int min_freq, max_freq, ret;
>   	struct amd_cpudata *cpudata;
>   	struct device *dev;
>   	u64 value;
> @@ -1428,7 +1427,6 @@ static int amd_pstate_epp_cpu_init(struct cpufreq_policy *policy)
>   
>   	min_freq = READ_ONCE(cpudata->min_freq);
>   	max_freq = READ_ONCE(cpudata->max_freq);
> -	nominal_freq = READ_ONCE(cpudata->nominal_freq);
>   
>   	policy->cpuinfo.min_freq = min_freq;
>   	policy->cpuinfo.max_freq = max_freq;