Received-SPF: pass (google.com: domain of linux-kernel+bounces-210484-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Pandey, Radhey Shyam" <radhey.shyam.pandey@amd.com>
To: Sean Anderson <sean.anderson@linux.dev>, Andrew Lunn <andrew@lunn.ch>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC: Jakub Kicinski <kuba@kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Russell King <linux@armlinux.org.uk>, "Simek,
 Michal" <michal.simek@amd.com>, Paolo Abeni <pabeni@redhat.com>, Eric Dumazet
	<edumazet@google.com>, "David S . Miller" <davem@davemloft.net>,
	"linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH net-next v2] net: xilinx: axienet: Use NL_SET_ERR_MSG
 instead of netdev_err
Thread-Topic: [PATCH net-next v2] net: xilinx: axienet: Use NL_SET_ERR_MSG
 instead of netdev_err
Thread-Index: AQHavBXdRESnBvzehE+BJnQF69x8abHC7D9w
Date: Tue, 11 Jun 2024 19:05:30 +0000
Message-ID:
 <MN0PR12MB5953B7A04D4B9C9D92D210B8B7C72@MN0PR12MB5953.namprd12.prod.outlook.com>
References: <20240611154116.2643662-1-sean.anderson@linux.dev>
In-Reply-To: <20240611154116.2643662-1-sean.anderson@linux.dev>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?yohdquRueKuwiFue0oLCxrR1jJDWwWDpmkeDHHD/K5ICeOrGcmwYkxDHB0d9?=
 =?us-ascii?Q?VJNdbnqGTrmeUPRyWkgKu2XLNxJ109Wn7tQtHv1Wdgtzds0kHuqNki76v7uc?=
 =?us-ascii?Q?zfu5kO83EWbbdVLMZPm706VdGHrNM4uM/OlDVw7+JG6Xz1n02AzmuhXSh68g?=
 =?us-ascii?Q?l7rr1BK2L4LoXLck09qgWHWX2DGb7kAfpKG1opL/ukZuV0xou9ktKSu4ZAm9?=
 =?us-ascii?Q?IS1EyrmgnOLpc9ftHDRDYEmI0CYFGKZ1+1tTI3qtvPBhtuZkzPEVJO3mLgyL?=
 =?us-ascii?Q?4nMlLwmnomVb825LXSRBRPHkXh7NPnHgUQeIbNtt0k+/8IJi1VSxfdFo/yrb?=
 =?us-ascii?Q?WIl0NJDV6Ak4yZldZ5Xmek08talHEllVe5C7XAukARL68qjdmBXFerUR/7lR?=
 =?us-ascii?Q?ic6InRBqLfMgfxGYOT9GoZDoq2jUsBHnatYsdJEwefb6JA71bUbVx5m6BIsT?=
 =?us-ascii?Q?Jq3J9U+qbnhZkRg9kFknYf4IM8T2auFQAQqX0+dvht14YYIKw56DmlGlm48H?=
 =?us-ascii?Q?O8FibZj68cOxEWB0ICp5pRCkRz2xub/p50ZFHZOrEKVaaH/vo+3ETUteA48T?=
 =?us-ascii?Q?OE9eqCoFCMhIcJRO5gI92YR+OaRT+h4RkNJ3RaRsZjuFrPn0JqRedIF24HlF?=
 =?us-ascii?Q?XCialtSXOv5PrKuzZ/zn7MBfCtVLacEebhCmnjvUpxizYm3iZppTFXgSxOBJ?=
 =?us-ascii?Q?w4oNt6sOEr69Uk4ifObjcU8CKRbyiZSWExOGxpRvd9ynhLdnSvfNkB+8K9A7?=
 =?us-ascii?Q?ENhtlycGGGRW35mUBMDRPiYbLo0GOixNq8A6TC4nREI/FKDNQ2VMkoiSWy32?=
 =?us-ascii?Q?tQXqhktf+kzb3w9hcGdQx2Dcdqyt7CJRI2POrVSJ5bXyq7zpp8K1X0dTZCup?=
 =?us-ascii?Q?1iOxIESckNa+YNzjJ5yRDeBsRXbXplb4AQ2tCuILxwRDttdQdoeCTSWSyc9/?=
 =?us-ascii?Q?W5lYdFNLNV/DQBck4j1xk9sMwhYn1y7SrbzEJThuV71ZdXzmR+nnfQInAwnn?=
 =?us-ascii?Q?h9ey44ejzY9ZTpa/UW9uC7Fn3GSuTCNtGyPbV2LvRl0UX8QlHXynonGE7rM5?=
 =?us-ascii?Q?550eF0xhhSNJYFgkKF/I1Bmfa45mzBeWnwO5LLtiAK1uOAeb1nOiA62ccwtN?=
 =?us-ascii?Q?jhna3KZTpclRtEQ6c+yL4U7rnxsqhMEMHE0PzRCeRdTnQVPUPsBdVRmLWRiU?=
 =?us-ascii?Q?Ey9hLJsaX9+Ba/F4F2F1V8MEFFJCorE1coqF4FPf07SYrxd1pd1b3Pdf3xZs?=
 =?us-ascii?Q?AFLyYhNG5BMH7/dpsdwktDwcyivTJQPRSM7FMMe/KVkmgDcr8hBkM5FfBQE/?=
 =?us-ascii?Q?biTL26FLCkOVzuqnbhdGRYOE/Xe0lpOZAw5cxDe9rxYuqV+I0/Sp3CTeDDbg?=
 =?us-ascii?Q?ZjEmf2NrAoOA2431cQ1ljej/Xf9bYG0iYkeQEubxjYJIFZ4153hm65WvD55k?=
 =?us-ascii?Q?4WnMXVaebH2amHBPJgF1dfhbbV8+MOMeRk17YvHCzaV94Y2H6AgA+ZgYjBON?=
 =?us-ascii?Q?vr15zLK1z9KbzMTahtuM1LFjO18SxCYzG1c8yH9cODKFsy59Aro0dc88kEt0?=
 =?us-ascii?Q?6qgtk9FAAD53qDAHF2g=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB5953.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69f548d8-91eb-416d-6d54-08dc8a497655
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2024 19:05:30.2112
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X2DAX+3gWFv9oL8jWGJWAcRmWX+oTvNpMuZDG43VoFZqfSM+x6eOm6+QroEaSNzc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4402

> -----Original Message-----
> From: Sean Anderson <sean.anderson@linux.dev>
> Sent: Tuesday, June 11, 2024 9:11 PM
> To: Pandey, Radhey Shyam <radhey.shyam.pandey@amd.com>; Andrew
> Lunn <andrew@lunn.ch>; netdev@vger.kernel.org
> Cc: Jakub Kicinski <kuba@kernel.org>; linux-kernel@vger.kernel.org; Russe=
ll
> King <linux@armlinux.org.uk>; Simek, Michal <michal.simek@amd.com>;
> Paolo Abeni <pabeni@redhat.com>; Eric Dumazet <edumazet@google.com>;
> David S . Miller <davem@davemloft.net>; linux-arm-
> kernel@lists.infradead.org; Sean Anderson <sean.anderson@linux.dev>
> Subject: [PATCH net-next v2] net: xilinx: axienet: Use NL_SET_ERR_MSG
> instead of netdev_err
>=20
> This error message can be triggered by userspace. Use NL_SET_ERR_MSG so
> the message is returned to the user and to avoid polluting the kernel
> logs. Additionally, change the return value from EFAULT to EBUSY to
> better reflect the error (which has nothing to do with addressing).
>=20
> Signed-off-by: Sean Anderson <sean.anderson@linux.dev>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Thanks!
> ---
>=20
> Changes in v2:
> - Split off from stats series
> - Document return value change
>=20
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index c29809cd9201..5f98daa5b341 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -1945,9 +1945,9 @@ axienet_ethtools_set_coalesce(struct net_device
> *ndev,
>  	struct axienet_local *lp =3D netdev_priv(ndev);
>=20
>  	if (netif_running(ndev)) {
> -		netdev_err(ndev,
> -			   "Please stop netif before applying
> configuration\n");
> -		return -EFAULT;
> +		NL_SET_ERR_MSG(extack,
> +			       "Please stop netif before applying
> configuration");
> +		return -EBUSY;
>  	}
>=20
>  	if (ecoalesce->rx_max_coalesced_frames)
> --
> 2.35.1.1320.gc452695387.dirty