Received-SPF: pass (google.com: domain of linux-kernel+bounces-210485-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <ba8cdf39-3ba3-4abc-98f5-d394d6867f95@gmx.net>
Date: Tue, 11 Jun 2024 21:05:24 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Raspberry Pi5 - RP1 driver - RFC
To: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley
 <conor+dt@kernel.org>, Florian Fainelli <florian.fainelli@broadcom.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@broadcom.com>, devicetree@vger.kernel.org,
 linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org,
 linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
 linux-pci@vger.kernel.org, Dave Ertman <david.m.ertman@intel.com>,
 Lizhi Hou <lizhi.hou@amd.com>, clement.leger@bootlin.com,
 Jeremy Linton <jeremy.linton@arm.com>
References: <ZmhvqwnOIdpi7EhA@apocalypse>
Content-Language: en-US
From: Stefan Wahren <wahrenst@gmx.net>
In-Reply-To: <ZmhvqwnOIdpi7EhA@apocalypse>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:un4fNYOcPEA=;NqyyWz/kMQ9QKJ47+10JgX7FWKm
 BMhxX+dcObiguuZshliAbKRhZQ/WczhJ9i6zzsCC+pVwzAqkwM5DXEsRScU7uFRC4Jskh8rGL
 Zo75OcU7LEP5XjlcsjSExw9uavjtm8FBMU/3lgDdQGe0EkwUYCzsADPpxFCDMK78z5akRpaZm
 sJAJ3uhltQs021NF4CQ6cUJNNaXCcX3CdQV28pF+fQ2eG3AEKrPIWptkRITvAJRYXmvdDj1/q
 e6XVmDz2vWkzA72E8fOYud1l8bFyO5VSaZWjFhX4YccVusuE0yvNLBGC0QWulJS1js3eBuDHw
 JOrNjt9JbTjqjxifqbWra92+lOfwONY2B3YgxMSHQEPMH11Oc/h2AMQV2Qi0pOd6bM9nZOqnE
 YfIdHl7WU2qEfy67r0MdCspArw0+az8tC3F5kVYsH8f+nroN9Ko52IjjRE/nTXesh5v30FNYa
 Hf2vfxxc+zuTL01qGv2ITz/HNuMScVJvHMCpgnLjFDuhltSQKfW4upujH3N8Bxk0nS+aT0K+d
 TnkCtvXqZsbFBGx4SBil7Gh6K1LnlPX7Py2klyWmk6kwh9M7QM7n0B7F9uPBLkF8OQRePP5cL
 verF8Y9YOyX46IpX1c2gJi9s+ISi/I5BXqyxXwASe6AM/zM7uqgA7R0gD0YWUi8yXU7epfwl4
 xDYTuyMW4SwyURJKqyKH6jBwqmhtfBuwKjIpu2BziOn4hN8QyHsZkMxlYPf2p/qzwToxu4g1n
 oN5yQ/7/xjKO9Q8lnP0KwpsqAtAGQ16OcPTSvxLX1hVx1wEtPCToaCUDV6Z6X0vSoOZN6VVvK
 F7HO+m8p41KaR8uee3ytOxcAepakG2k53CFgZy6CCnMBM=

Hi Andrea,

i added Jeremy, because AFAIK he was deeply involved in ACPI
implementation of the RPi 4.

Am 11.06.24 um 17:39 schrieb Andrea della Porta:
> Hi,
> I'm on the verge of reworking the RP1 driver from downstream in order fo=
r it to be
> in good shape for upstream inclusion.
> RP1 is an MFD chipset that acts as a south-bridge PCIe endpoint sporting=
 a pletora
> of subdevices (i.e.  Ethernet, USB host controller, I2C, PWM, etc.) whos=
e registers
> are all reachable starting from an offset from the BAR address.
> The main point here is that while the RP1 as an endpoint itself is disco=
verable via
> usual PCI enumeraiton, the devices it contains are not discoverable and =
must be
> declared e.g. via the devicetree. This is an RFC about the correct appro=
ach to use
> in integrating the driver and registering the subdevices.
>
I cannot provide much input into the technical discussion, but i would
prefer an approach which works good with DT and ACPI.

Best regards
Stefan
>
> Link:
> - [1]: https://github.com/raspberrypi/linux/blob/rpi-6.6.y/arch/arm/boot=
/dts/broadcom/rp1.dtsi
> - [2]: https://github.com/raspberrypi/linux/blob/rpi-6.6.y/drivers/mfd/r=
p1.c
> - [3]: https://lpc.events/event/17/contributions/1421/attachments/1337/2=
680/LPC2023%20Non-discoverable%20devices%20in%20PCI.pdf
> - [4]: https://lore.kernel.org/lkml/20230419231155.GA899497-robh@kernel.=
org/t/
> - [5]: https://lore.kernel.org/lkml/Y862WTT03%2FJxXUG8@kroah.com/