Received-SPF: pass (google.com: domain of linux-kernel+bounces-210486-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <7fb679fb-f043-40e0-9a66-ce8045386135@amd.com>
Date: Tue, 11 Jun 2024 14:06:56 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 05/10] Documentation: PM: amd-pstate: add debugging
 section for driver loading failure
To: Perry Yuan <perry.yuan@amd.com>, gautham.shenoy@amd.com
Cc: rafael.j.wysocki@intel.com, viresh.kumar@linaro.org, Ray.Huang@amd.com,
 Borislav.Petkov@amd.com, Alexander.Deucher@amd.com, Xinmei.Huang@amd.com,
 Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <cover.1718095377.git.perry.yuan@amd.com>
 <18032dece7cb9089bf82f2b37c7ab781148d70be.1718095377.git.perry.yuan@amd.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <18032dece7cb9089bf82f2b37c7ab781148d70be.1718095377.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?U1o2OFFBZDBYcDhpTHpNUjBva1ZvbjlJM3dLSTFwektENzJoN0FFaVZIakQ4?=
 =?utf-8?B?Y1NTZWZ4aEpJYTFLQW9VaDFiazJUU0RUeE9QdzZOREN0V3ZMc0xXd0pXbVVK?=
 =?utf-8?B?emVyS1BXRTA4eVFYY1hHRnVwR2ViTEZnMHhlZkdBTHJuckZ0RHZTcFZqa3Bs?=
 =?utf-8?B?czV5R1dRazB3Y3BrVGFDS0FFbHNVSDBxSUhGK29WMmxMbWp2cURiVTE0QmZI?=
 =?utf-8?B?QitNODdvQjZ6andaVWhDYWZ3MGJBb1JRUjFLTmFkUjFsaXBUYjU4OFlVcGNF?=
 =?utf-8?B?bTgwOFFSSXlwdVR6aFZVNnY2Skxad3Fld2dGQ2dhMExhYWowVDczT3R3RUxz?=
 =?utf-8?B?ZCt4cWtVTllXcDFPVzNCMG5FRE1NUTJ2NkUzTWpaZkRLeUNUdHZyNjhDbHlF?=
 =?utf-8?B?Skl4UXVjc2lRQlpZN3VEQmFvbE9JMkhhOWtsemY2cG5jbEx5dDh6ckV0R0Yz?=
 =?utf-8?B?aUhTUW11UjhycE9FaW5GekllSXFXU0g0UXlEQjFQVDJWMENNbzc3ZHZFS3I0?=
 =?utf-8?B?SVg2MmVoZ1krblNvNnZXZndOU21rWkwrcGpGQnFJU0ltZEE1U09aWXBYWC9x?=
 =?utf-8?B?dFY5VTNQbkFFaVA1VDFVR0dWeTdDSUJVTDBxY2dSd3VGV1g5RFB5b2w0N0U5?=
 =?utf-8?B?bUNUbjZrcUdKOVQ2RTlwSldxeHQrelZMYnF4SWRSY1BTNysxK2N2MnhqVUZU?=
 =?utf-8?B?bUp6SHRKbDYrRVMvNDVsei9ONit1QVlod0JyeHMrL0lDKzcxTjlJdklOVHlU?=
 =?utf-8?B?WS9wZzg2QW5md2lMQUNxWUl3NGlGZnZEa1NMM1dmV0xWT3pCYUZNRG1zbk9L?=
 =?utf-8?B?bEw3dzFqYVlCNitBWlEyWXFiTUFxOGZNZWRzR1hiSGlyTTJ1M1IvQys5dDZD?=
 =?utf-8?B?K0NqTWEyenNiVDBra0RtVHB2c1oxaUN2OHNKUEsrd1pud2YzSGNCMG9tcm5R?=
 =?utf-8?B?VFlmazBRRnRGaEhSa21XZFdZaWdiMGRna2FLb2RSdG5heUpkNFZLMFVmTXhm?=
 =?utf-8?B?K1BxbFNtekVsbVJBTFVhZkpVNFlXRkhld2JzcjdQNi9iTk1yRW94TVp2ZDZL?=
 =?utf-8?B?REUvL0pkVXh3ajRCUUlVbXRrcVQ0NE1iWElkOGUrWEh6VXVDZTlhRURxVzJF?=
 =?utf-8?B?VmVHcm8xbGgvZHYzRTdqM1UzbU8wT2RXN2xXMjRaTmI4VUE1UjIvTGl6Q2tZ?=
 =?utf-8?B?VlBIZGl2NHh0NTNLZjI5NXh0ZzhLa1pLTWYwQXdYcWRCZnAycmlxTnl0dnQv?=
 =?utf-8?B?U0dVSnRPNWxnQ1prd3lMbVRCcGhCSmFQYWRwOXUrOFdHTFJTdFlaQmhlaTV4?=
 =?utf-8?B?UHRzSGtvcHZMR2dlTVkrL3FLaEhHbmxzNTVpL2Y3SmpyWjZ3bTBlZGlBOVQ2?=
 =?utf-8?B?RWJ4eFo1UHVRQ09CbitUdnNpNWdObkNtOFhBdnZDcjVlaVNFQ0pyejhJbnJF?=
 =?utf-8?B?SWtVQk9PNHlrNjcwbEpZdWFUVjdmK3M0U2JMdmM1LzF4RGlJSFZRTmgrNlJQ?=
 =?utf-8?B?L3pNZHRoTWJCTkRZZTdTbGhLM1ZOUi9ZdGllTlZ4THlOTURLdkppQW54djNR?=
 =?utf-8?B?VkVESkZ0Wnd0R0ZkczB5aWxnUnpzdkIyNldKcUk4NzBCZDFTQmtRaUF3enBp?=
 =?utf-8?B?U3BTUGZaT1lTRTNTRis1Y281dHQ4T0txalptSmVvYTRNMDltRWcrZEdXaXJR?=
 =?utf-8?B?a0M3ZW0zengzOWhEMFZSK0pEMklmNmNKNWVhZHVWZXF0Z1pTemtlMmlianQx?=
 =?utf-8?B?Qi84cXZwMllSalhldE1YNS9kQ3VWczhhM0tHV3FQQ2RvZmRCUmdJdG04ZStH?=
 =?utf-8?B?UHZXVjZ4aWRNbndVZTVRTG5JYi8rRUhFVDJmL25FMEdvUml6SitxUHJoNEJV?=
 =?utf-8?B?UUlzV0s0aG4xSERQc0tZMVdXMlViSFA3V0MrQTR1cHJZaHF1cDU2b3pWYlhj?=
 =?utf-8?B?Rzd4ektQeUkxZ1VMZzNoQjlvdjYycWZQWG5LajJWMExETjBLYTlIcXhyeUNm?=
 =?utf-8?B?Y3ZHWDdpbzQ1TW1jM2ZESTBKM0pLS3phS1lGclN6TmY0YkQ2Q3BRQTRFdG9R?=
 =?utf-8?B?ZmhIY1R0MDRFZUFUZGpRbmNZcTVnQTVlT3pvU0U4STBUTEJBOEwrcDQ4dXk0?=
 =?utf-8?Q?b+/WvQucpP5F5tHyL0N2F66+Y?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc28bd45-9671-4397-ae0c-08dc8a49abf5
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 19:07:00.3751
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: po9XjjGNPhROtjXa98lOBPdn4cxeNW9MJ4wyD02wzKVE0VB7jbz6GRzB7GKtQ2Il0wJM74pJsb32vvTjxYR8JA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7592

On 6/11/2024 03:52, Perry Yuan wrote:
> To address issues with the loading of the amd-pstate driver on certain platforms,
> It needs to enable dynamic debugging to capture debug messages during the driver
> loading process. By adding "amd_pstate.dyndbg=+p cppc_acpi.dyndbg=+p  loglevel=4 debug
> amd_pstate=active" to the kernel command line, driver debug logging is enabled.

Here's some suggestion for text.

"
On some platforms if amd-pstate fails to load or operate properly users 
will need to turn on extra debugging messages.
"

However - I would argue that the messages are the wrong level if they 
need debugging messages turned on when it fails to load.

Something causing a failure to load should be pr_warn() or pr_notice()
IMO.

> 
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>   Documentation/admin-guide/pm/amd-pstate.rst | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
> 
> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
> index 1e0d101b020a..de83e742738e 100644
> --- a/Documentation/admin-guide/pm/amd-pstate.rst
> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> @@ -472,6 +472,19 @@ operations for the new ``amd-pstate`` module with this tool. ::
>   Diagnostics and Tuning
>   =======================
>   
> +Debugging AMD P-State Driver Loading Issues
> +------------------------------------------
> +
> +On some platforms, there may be issues with the loading of the amd-pstate driver.

This makes it sound like it's by design.  Of course it isn't by design, 
so I would instead say:

"If the amd-pstate driver fails to load, additional debug information 
may be necessary."

> +To capture debug messages for issue analysis, users can add below parameter,
> +"amd_pstate.dyndbg=+p cppc_acpi.dyndbg=+p debug"
> +to the kernel command line. This will enable dynamic debugging and allow better
> +analysis and troubleshooting of the driver loading process.
> +
> +Please note that adding this parameter will only enable debug logging during the
> +driver loading phase and may affect system behavior. Use this option with caution
> +and only for debugging purposes.
> +
>   Trace Events
>   --------------
>