Received-SPF: pass (google.com: domain of linux-kernel+bounces-210517-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <aecb3986-aa2e-4725-b08b-473b35ca8221@amd.com>
Date: Tue, 11 Jun 2024 14:35:23 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 10/10] cpufreq: amd-pstate: automatically load pstate
 driver by default
To: Perry Yuan <perry.yuan@amd.com>, gautham.shenoy@amd.com
Cc: rafael.j.wysocki@intel.com, viresh.kumar@linaro.org, Ray.Huang@amd.com,
 Borislav.Petkov@amd.com, Alexander.Deucher@amd.com, Xinmei.Huang@amd.com,
 Xiaojian.Du@amd.com, Li.Meng@amd.com, linux-pm@vger.kernel.org,
 linux-kernel@vger.kernel.org
References: <cover.1718095377.git.perry.yuan@amd.com>
 <39b55abeb278d9ae1688c0b87cb7ec8a3e37932a.1718095377.git.perry.yuan@amd.com>
Content-Language: en-US
From: Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <39b55abeb278d9ae1688c0b87cb7ec8a3e37932a.1718095377.git.perry.yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?L0tCWnhrUlRyVldEaGs4OHBLNU13a0QrVi9zWDltbzB6SW5ISUxFRms0ME50?=
 =?utf-8?B?VzFOMUN5OG5heWpCSWRpMnpXRmE5aW4xbjlMNzBaSE9wMVZucnh4S29PR0Ey?=
 =?utf-8?B?Njd3MDNtcWU5OXF1dW8zSUt3YUhGcUJNWk85NFpBYy9KRld2alo3ZGJDWmFK?=
 =?utf-8?B?enNwZituclhaNEhGUm9mUE1zL1VoYkx2YkJTOVJRWWptUnltOVVWZVBSOFhB?=
 =?utf-8?B?MEcxR2s0Snh4VlJpRHQxbVdyYmNqRmJqYUVKS0JSUlVrUXNsSkZETFhuSnF6?=
 =?utf-8?B?U2ZWSmQ5ck9ueWFQM2Z1VmlVaEZCcTZFN1d4Q1d2OWsyWXVMUDlLVnM2bU9O?=
 =?utf-8?B?dmM3NFVuaU9vK1UzYkxId3prU2pEQmZ4S3ZDOHdzZWc5TUlrWlAzV29ydyt1?=
 =?utf-8?B?dHNocy9HU05sRWx2WGpEQkhKOUQvWkpQd0FsOVlqbnk5Z1JBTnpQTVVMZUtr?=
 =?utf-8?B?d2x1U2dpek1MT1ZSRmRDbkY4WDdpWTEvSW5NbHJLNDk1dm9ZQ2c5aHZqOU1r?=
 =?utf-8?B?blBqME5va2RScVhFK1FYYkFmVXowNU0ra2tpNnRBR2tQRmd1cU5BSlpvL2xo?=
 =?utf-8?B?ZFFOR3c5b3FsbXFOY0xxVDVsZ3BWV2ZtaFpTbVJuelgrcmtPYmFHYU80ZkVk?=
 =?utf-8?B?czB6Qk8yeHAyVFZRL2x6OHZIUmRHTXlaa1pEMlA0SVR2ZnQzWUpPVENJKzF3?=
 =?utf-8?B?WmFlQ3pEd2Q2VjlRMWxzQ0Z1S0svcTU3U205UlZyaGgvcGxKdmFSb0R1N0VU?=
 =?utf-8?B?bktBSUs3aGU0WWlwYjBic2JYM2NEYXErZWtuZWJ2RHlWTlc1RTJMWnNKeEJD?=
 =?utf-8?B?N2FtWWlpeER2Umd6N1hMTC91NVdnR3hZTmdyWWxKbVdYeXZKb2JFOWJjSitp?=
 =?utf-8?B?MUdxZmRvZGk5YmpLbWNheUlwYmpPalZnUDNXeGtLanhEN20vdnhySk02UU1l?=
 =?utf-8?B?YlVmOWZsdFhiczJqNlN3MzdORzBwL2w0VXFEQTlZbThSWWwwNlZ1M2xFYzlX?=
 =?utf-8?B?MW95SnVhOTZVTGlidmp1QkYwNy8zckl5emJYbWk1QzhHL2RSUEszRkppN3c1?=
 =?utf-8?B?anY1azBtR0V4V3N1S0tKeUNmWWZvOGNGNnYrZVhBMVZ0dmlVYlBzVk16VzF5?=
 =?utf-8?B?WE5WWUZqbFNJaWllMzZZbEt6ZUZ2cFJ5ZVhNbnVJNlRJZWExRERoOU1lbVJs?=
 =?utf-8?B?Z3ZUUWNiUFZISXVCN3k1M21rSnRPSE4xZlZRbDhoVXF5ekNJUFE4MjB4eDRI?=
 =?utf-8?B?b24yMWNqeHdZdi95YXV0aHFiTGppRHk4c0o2MHU3M3R1ZHhNNmdNV2NUMjd4?=
 =?utf-8?B?eWFHMHFQeDJzdnNQOVQ2WlFoVi9veDFaRkhBSjF3UEl6NVhRNkF5UUlKaytL?=
 =?utf-8?B?Q2cvRkhNLzF0bWhZd3RrRC9qY3UwajhvcmNLeTFCOGpOZlowamMrK2RvdXpq?=
 =?utf-8?B?bDFTUDVPR2pZemJnaWY0UnNtNWduZk81VkYzRWUxZU15Q1pVUFA3b09ObHVB?=
 =?utf-8?B?ZVNRTE1GdFNiaU5mY2owUTFyNzh3cStHOTlUVTRnZG5kbStVYnFDNWZ5Q0Jr?=
 =?utf-8?B?WGxhWXZ4NDl6WXhUZjJQMDRCWEJIL29BOHI1SXVWdURVM21ZUGFmendmanBP?=
 =?utf-8?B?anJhTDFSQWsvaXJpSUtKem8zQnFuK1cvRnRBanV3SndoMEFvbTF2anJwZWt4?=
 =?utf-8?B?ZlBLZ2dZcUw2L2IzblFXNUFFdUQvOXB3MnIvcllLZzQveFF5U0hEK2xYeUF3?=
 =?utf-8?B?SUZCSXRSdDdGS29HNExuamJ2QStnSzBEYXpiQzVhWmIrTVB3aFVOR20vL0Zl?=
 =?utf-8?B?ZnlGamNicTI5UUFNRCs2US8rZkhsSWxxVmxsYndtRlpZcmVoUjMzUHpaUzZr?=
 =?utf-8?B?byt5REkwT0hOcXgyZjFMY0dhbzk4cjFPVUJ3M09NK3FKbXR6dDFQcDZQSlBG?=
 =?utf-8?B?cER4aDdGdUMxTFBJWlUrN2ZIeDFTbGdNN0swSm1aenhrUVk0TFhBbmtLdnR0?=
 =?utf-8?B?MmQ3WVNWTGpWVkIxUDBNVzVCOFlFMGxaeXo4Wk9aajlHV1l3U3ZLbkJvMGQ5?=
 =?utf-8?B?cm41dG9tVVErMWhjTS80TGY2bXdJSEtGRFMzaWpvZDhrQ09ZcGZiQW96dFUy?=
 =?utf-8?Q?Auc+GU4FoAigPXK6NIdqBIjSI?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cf86133-680f-4ad7-5b28-08dc8a4da55b
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2024 19:35:27.2558
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /InDlVu+A+7vndS1LV65zu+2aEF5Tpy3oxAVCFePVWQJ3dIGGEr9MuW1pD2uc3rX4NeUkeKCazS/sOL668fktA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6311

On 6/11/2024 03:52, Perry Yuan wrote:
> If the `amd-pstate` driver is not loaded automatically by default,
> it is because the kernel command line parameter has not been added.
> To resolve this issue, it is necessary to call the `amd_pstate_set_driver()`
> function to enable the desired mode (passive/active/guided) before registering
> the driver instance.
> This ensures that the driver is loaded correctly without relying on the kernel
> command line parameter.
> 
> Meanwhle, user can add driver mode in command line which will override
> the kernel config default option.
> 
> [    0.917789] usb usb6: Manufacturer: Linux 6.9.0-rc6-amd-pstate-new-fix-v1 xhci-hcd
> [    0.982579] amd_pstate: failed to register with return -22

This is currently "intended" behavior.  There is a comment remaining in 
the driver at the moment not part of this patch:

/*
  * TODO: We need more time to fine tune processors with shared memory 
solution
  * with community together.
  *
  * There are some performance drops on the CPU benchmarks which reports 
from
  * Suse. We are co-working with them to fine tune the shared memory 
solution. So
  * we disable it by default to go acpi-cpufreq on these processors and 
add a
  * module parameter to be able to enable it manually for debugging.
  */

Would you say that the performance drops are worked out on the shared 
memory designs?

* If so; this comment should be dropped too in this patch.
* If not; this patch really shouldn't be done as is.

> 
> Reported-by: Andrei Amuraritei <andamu@posteo.net>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218705
> Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> ---
>   drivers/cpufreq/amd-pstate.c | 27 ++++++++++++++++++---------
>   1 file changed, 18 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index fa486dfaa7e8..6e5c398810bf 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1841,28 +1841,37 @@ static int __init amd_pstate_init(void)
>   	/* check if this machine need CPPC quirks */
>   	dmi_check_system(amd_pstate_quirks_table);
>   
> -	switch (cppc_state) {
> -	case AMD_PSTATE_UNDEFINED:
> +	/*
> +	 * get driver mode for loading from command line choice or kernel config
> +	 * cppc_state will be AMD_PSTATE_UNDEFINED if no command line input
> +	 * command line choice will override the kconfig option
> +	 */
> +	if (cppc_state == AMD_PSTATE_UNDEFINED) {
> +		pr_err("pyuan cppc_state == AMD_PSTATE_UNDEFINED \n");

Looks like a debug line escaped into the patch.

>   		/* Disable on the following configs by default:
>   		 * 1. Undefined platforms
>   		 * 2. Server platforms
>   		 * 3. Shared memory designs
>   		 */
>   		if (amd_pstate_acpi_pm_profile_undefined() ||
> -		    amd_pstate_acpi_pm_profile_server() ||
> -		    !cpu_feature_enabled(X86_FEATURE_CPPC)) {
> +		    amd_pstate_acpi_pm_profile_server()) {
>   			pr_info("driver load is disabled, boot with specific mode to enable this\n");
>   			return -ENODEV;
>   		}
> -		ret = amd_pstate_set_driver(CONFIG_X86_AMD_PSTATE_DEFAULT_MODE);
> -		if (ret)
> -			return ret;
> -		break;
> +		/* get driver mode from kernel config option [1:4] */
> +		cppc_state = CONFIG_X86_AMD_PSTATE_DEFAULT_MODE;
> +	}
> +
> +	switch (cppc_state) {
>   	case AMD_PSTATE_DISABLE:
> +		pr_info("driver load is disabled, boot with specific mode to enable this\n");
>   		return -ENODEV;
>   	case AMD_PSTATE_PASSIVE:
>   	case AMD_PSTATE_ACTIVE:
>   	case AMD_PSTATE_GUIDED:
> +		ret = amd_pstate_set_driver(cppc_state);
> +		if (ret)
> +			return ret;
>   		break;
>   	default:
>   		return -EINVAL;
> @@ -1883,7 +1892,7 @@ static int __init amd_pstate_init(void)
>   	/* enable amd pstate feature */
>   	ret = amd_pstate_enable(true);
>   	if (ret) {
> -		pr_err("failed to enable with return %d\n", ret);
> +		pr_err("failed to enable driver mode(%d)\n", cppc_state);
>   		return ret;
>   	}
>