Received-SPF: pass (google.com: domain of linux-kernel+bounces-210570-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 11 Jun 2024 22:19:02 +0200 (CEST)
From: Richard Weinberger <richard@nod.at>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Christian Brauner <brauner@kernel.org>, Hongbo Li <lihongbo22@huawei.com>, 
	anton ivanov <anton.ivanov@cambridgegreys.com>, 
	Johannes Berg <johannes@sipsolutions.net>, 
	linux-um <linux-um@lists.infradead.org>, 
	linux-kernel <linux-kernel@vger.kernel.org>
Message-ID: <2144113714.220205.1718137142446.JavaMail.zimbra@nod.at>
In-Reply-To: <20240611-hostfs-fix-mount-api-conversion-v1-1-ef75bbc77f44@kernel.org>
References: <20240611-hostfs-fix-mount-api-conversion-v1-1-ef75bbc77f44@kernel.org>
Subject: Re: [PATCH] hostfs: Add const qualifier to host_root in
 hostfs_fill_super()
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Thread-Topic: hostfs: Add const qualifier to host_root in hostfs_fill_super()
Thread-Index: y+ZRrqRbHMaINlAXXO3Imv4O2bKOCA==

----- Urspr=C3=BCngliche Mail -----
> Von: "Nathan Chancellor" <nathan@kernel.org>
> An: "Christian Brauner" <brauner@kernel.org>
> CC: "Hongbo Li" <lihongbo22@huawei.com>, "richard" <richard@nod.at>, "ant=
on ivanov" <anton.ivanov@cambridgegreys.com>,
> "Johannes Berg" <johannes@sipsolutions.net>, "linux-um" <linux-um@lists.i=
nfradead.org>, "linux-kernel"
> <linux-kernel@vger.kernel.org>, "Nathan Chancellor" <nathan@kernel.org>
> Gesendet: Dienstag, 11. Juni 2024 21:58:41
> Betreff: [PATCH] hostfs: Add const qualifier to host_root in hostfs_fill_=
super()

> After the recent conversion to the new mount API, there is a warning
> when building hostfs (which may be upgraded to an error via
> CONFIG_WERROR=3Dy):
>=20
>  fs/hostfs/hostfs_kern.c: In function 'hostfs_fill_super':
>  fs/hostfs/hostfs_kern.c:942:27: warning: initialization discards 'const'
>  qualifier from pointer target type [-Wdiscarded-qualifiers]
>    942 |         char *host_root =3D fc->source;
>        |                           ^~
>=20
> Add the 'const' qualifier, as host_root will not be modified after its
> assignment. Move the assignment to keep the existing reverse Christmas
> tree order intact.
>=20
> Fixes: cd140ce9f611 ("hostfs: convert hostfs to use the new mount API")
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>

Acked-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard