Received-SPF: pass (google.com: domain of linux-kernel+bounces-210574-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240608193504.429644-2-torvalds@linux-foundation.org>
 <20240610104352.GT8774@noisy.programming.kicks-ass.net> <f967d835-d26e-47af-af35-c3c79746f7d9@rasmusvillemoes.dk>
 <8eb5960f-17f9-4d94-9b52-dea8b475e9dc@zytor.com> <BFD0AF77-C95E-4B8B-B475-DCBD808CA5C0@zytor.com>
In-Reply-To: <BFD0AF77-C95E-4B8B-B475-DCBD808CA5C0@zytor.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue, 11 Jun 2024 13:26:39 -0700
Message-ID: <CAHk-=wj+1kOrg3H7wDBEVG2nw2xeB0F_YBqrw=bMBo0nRNtCKw@mail.gmail.com>
Subject: Re: [PATCH] x86: add 'runtime constant' infrastructure
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>, Peter Zijlstra <peterz@infradead.org>, 
	Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>, Thomas Gleixner <tglx@linutronix.de>, 
	Josh Poimboeuf <jpoimboe@kernel.org>, 
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "the arch/x86 maintainers" <x86@kernel.org>, 
	linux-arch <linux-arch@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"

On Tue, 11 Jun 2024 at 13:16, H. Peter Anvin <hpa@zytor.com> wrote:
>
> I just had an idea how to clearly make this type-safe as a benefit.

You mean exactly like my patch already is, because I use the section name?

Christ people. I am throwing down the gauntlet: if you can't make a
patch that actually *improves* on what I already posted, don't even
bother.

The whole "it doesn't scale" is crazy talk. We don't want hundreds -
much less thousands - of these things. Using one named section for
each individual constant is a *good* thing.

So really: take a good hard look at that final

  [PATCH 3/7] x86: add 'runtime constant' support

at

  https://lore.kernel.org/lkml/20240610204821.230388-4-torvalds@linux-foundation.org/

and only if you can *improve* on it by making it smaller or somehow
actually better.

Seriously. There's one line in that patch that really says it all:

 2 files changed, 64 insertions(+)

and that's with basically optimal code generation. Improve on *THAT*.

No more of this pointless bikeshedding with arguments that make no
actual technical sense.

             Linus