Received-SPF: pass (google.com: domain of linux-kernel+bounces-209910-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 11 Jun 2024 13:11:18 +0000
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sylvain Petinot <sylvain.petinot@foss.st.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] media: vgxy61: Add MODULE_ALIAS()
Message-ID: <ZmhM9mAcQqMGKnzw@kekkonen.localdomain>
References: <20240610150815.228790-1-benjamin.mugnier@foss.st.com>
 <20240610150815.228790-4-benjamin.mugnier@foss.st.com>
 <ZmgI8nET4sdhdwQx@kekkonen.localdomain>
 <76fd2e25-3a9c-49fa-994f-6a392e42a6bb@foss.st.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <76fd2e25-3a9c-49fa-994f-6a392e42a6bb@foss.st.com>

Hi Benjamin,

On Tue, Jun 11, 2024 at 01:57:24PM +0200, Benjamin Mugnier wrote:
> Hi Sakari,
> 
> On 6/11/24 10:21, Sakari Ailus wrote:
> > Hi Benjamin,
> > 
> > On Mon, Jun 10, 2024 at 05:08:15PM +0200, Benjamin Mugnier wrote:
> >> Preserve user space retro compatibility after the device rename.
> >>
> >> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> >> ---
> >>  drivers/media/i2c/vgxy61.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
> >> index ca3b43608dad..c85f356946ca 100644
> >> --- a/drivers/media/i2c/vgxy61.c
> >> +++ b/drivers/media/i2c/vgxy61.c
> >> @@ -1898,3 +1898,4 @@ MODULE_AUTHOR("Mickael Guene <mickael.guene@st.com>");
> >>  MODULE_AUTHOR("Sylvain Petinot <sylvain.petinot@foss.st.com>");
> >>  MODULE_DESCRIPTION("VGXY61 camera subdev driver");
> >>  MODULE_LICENSE("GPL");
> >> +MODULE_ALIAS("platform:st-vgxy61");
> > 
> > Perhaps just "st-vgxy61" so that the module still loads if someone loads it
> > explicitly? That's what you'd want, right, as the old compatible string
> > will remain?
> > 
> 
> Yes it is for explicit loading. I'll remove the "platform" prefix.
> 
> But maybe I'm overthinking and I could just remove the MODULE_ALIAS()
> completely from this series. What do you think ?

Most of the time the modules are loaded based on devices found, so this
would likely not change things much.

Up to you.

-- 
Kind regards,

Sakari Ailus