Received-SPF: pass (google.com: domain of linux-kernel+bounces-210736-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <73d2167a-84ee-40a4-a68d-ba25229ff8ce@gmail.com>
Date: Wed, 12 Jun 2024 08:43:54 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] tty: serial: ma35d1: Add a NULL check for of_node
To: Greg KH <gregkh@linuxfoundation.org>
Cc: dan.carpenter@linaro.org, jirislaby@kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 linux-serial@vger.kernel.org, Jacky Huang <ychuang3@nuvoton.com>
References: <20240611092251.159149-1-ychuang570808@gmail.com>
 <2024061118-sycamore-leggings-05a9@gregkh>
Content-Language: en-US
From: Jacky Huang <ychuang570808@gmail.com>
In-Reply-To: <2024061118-sycamore-leggings-05a9@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Dear Greg,


On 2024/6/11 下午 07:11, Greg KH wrote:
> On Tue, Jun 11, 2024 at 09:22:51AM +0000, Jacky Huang wrote:
>> From: Jacky Huang <ychuang3@nuvoton.com>
>>
>> The pdev->dev.of_node can be NULL if the "serial" node is absent.
>> Add a NULL check to return an error in such cases.
>>
>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
>> ---
>>   drivers/tty/serial/ma35d1_serial.c | 13 +++++++------
>>   1 file changed, 7 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c
>> index 19f0a305cc43..3b4206e815fe 100644
>> --- a/drivers/tty/serial/ma35d1_serial.c
>> +++ b/drivers/tty/serial/ma35d1_serial.c
>> @@ -688,12 +688,13 @@ static int ma35d1serial_probe(struct platform_device *pdev)
>>   	struct uart_ma35d1_port *up;
>>   	int ret = 0;
>>   
>> -	if (pdev->dev.of_node) {
>> -		ret = of_alias_get_id(pdev->dev.of_node, "serial");
>> -		if (ret < 0) {
>> -			dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret);
>> -			return ret;
>> -		}
>> +	if (!pdev->dev.of_node)
>> +		return -ENODEV;
>> +
>> +	ret = of_alias_get_id(pdev->dev.of_node, "serial");
>> +	if (ret < 0) {
>> +		dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret);
>> +		return ret;
>>   	}
>>   	up = &ma35d1serial_ports[ret];
>>   	up->port.line = ret;
> What commit id does this fix?
>
> thanks,
>
> greg k-h

This patch fix the in tree ma35d1 serial driver.
The last commit for ma35d1_serial.c is 
'6b64f8e360c00f180cffa1806095cdd2abc55b16'.


Best Regards,
Jacky Huang