Received-SPF: pass (google.com: domain of linux-kernel+bounces-210793-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Minda Chen <minda.chen@starfivetech.com>
To: Conor Dooley <conor@kernel.org>
CC: Rob Herring <robh+dt@kernel.org>, Emil Renner Berthing
	<emil.renner.berthing@canonical.com>, Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-riscv@lists.infradead.org"
	<linux-riscv@lists.infradead.org>, Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>
Subject: Re : [PATCH v1] riscv: dts: starfive: add PCIe dts configuration for
 JH7110
Thread-Topic: [PATCH v1] riscv: dts: starfive: add PCIe dts configuration for
 JH7110
Thread-Index: AQHau6H4HWcv0PbsKE2MIzy9iFiWZbHCwFiAgACdwFA=
Date: Wed, 12 Jun 2024 01:48:55 +0000
Message-ID:
 <SHXPR01MB0863CFE4519C0D69E961620CE6C02@SHXPR01MB0863.CHNPR01.prod.partner.outlook.cn>
References: <20240611015200.40996-1-minda.chen@starfivetech.com>
 <20240611-irk-hypocrite-a53e98e6c394@spud>
In-Reply-To: <20240611-irk-hypocrite-a53e98e6c394@spud>
Accept-Language: en-US
Content-Language: zh-CN
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?uPTxhKZcb92yYp2X/PvHQg9a06W1gfTstFujzB/G7KcYM+ThmZ9eRIl37wNZ?=
 =?us-ascii?Q?LiiOH3gU4i3IBgIv1BjWn/0QNdMPKXcz6gsll0z1Jd1LjIU7cmH3936jej7Q?=
 =?us-ascii?Q?DJkKfPfe7bm9y9lU/5tPdMjKJignka+cZlWvJCdp/rLYWgOlVqGyBrMkHEnu?=
 =?us-ascii?Q?At0zOUnVR1nCPzJvY4CDKUG/nlSBg8cwKkaXFtshbVo+74WRisLNJOOsuj0O?=
 =?us-ascii?Q?vnT0mG9D1D1LmW1+3kR0TwYzHNftj/XxnVYbC4dCugvpmcdnKaLPnvEi2XHz?=
 =?us-ascii?Q?dew7r5v6QiicTl3SCU9JomGd/0f5biXaFYFDTNm2Do9o7eAaZJKYygvOzT9G?=
 =?us-ascii?Q?MNaSFtUcYFgPRNP8UBBqWXM3cGN/nluRPLphXN7hTyayVtZCjqamUYaLiDG2?=
 =?us-ascii?Q?U0ZJ2kOrh4niUA5t/fSVMVd+ivsl9sSWXgtec/aMI7otU8e7Yh/v/pAHTKZE?=
 =?us-ascii?Q?6i2PC9dTzsG+CZrpjVYoIf9kDy7lPwxY5DXt+jm0VAVTVHA69h0gGWPwYZFa?=
 =?us-ascii?Q?wDf9+cnMowuDPIkGb9kcYA0XhjV4RHU2xVbbwPwar0edEJXceJ3pAwwb9/L6?=
 =?us-ascii?Q?qLh3JaguuIsM8FlD657iPna2UNZWyUPZqSQBy/HAMUF3xse90MtlEII6wzRh?=
 =?us-ascii?Q?CA9DOtXrKT74pN7vaIVakezdCq8coHxXJr50MocX6QF3wHGZsxr23a+pKEpv?=
 =?us-ascii?Q?V4NVL+s4s/IBmZBEwha3R/koboIq2HbSONTDIu+maGkTkcEtNqdWofCwfQkL?=
 =?us-ascii?Q?XFmIBzU82HupWOBkFmsx50Ko0bAom1QYb3moymxMYrXa2ieeoCPyzfEas4Yp?=
 =?us-ascii?Q?pkNajMrFKU1zNFEiuSe+atfTPt1oWZQN3kvIzJQS6Tosw4nlZDaRbWI1pkR0?=
 =?us-ascii?Q?IYwEi9BZa7gyr4vLqqLWGv/OI18Rf/HbZTwvqv5EKliHe891+KpCyj+yaac/?=
 =?us-ascii?Q?g9jp2tBK5wO+6e0PAxqj3hplWp7N3nYCmAWtnACVJMAHbGyM/ZTb9JT86diw?=
 =?us-ascii?Q?/VYrfgAuWkGpeJqRG6rmPFOV1QM7qooZgLLwN99fHqN6/j7TKjtJ4psNI5k9?=
 =?us-ascii?Q?+C52PPb89E/tSKkp69rHnKiaFgyV08fii8eRghd0tNZI1Ueg6t30VG2le0LN?=
 =?us-ascii?Q?W3wLGqc+W5XC1L/RiFO+NrCxLVZqBfT/4pm3TNE4lrSGUcXjYcVzphEOJDQW?=
 =?us-ascii?Q?+vxNtIgndyRj+05hIRdC/BacZi6C3IGcQs9NiU93w38gJMHfXU8VAFcZb2Fj?=
 =?us-ascii?Q?3KqB7zhOuxsfSLCylVfsNduLxXbGIgDnb8jLr8Mh173A5INz4wgKG8cYLu5H?=
 =?us-ascii?Q?zmCgmK8YRsyqfTaW8cHkBjwKyFzJbNNgY/tHMLeOi+exEolXbkczsi/mvMoq?=
 =?us-ascii?Q?PeFZ/x9o+epaprCUrySRMk2/ykJQmvjhewVlSc/Z3gWY8daOCB+KOJVpJDcy?=
 =?us-ascii?Q?EOSQDEGCZ36ITnnIyg8nvQMlzLDzSLQaDhwmP6bsDyh+bKGkzL8s1wql4/D8?=
 =?us-ascii?Q?aQm1wshAwXjwmMUg0iV045ucdHMYeQvPpHbpoLiLUJvyKOJyQ92/tWb0nLcC?=
 =?us-ascii?Q?z2o9xP3/fLwhZU1l/88rjsL2odRF+aW6xQCYpbzv?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: starfivetech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SHXPR01MB0863.CHNPR01.prod.partner.outlook.cn
X-MS-Exchange-CrossTenant-Network-Message-Id: b5943f68-2ab4-4e3b-e675-08dc8a81d18c
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2024 01:48:55.0702
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 06fe3fa3-1221-43d3-861b-5a4ee687a85c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Q57qnS4Gbh4lXzHTRoobpnCCGKxDl7DEzUIEzCQB+tJ2GwUWw5J9FfnX5NlyaxcPXOLxDpQfzk5BIYEBJLoZ4BduDUEXBBlOuHiEELCwyGc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SHXPR01MB0831


>=20
> On Tue, Jun 11, 2024 at 09:52:00AM +0800, Minda Chen wrote:
> > Add PCIe dts configuraion for JH7110 SoC platform.
> >
> > Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
> > Reviewed-by: Hal Feng <hal.feng@starfivetech.com>
> > ---
> >  .../boot/dts/starfive/jh7110-common.dtsi      | 64 ++++++++++++++
> >  arch/riscv/boot/dts/starfive/jh7110.dtsi      | 86 +++++++++++++++++++
> >  2 files changed, 150 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> > b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> > index 8ff6ea64f048..1da7379f4e08 100644
> > --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> > +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> > @@ -294,6 +294,22 @@
> >  	status =3D "okay";
> >  };
> >
> > +&pcie0 {
> > +	perst-gpios =3D <&sysgpio 26 GPIO_ACTIVE_LOW>;
> > +	phys =3D <&pciephy0>;
> > +	pinctrl-names =3D "default";
> > +	pinctrl-0 =3D <&pcie0_pins>;
> > +	status =3D "okay";
> > +};
> > +
> > +&pcie1 {
> > +	perst-gpios =3D <&sysgpio 28 GPIO_ACTIVE_LOW>;
> > +	phys =3D <&pciephy1>;
> > +	pinctrl-names =3D "default";
> > +	pinctrl-0 =3D <&pcie1_pins>;
> > +	status =3D "okay";
> > +};
>=20
> Do all 3 of the mars, star64 and visionfive 2 have both PCIe ports expose=
d? I
> assume if one does, all does, since they're basically identical?

Visionfive 2 and milkv mars are all the same. Star64 do NOT enable PCIe0, P=
CIe1 pins are the same.