Received-SPF: pass (google.com: domain of linux-kernel+bounces-210840-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID:
 <OS3P286MB249073C57E2B5A36F45A02E0B1C02@OS3P286MB2490.JPNP286.PROD.OUTLOOK.COM>
Date: Wed, 12 Jun 2024 10:52:35 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] cpufreq/cppc: Remove the desired_perf compare when set
 target
To: Viresh Kumar <viresh.kumar@linaro.org>,
 Ionela Voinescu <ionela.voinescu@arm.com>
Cc: beata.michalska@arm.com, rafael@kernel.org, linux-pm@vger.kernel.org,
 linux-kernel@vger.kernel.org, hotran@apm.com, Riwen Lu <luriwen@kylinos.cn>
References: <20240530061621.36byo5a2iqc6o2az@vireshk-i7>
 <OS3P286MB249076187B3497D1EDD70988B1F32@OS3P286MB2490.JPNP286.PROD.OUTLOOK.COM>
 <20240606090737.z3qenphikjs5ijj4@vireshk-i7> <ZmgQ06jtJBPh5wat@arm.com>
 <20240611091049.lrypvvluntf37uff@vireshk-i7>
Content-Language: en-US
From: Riwen Lu <luriwen@hotmail.com>
In-Reply-To: <20240611091049.lrypvvluntf37uff@vireshk-i7>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: OS3P286MB2490:EE_|OSZP286MB1485:EE_
X-MS-Office365-Filtering-Correlation-Id: 35143306-7307-42ba-7749-08dc8a8abb64
X-Microsoft-Antispam: BCL:0;ARA:14566002|461199020|440099020|3412199017;
X-Microsoft-Antispam-Message-Info:
	QwlrkyzcTYr0CFXW+vmL8VcZxvzgjYmADSfRqyGjBnbwxFYOs5pG875rDWXPydbqlbN64QXl0JtYSA7JOGUwMEGOsoHJJU50f4wJUQSAfXsn/JqXUqOT6OmOPjI4jC0ERcF1fajUTjbEb3QhFo8uqcUfsR45tGOnbTIpJwXVhjdNt4kmB1+yaoTQT6PTlQVL9SQXPo9byJ51UQO97eufmeY9vHA3kX9HMW9vUfeG2KczJgutDXV03lF+UPhhpbSVyAhbBGxYPIlTgO4ndLvw8Et5fJ1h0/H73osRgdRNm4xpg+4EU+aTnUrtzxc+PGO2pd3Jg7RxIgJCxPI5ghchpu7RYCvVjnS/wtTueSeTgqvDWMiy8dYmwQZCaOB+5E3N+uPIByNwAquuRKJKfHg0vz+qXfoljyTh6lwplpjYOPZ1kWawlN0hnNU3QMt5TT3+I9RcoB3iciUEw46GTh5B6iLFlfnpLFzqSvSVS9ABe/gr8eYw3p/FQKe7ubsLPmpvvS66/YFeiYPqAgejpf77ox5qBidlXqqiX5hL8Tc6NVaSm1NKDKkixhwNi4J9v73JOeWN0ldEBWGIWvMxBTt6u/XFaV+lthcDWrPqUtPWW6D54WyFPopv2pyol8sazFXJWfX9EqkktBP2udq1D4Gf/VDE9OSxKmqCjex8xJ5+YJI=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ekpBbVVobTVOWTlab2ltVG42WVp5Z0E0eTdlc1QwZHc4b2ZQbkhZWG9tMUsx?=
 =?utf-8?B?UEZIY3VpeGRaNDI4a0NsbHcycDdaWWlHblFOd1RXbCtWTEFUOG8veVRpb3BP?=
 =?utf-8?B?VHhINXZ2MGlteTdGSGZpeEJYVmpkdENPRGxnaHh5RS9CcjkrQlMxSHdrOUNp?=
 =?utf-8?B?ekVRV01hWWwySksyc29RTmJZdmwzNENKY3NaNmVNcEljYW9LYjhJcVZ5b2x0?=
 =?utf-8?B?emd5c01VWE5pVzc5eFFubTRyaEpWbEJZSVZCQUlQMGo5c2plTHpkUU43Rlc2?=
 =?utf-8?B?THRZQmE0L2RXV2RjT1FNRk5MODcwM0ZyYnZMWklqSFFXUGxFLzVDb2FBeDhZ?=
 =?utf-8?B?cVlJUjFFUEQwRFFxZm5IU29OMzd0bjdNcGpFOHA3ci9wV214QWFnTjNTazFh?=
 =?utf-8?B?MWNad0dOZ1VyMjh1Q0orcko1dFMvN1Y0Q0JtYkhqV0ZjcEFrWmIvLzFXUmNP?=
 =?utf-8?B?TkZvM2pwdXE3VlNwVUttVEpPakhiaVhCaTAxZHVXblVOUkk2Umg0d1RVM24r?=
 =?utf-8?B?T0RraEN2UEJldnNESk01Z25JTkUxZXR3YTZHaG5sNVBHVjd0YlA0ZDREU0lY?=
 =?utf-8?B?dUFiSHRiSU9GY2k0RXZBTnp6MUhScVNhdTA1c0NEVm5LSld3Q29PK1FjZ2hC?=
 =?utf-8?B?T1g4a0FCQjE5b0NrUUo2djJoN05LWmhQTld6N1JMSEhoMjV5VG41d0UxRmlU?=
 =?utf-8?B?anBKZElLMDR0OWR0SllrMTN6Y0toVWxHNXVqWGtrOTBjSW9jeFBxUmVUR3BE?=
 =?utf-8?B?N2orc3p4R3lwaEdXY2g2S3lraDJ4M2hjT0NXUStDVkFTZnh6RCtaUnM1SStD?=
 =?utf-8?B?UnJ1dWdRa2VwbUZRV0xKOFhqVFlJMXpTWFY0bHFmaHBpS28vLy90OVRBUk9s?=
 =?utf-8?B?cDl1NzFIRFMwaTJBclE0dFUrU2tKY3ZibGZ6UlVVaEQ2dEFVU3lSWG9uQ2I2?=
 =?utf-8?B?N25oeFR5RjFBWlhyVElPbjBUTXlReEFzb0t0YUh6d2xWYTRZdEtGTGFQRnY1?=
 =?utf-8?B?WVZuT1MrTTNjSTFYK2c0SjgyQTE3RVNOczhtWnA2Z01oVmlpTnM4bTJmZkI0?=
 =?utf-8?B?d2hHZjl4cnhPc0VwOXJaSE9kRnJpdEFoOXc3QkF5anhOeVlRbmJjYjVuOUpi?=
 =?utf-8?B?dzNlZm9GZW8zaC92L3g1V3M4OVBNZitPTTNPK2VuYWNOT3NvdWJyV2p2T3Mz?=
 =?utf-8?B?ZE1ZVHlxYXZ5WGRuelpXRVZIYTVDbXB2bTRhSEFwZlJUNmVrVFJnSjZwaElM?=
 =?utf-8?B?NW9BWDlMQTRvQ09tcTBseE1LbGVRdEw2S1pYWjhpNGVQWkJrNWsvM1JJcHBY?=
 =?utf-8?B?NXlwMHFmM1lWaVN4WVVBZXlFV0JYZnI3d3pDcjJMVWFaaWQ5ZmVHWUFaNU16?=
 =?utf-8?B?TEp5NktCWEMxbkhWVVVSWStmUzlhVHYrWUVVT20yUkVTb0Rqc3FsTC9HTUl6?=
 =?utf-8?B?MHdBYi9TcUtaNlFpQ3pSd3ZJcnVqd2pKbW9HV0VqRkhmdW1aWTJPVUg3WERi?=
 =?utf-8?B?dVpqcWs2WE5rMmVUeGhvUklxODF2Sk02Tlo3UHJLakZmUlVxUnpwMmlXbVNm?=
 =?utf-8?B?Z3pLVUoxNnZpY3pxQlpsM3BQUU1tZ3B1UnIzWHllM1FTSksrUDNpNHRGdktR?=
 =?utf-8?Q?yxswDG4L0kZ1xKgVywusXxXz8kVMGnq0vqKPQKlJ8/OM=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-05f45.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 35143306-7307-42ba-7749-08dc8a8abb64
X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB2490.JPNP286.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 02:52:43.7371
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZP286MB1485

在 2024/6/11 17:10, Viresh Kumar 写道:
> On 11-06-24, 09:54, Ionela Voinescu wrote:
>> It's alright with me.
> 
> Great.
> 
>> Some "nits":
>>   - the "desired_perf" local variable could be removed in this case.
> 
> Riwen, please fix this and resend.

I think it's no need to remove the "desired_perf" local variable here, 
the code is seems more readable.
> 
>>   - [note] while this change helps, we'd still need policy->cur to always
>>     have the latest request value (see details at [1]) for this check to
>>     be made obsolete by the comparison between target_freq and policy->cur,
>>     as mentioned in the commit message. But this is/can be a separate
>>     matter.
>>
>>     [1] https://lore.kernel.org/lkml/ZmB1qKucR5fXk100@arm.com/
> 
> Yeah, lets discuss that in the other thread only.
>