Received: by 2002:ab2:6c55:0:b0:1fd:c486:4f03 with SMTP id v21csp178179lqp; Tue, 11 Jun 2024 20:00:58 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVeLQBlGgqJpiNxwmQrl+wnKOp1xmBiMHD9YnS3LohpoXZBLft2UON1IKC7P218LvChca+07ZEE+XlNXDNNMBaWco6VZIg7ekEs5NNleQ== X-Google-Smtp-Source: AGHT+IG28Pa+fWBtQ2r7s45h3wdEOja5kYP/ZN8fMKY3yUli4SeEbVjSnWVRUB8wWQeEYp+DpEL3 X-Received: by 2002:a17:906:2355:b0:a6f:4a37:5c6a with SMTP id a640c23a62f3a-a6f4a375d82mr8907666b.19.1718161258204; Tue, 11 Jun 2024 20:00:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718161258; cv=pass; d=google.com; s=arc-20160816; b=AMTTSwiZQtSdmpWCPJEjRVlUlPIWlJZRQ+bwyo6NdWKaGufSEhL4TGbbBrl0R8aOWE 0QxnZqG+gED71csC0bocHjK49VxXXrNAU7w0aF4Y+EPjMkjD4peq4kEZ7uE5MZ5u0Ku1 +/e1K3zns2zMUuX9wsG17gyKbDmtpR4bHoPvHa4j/gFQ05b1ezsch570ExgE5USWoPZ/ DXl9yNm0iTHyH9hnxyjNQvS8zUGs1ohDReZGrrjFpiuTv6ezbHuz/nmIAVHQEvn4J8yB cN3sEQhEhodv1wOsfbaIycCDZrBVwWuvCD9CwtmH8RbMepHW1zCt4l2huGgjk6y1s1Hu s9Aw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:date:message-id:from:subject :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=OrvMo0674RD2oma9PFkCvvChZaNe4sF2QirJ6zYiTdg=; fh=pbNcEjuOejqWHGL+BGiGLtkpo4lAAsGMmEI7HA8A4Cs=; b=TMchoZKRol4HjfgiyFA/VPMf+buFgZyU/0ZDkpJTNTMEw+bh8bhSVoIim+0ZocoHsi SQH+NYjH2EcbD/U50Gq5VzMiY1pPxkcNPXJnaUBT2dxHtaTkwOjxq5iJ1x3R3jQ19iRR aldocgqZLg0HOoww7iCQycr1bJeH04nCFtZqI2OtFFrxQBXSftB0OWO6J685AdhER7HN 8OyFubz6vJaL0E4r6crqdp8ogZcbl2tzaDWbijOWh6Q/DSostKoWeia2VF+SkUHwSELw 2u+vD6Fyd6JZ3O6rmXZ+GFbFCkOzGZTmzqKnjQz+KLvWYhUvzjS4rOLkv1eQM9Yy17O1 ifRQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=egd7vYH1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-210845-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210845-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a6f1f15895bsi284804666b.516.2024.06.11.20.00.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:00:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-210845-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=egd7vYH1; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-210845-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210845-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CBB1A1F239F4 for ; Wed, 12 Jun 2024 03:00:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C55B820332; Wed, 12 Jun 2024 03:00:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="egd7vYH1" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF7A3DF62; Wed, 12 Jun 2024 03:00:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718161234; cv=none; b=CJyStezkqIzkWmHb7SaSm/TVDtu9V/HnM2HMLfkxcPZH0oYUEjBORrW1Dl+E+B9Bn3rbKIobCNFxZ3zBDAP213NYlnmoaKVqNp/Dr+9d6hvSWmQOTZnJJ0JPmsYlMJjrheDDEFAUNv1iq2QD8u0zQLik+LeswZK/kh4Lchb7T30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718161234; c=relaxed/simple; bh=RUXhIiQ650W0ISBjZa4FmMnAKv75xiQwfEYjljSa7Ys=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=Xu15NcoygvclC+6cxTODXLIzzZtvu47iChHiRBe4WJwDGrUKFRDfMi7MvCpINs8Dgp5DbUrW7AgZGPlY5RG8/xYmqgec+wSS2dmNaoJ5Z+wd7q0wATQTml79n7e0hhKLioVbOt/CR4DlKy0Xla61DHttyojprwPdd19PUY5B0Q0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=egd7vYH1; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id 76F78C4AF1C; Wed, 12 Jun 2024 03:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718161233; bh=RUXhIiQ650W0ISBjZa4FmMnAKv75xiQwfEYjljSa7Ys=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=egd7vYH1h06yWv8wIa6eIzpxyiFUxxsgc0Xa6iL2sUlaK5z+aOlL3Tf6Y8oMYUD5S FyT3vKJPg/pWFid861HMka3h4RIMx/eAjWQu6dp1lg85sGWvGoazpCugjZ6cb4LzWk SwUXIVazp6Z5EpI48fh4mjpncZbgu9atizAMR5dTqZnlLBCN0ldzTAHkQii6jnye8J tu0fy2/sIjNfiJqw9ZvtzFeS/ldiqSK8WJbYHdHeB77VC3BLcO3vrw6ha/0uXWLzi0 uQvCt4Zh4/NIK2JtzeZAzqYvT1pNPU84Hfv0f2aU1DrNyaAG8Qv0B9CCtGlm8uB6yH Hk/Ec/XJtCs0A== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 55327C43614; Wed, 12 Jun 2024 03:00:33 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [net v5 PATCH] net: stmmac: replace priv->speed with the portTransmitRate from the tc-cbs parameters From: patchwork-bot+netdevbpf@kernel.org Message-Id: <171816123334.11889.9944196119101092125.git-patchwork-notify@kernel.org> Date: Wed, 12 Jun 2024 03:00:33 +0000 References: <20240608143524.2065736-1-xiaolei.wang@windriver.com> In-Reply-To: <20240608143524.2065736-1-xiaolei.wang@windriver.com> To: Xiaolei Wang Cc: olteanv@gmail.com, linux@armlinux.org.uk, andrew@lunn.ch, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, wojciech.drewek@intel.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Sat, 8 Jun 2024 22:35:24 +0800 you wrote: > The current cbs parameter depends on speed after uplinking, > which is not needed and will report a configuration error > if the port is not initially connected. The UAPI exposed by > tc-cbs requires userspace to recalculate the send slope anyway, > because the formula depends on port_transmit_rate (see man tc-cbs), > which is not an invariant from tc's perspective. Therefore, we > use offload->sendslope and offload->idleslope to derive the > original port_transmit_rate from the CBS formula. > > [...] Here is the summary with links: - [net,v5] net: stmmac: replace priv->speed with the portTransmitRate from the tc-cbs parameters https://git.kernel.org/netdev/net/c/be27b8965297 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html