Received: by 2002:ab2:6c55:0:b0:1fd:c486:4f03 with SMTP id v21csp215246lqp; Tue, 11 Jun 2024 21:48:40 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX/cxHObzZKP5ZX9Rnz9OJNp1PyzoOgGq1jIAHSJHjRJHrWDWLPpRRnncLy7wIOq/WYcLwhabDkaPsWR+As9EzzsdOKZVzwgACuXI1OYA== X-Google-Smtp-Source: AGHT+IEEsV+Pm4jTjJ+5B22a7x0yhTfj0Wm8ViXnZuA2RNNwCmEBWfplGSaoAorETjiOEExjGkr9 X-Received: by 2002:a05:620a:269a:b0:795:9eb5:c23a with SMTP id af79cd13be357-797f6128d53mr71906285a.49.1718167720120; Tue, 11 Jun 2024 21:48:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718167720; cv=pass; d=google.com; s=arc-20160816; b=I5KFBQinIYs7u2Ea0bgxDdfWcuMBTFca8QBUBP9pgxtSlzDqwY3LvluzLVX2ayxezU MBbcqu1BsyI6wEZrJFRxNMyEOuLJNA54cFP0bU3H7KHd//ANMwtqKC1rkX84N1euH4zo BWBetKSUfDC67EIYPKQ5oGw8RqR0KwXB1JgJNEm1TT35A1StDO8Toep/OocZBFymE5TD KyoWJQnp78iBeb18lZ8uDVfgBtR0Z2Y5sgH/4jjMBm/EcHkHmBndgFBeAQAab+2bnq2w grAoBJKZhSzcVeOVjCxD5Qy29JpzdHw2NRM96X9nEZyeFPW7ZWPN4EuFMdEXEPrM/rA0 uanw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=1qYwyTzuhCwYdAhfUrXP4v1Mpi8PB2fy3oQFcPcQ+CI=; fh=i9JN79d6Q5hGQLhDNn1fdj0cMTNhD/z8nCpxBSu1PCg=; b=Yv+w9ZekAOFfUyMYu3Dtt+KjDGF188wwaXTnXDY/ldHpXMxVSR1IuKik3pHR32HbQ3 lEMw6J5/S46/nZ4Wek/fOwT14kZO1gf7kJnub2P3J0TY6gJxHPY3dq/60ChzU/wurzkP q7eJr2Nz0c+A1Sr12ZGlsF8R1waJjGTfe5oIumKF8boUcVoR2U97W76KumClSHfwSLnb qvDY4ve68pj92g1P/y7NchxMMgCpIW5dEDJh1xe+c8ZH+ilEY+i/4jb3uzrBNSDYh934 O+zE01/1LIgrMtzILOApL7WkSpCbkb7krE3klHYaHGdhNsp+ydpdP6iHjbdnfKPNQeNx Sxwg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=YjsDia+M; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-210921-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210921-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id af79cd13be357-7955a74f55csi860593785a.105.2024.06.11.21.48.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 21:48:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-210921-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=YjsDia+M; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-210921-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210921-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 64C711C23A5F for ; Wed, 12 Jun 2024 04:48:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DFF6928DD1; Wed, 12 Jun 2024 04:48:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YjsDia+M" Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD70C26AD0 for ; Wed, 12 Jun 2024 04:48:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718167711; cv=none; b=BbN6rxbDkUcEdpkToWB/F9HQ2+vmgKXefEZkXLaP5K0G5FlZkoWC3Cqft5X/7kwlBqVO27DjlWu4jO8rVm6c1pwbYVgMsYjL/sTuCN7VE3G5+RRbqYndyZfkEu3el70nw6XRWsi02hwSCMRmezc7kDdjgRBnabMeo/+f4BpS1Aw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718167711; c=relaxed/simple; bh=uN30+iX5HS6j0Alppcs0vu8flXzHQALuudsUtjcgloQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=fzUp+49ObxfJQUm1Hgsp2BkbssqYKGuNVKuutdYf/sblbb3fSoDu3hTMA+INxnfU+3EDdweodE8MI6tGafH7ZdZ8YXVUfVTo2kAVo1qgwVKL58C5FkV6rkIvGkPdvcPTkihYUM7mZ+PCVYTPKaPzUE3W17VrB01chQq4bVsO8pU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=YjsDia+M; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1f480624d0fso15449735ad.1 for ; Tue, 11 Jun 2024 21:48:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1718167708; x=1718772508; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1qYwyTzuhCwYdAhfUrXP4v1Mpi8PB2fy3oQFcPcQ+CI=; b=YjsDia+May9JSw0JF1XHBnw8i6wegczxMVo3R52euItHWCwKaj9ac41Fo1ficLCTgo 4YhnPTJFQUrUONJmqjVSXpMPrfuM8sericRU607BZX1NldQKYLBwGU32ahIJCZx/0G/L yHLcjN9jKv/ByotsDADX9vnkJsyY1rZoFTroY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718167708; x=1718772508; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1qYwyTzuhCwYdAhfUrXP4v1Mpi8PB2fy3oQFcPcQ+CI=; b=BmVlzh01h22mTbO/hJL5MGi5t1AZVk/NdEhUzyZXuhgMsAUc7TI60TPdXt8YQoWnlG xwBgB3euwVn6s4ylN+NR9zHAEf7w52TXo5aVxIB9hz8keun6nCwSywv6vsAtskqnbOjQ R5F6fJb2MFbZ9+GR1+EEdEq7xcBk8q+/gtqsbYAGzQd6b96Jncv1w5gkO0F5kEHq++0y /NlX/H52aUXxvS5zud1X3DQB9if0uIXBbNYjh46w2z8ZTAinfcOXnjBbN5eaq7cZStWs P3EhWgiByP3gKInK80+eX+UAwJpZ3uTYWbfk1kutsj8HuzKVvHaj4oWhDZxhmeEBQYUw BUTA== X-Forwarded-Encrypted: i=1; AJvYcCVv2B1zFWrqAT9EwHM14pxSPpbTQCJ9scLVL/wVDwbXDk4A2ndOHeb2RLn5PkhzidntagzHqlPLYpIleWnbEhmGAfFeyXy+TaCp4ARl X-Gm-Message-State: AOJu0YyXNRy6lyV41g75RjxPf8a4tgFjmppdzYucHHcO4l3CZ1HgAHw8 pFSsR4C7gO+YF9GIeBCjnyJik5kSCAVIr889MFXGp4CEZ2NMEPnBlIos8TrwVMO2guZhPaDJCXw = X-Received: by 2002:a17:902:ce8d:b0:1f6:3b15:82a0 with SMTP id d9443c01a7336-1f83b71650amr9861365ad.64.1718167707882; Tue, 11 Jun 2024 21:48:27 -0700 (PDT) Received: from rekanorman3.syd.corp.google.com ([2401:fa00:9:14:58af:8c3:44cb:ad1b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f6bd7e5cc4sm114479215ad.235.2024.06.11.21.48.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 21:48:27 -0700 (PDT) From: Reka Norman To: Mathias Nyman Cc: Reka Norman , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH] xhci: Apply XHCI_RESET_TO_DEFAULT quirk to TGL Date: Wed, 12 Jun 2024 14:47:38 +1000 Message-ID: <20240612044759.3193928-1-rekanorman@chromium.org> X-Mailer: git-send-email 2.45.2.505.gda0bf45e8d-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit TGL systems have the same issue as ADL, where a large boot firmware delay is seen if USB ports are left in U3 at shutdown. So apply the XHCI_RESET_TO_DEFAULT quirk to TGL as well. The issue it fixes is a ~20s boot time delay when booting from S5. It affects TGL devices, and TGL support was added starting from v5.3. Signed-off-by: Reka Norman --- drivers/usb/host/xhci-pci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c index c040d816e626..137bd3da1128 100644 --- a/drivers/usb/host/xhci-pci.c +++ b/drivers/usb/host/xhci-pci.c @@ -49,6 +49,7 @@ #define PCI_DEVICE_ID_INTEL_DENVERTON_XHCI 0x19d0 #define PCI_DEVICE_ID_INTEL_ICE_LAKE_XHCI 0x8a13 #define PCI_DEVICE_ID_INTEL_TIGER_LAKE_XHCI 0x9a13 +#define PCI_DEVICE_ID_INTEL_TIGER_LAKE_PCH_XHCI 0xa0ed #define PCI_DEVICE_ID_INTEL_COMET_LAKE_XHCI 0xa3af #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_PCH_XHCI 0x51ed #define PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_PCH_XHCI 0x54ed @@ -372,7 +373,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci) xhci->quirks |= XHCI_MISSING_CAS; if (pdev->vendor == PCI_VENDOR_ID_INTEL && - (pdev->device == PCI_DEVICE_ID_INTEL_ALDER_LAKE_PCH_XHCI || + (pdev->device == PCI_DEVICE_ID_INTEL_TIGER_LAKE_PCH_XHCI || + pdev->device == PCI_DEVICE_ID_INTEL_ALDER_LAKE_PCH_XHCI || pdev->device == PCI_DEVICE_ID_INTEL_ALDER_LAKE_N_PCH_XHCI)) xhci->quirks |= XHCI_RESET_TO_DEFAULT; -- 2.45.2.505.gda0bf45e8d-goog