Received-SPF: pass (google.com: domain of linux-kernel+bounces-210923-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
Mime-Version: 1.0
Subject: RE:(2) [PATCH] f2fs: fix convert inline inode on readonly mode
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From: Daejun Park <daejun7.park@samsung.com>
To: Chao Yu <chao@kernel.org>, "jaegeuk@kernel.org" <jaegeuk@kernel.org>,
	"linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
CC: Dongjin Kim <dongjin_.kim@samsung.com>, Seokhwan Kim
	<sukka.kim@samsung.com>, Yonggil Song <yonggil.song@samsung.com>, Eunhee Rho
	<eunhee83.rho@samsung.com>, Jaeyoon Choi <j_yoon.choi@samsung.com>, Nayeon
	Kim <nayeoni.kim@samsung.com>, Siwoo Jung <siu.jung@samsung.com>, Daejun
	Park <daejun7.park@samsung.com>
In-Reply-To: <dfdf7dac-90e2-4ee7-8258-ffca0c777d9e@kernel.org>
Message-ID: <20240612045001epcms2p2338ee24b2e1f107a72f274f2a88b93e7@epcms2p2>
Date: Wed, 12 Jun 2024 13:50:01 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <dfdf7dac-90e2-4ee7-8258-ffca0c777d9e@kernel.org>
	<20240612022012epcms2p77300b5130d18b0397c9fc2877704949d@epcms2p7>
	<CGME20240612022012epcms2p77300b5130d18b0397c9fc2877704949d@epcms2p2>

> On 2024/6/12 10:20, Daejun Park wrote:
> > syzbot reported a bug in f2fs_vm_page_mkwrite() which checks for
> > f2fs_has_inline_data(inode).
> > The bug was caused by f2fs_convert_inline_inode() not returning an
> > error when called on a read-only filesystem, but returning with the
> > inline attribute as set.
> > This patch fixes the problem by ensuring that f2fs_convert_inline_inode=
()
> > returns -EROFS on readonly.
> >
> > Fixes: ec2ddf499402 (=22f2fs: don't allow any writes on readonly mount=
=22)
> > Reported-by: syzbot+f195123a45ad487ca66c=40syzkaller.appspotmail.com
> > Closes: https://protect2.fireeye.com/v1/url?k=3D4fe36b34-10785251-4fe2e=
07b-000babff32e3-e4235a49bbe14a93&q=3D1&e=3Db7eda9c4-8db2-474e-801d-f3eb85d=
38066&u=3Dhttps%3A%2F%2Fsyzkaller.appspot.com%2Fbug%3Fextid%3Df195123a45ad4=
87ca66c
> > Signed-off-by: Daejun Park <daejun7.park=40samsung.com>
>=20
> Hi Daejun,
>=20
> I guess below patch has fixed this issue, so we need to tag the report
> as duplicated?
>=20
> https://lore.kernel.org/linux-f2fs-devel/20240603010745.2246488-1-chao=40=
kernel.org/T/=23u
>=20
> Thanks,

Hi Chao,

I didn't check that patch, please simply ignore it, thank you :)

Thanks,
Daejun

> > ---
> >=C2=A0=20fs/f2fs/inline.c=206=20++++--=0D=0A>=20>=C2=A0=201=20file=20cha=
nged,=204=20insertions(+),=202=20deletions(-)=0D=0A>=20>=0D=0A>=20>=20diff=
=20--git=20a/fs/f2fs/inline.c=20b/fs/f2fs/inline.c=0D=0A>=20>=20index=20763=
8d0d7b7ee..ae1d8f2d82c9=20100644=0D=0A>=20>=20---=20a/fs/f2fs/inline.c=0D=
=0A>=20>=20+++=20b/fs/f2fs/inline.c=0D=0A>=20>=20=40=40=20-203,10=20+203,12=
=20=40=40=20int=20f2fs_convert_inline_inode(struct=20inode=20*inode)=0D=0A>=
=20>=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20struct=20page=20*ipage,=20=
*page;=0D=0A>=20>=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20int=20err=20=
=3D=200;=0D=0A>=20>=0D=0A>=20>=20-=C2=A0=20=C2=A0=20=C2=A0=20if=20(=21f2fs_=
has_inline_data(inode)=0D=0A>=20>=20-=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=
=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20f2fs_hw_is_r=
eadonly(sbi)=20f2fs_readonly(sbi->sb))=0D=0A>=20>=20+=C2=A0=20=C2=A0=20=C2=
=A0=20if=20(=21f2fs_has_inline_data(inode))=0D=0A>=20>=C2=A0=20=C2=A0=20=C2=
=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20return=200;=0D=
=0A>=20>=0D=0A>=20>=20+=C2=A0=20=C2=A0=20=C2=A0=20if=20(unlikely(f2fs_hw_is=
_readonly(sbi)=20f2fs_readonly(sbi->sb)))=0D=0A>=20>=20+=C2=A0=20=C2=A0=20=
=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20return=20-EROFS;=0D=0A>=20>=20=
+=0D=0A>=20>=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20err=20=3D=20f2fs_d=
quot_initialize(inode);=0D=0A>=20>=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=
=A0=20if=20(err)=0D=0A>=20>=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=A0=20=C2=
=A0=20=C2=A0=20=C2=A0=20=C2=A0=20return=20err;=0D=0A>=20>=20--=0D=0A>=20>=
=202.25.1=0D=0A>=20>