Received-SPF: pass (google.com: domain of linux-kernel+bounces-210944-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <cc4553df-af5d-4c9f-8b0a-ed35e1cb36fb@ti.com>
Date: Wed, 12 Jun 2024 10:51:55 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [v4,1/2] drm/bridge: sii902x: Fix mode_valid hook
To: Sui Jingfeng <sui.jingfeng@linux.dev>, Sam Ravnborg <sam@ravnborg.org>
CC: <linux-kernel@vger.kernel.org>, <dmitry.baryshkov@linaro.org>,
        <andrzej.hajda@intel.com>, <neil.armstrong@linaro.org>,
        <rfoss@kernel.org>, <Laurent.pinchart@ideasonboard.com>,
        <mripard@kernel.org>, <jonas@kwiboo.se>, <jernej.skrabec@gmail.com>,
        <maarten.lankhorst@linux.intel.com>, <tzimmermann@suse.de>,
        <airlied@gmail.com>, <daniel@ffwll.ch>, <a-bhatia1@ti.com>,
        <dri-devel@lists.freedesktop.org>
References: <20240530092930.434026-2-j-choudhary@ti.com>
 <e5ce13e6-1007-41c9-bedc-2045d6f75480@linux.dev>
 <20240531133324.GA1715839@ravnborg.org>
 <955a6d94-9a4c-4f7d-974c-819261579f14@linux.dev>
Content-Language: en-US
From: Jayesh Choudhary <j-choudhary@ti.com>
In-Reply-To: <955a6d94-9a4c-4f7d-974c-819261579f14@linux.dev>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit

Hello Sui, Sam!

Thanks for the review.

(Sorry for delayed response. I was OoO last week)

On 31/05/24 19:34, Sui Jingfeng wrote:
> Hi, Jayesh
> 
> 
> On 5/31/24 21:33, Sam Ravnborg wrote:
>> Hi Jayesh,
>>
>>>> +
>>>>    static const struct drm_bridge_funcs sii902x_bridge_funcs = {
>>>>        .attach = sii902x_bridge_attach,
>>>>        .mode_set = sii902x_bridge_mode_set,
>>>> @@ -516,6 +529,7 @@ static const struct drm_bridge_funcs 
>>>> sii902x_bridge_funcs = {
>>>>        .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
>>>>        .atomic_get_input_bus_fmts = 
>>>> sii902x_bridge_atomic_get_input_bus_fmts,
>>>>        .atomic_check = sii902x_bridge_atomic_check,
>>>> +    .mode_valid = sii902x_bridge_mode_valid,
>>
>> As you have the possibility to test the driver, it would be nice with a
>> follow-up patch that replaces the use of enable() / disable() with the
>> atomic counterparts.
>>
>> enable() / disable() are deprecated, so it is nice to reduce their use.
> 
> I agree with Sam.
> 
> Please using atomic uniformally with a follow-up patch, the mixed
> using of atomic API and non atomic API is a little bit confusing IMO.
> 
> 

I will change the enable and disable to their atomic counter parts in 
the next revision.

Warm Regards,
-Jayesh