Received-SPF: pass (google.com: domain of linux-kernel+bounces-210951-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <fcf77c98-0ee5-45ce-a17f-d68dfba9f7ee@gmail.com>
Date: Wed, 12 Jun 2024 07:41:06 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: Teddy Engel <engel.teddy@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Subject: Re: [PATCH] staging: vt6656: Fix checkpatch unnecessary parentheses
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


Remove unnecessary parentheses - according to checkpatch.pl strict

Signed-off-by: Teddy Engel <engel.teddy@gmail.com>


Hi Teddy,

your patch creates a checkpatch warning:
WARNING: A patch subject line should describe the change not the tool 
that found it

The next thing that worries me is that the fix does not increase the
readability of the code for me. I think overview is better with
brackets.

I also think that you are doing two things at a time. You are changing
the TODO file and the brackets.

I would change only the TODO file.

Thanks for your support.

Bye Philipp