Received-SPF: pass (google.com: domain of linux-kernel+bounces-210957-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 12 Jun 2024 14:01:40 +0800
From: Oliver Sang <oliver.sang@intel.com>
To: Yang Shi <shy828301@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>, Christopher Lameter
	<cl@linux.com>, David Hildenbrand <david@redhat.com>, Jason Gunthorpe
	<jgg@nvidia.com>, Matthew Wilcox <willy@infradead.org>, Peter Xu
	<peterx@redhat.com>, Rik van Riel <riel@surriel.com>, Vivek Kasireddy
	<vivek.kasireddy@intel.com>, <linux-kernel@vger.kernel.org>,
	<linux-mm@kvack.org>, <lkp@intel.com>, <oe-lkp@lists.linux.dev>,
	<oliver.sang@intel.com>
Subject: Re: [linus:master] [mm] efa7df3e3b:
 kernel_BUG_at_include/linux/page_ref.h
Message-ID: <Zmk5xAF+vHYLwzoG@xsang-OptiPlex-9020>
References: <f4599bd2-72af-4e8d-a0fe-153b69816133@redhat.com>
 <CAHbLzkrOspjVuQw=BN2+RZmV_Ydpz_50yY7FEakJw8Zm14Y9-Q@mail.gmail.com>
 <a088b5cf-503e-4ed7-b427-f17a9ec5d1a8@redhat.com>
 <CAHbLzkpnDPYWq=HnaJcKhKnppdNikX4YG+1Ysu8Z+XJCoKK4SQ@mail.gmail.com>
 <CAHbLzkr5K=4Shiyb5KgPTQ20jE2Zo08wK=mT3Ez9ADEdJe0Z9A@mail.gmail.com>
 <Zl3M7iniPQaPFDrW@xsang-OptiPlex-9020>
 <CAHbLzkrOTAaYahG4JYMNrJDhQNZZxW9u+2n71J=v1XYJEVpUdw@mail.gmail.com>
 <CAHbLzkr16YZ80ES5U4BEWJ+ueL22nDJtgH=eOztdHfy080diPw@mail.gmail.com>
 <ZmEb2mdAbBQ/9PMP@xsang-OptiPlex-9020>
 <CAHbLzkqORuPjr3p7aZGPKSLfdptrg=z1624rcxjud_zs3+HnCA@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAHbLzkqORuPjr3p7aZGPKSLfdptrg=z1624rcxjud_zs3+HnCA@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHJFeHd6Z0VsV3hpUkwyOENFZVZIbWlKNzdRd0k4SFJFNTIwTmNMdzJmNkFs?=
 =?utf-8?B?aVA1VzJGRlpaVERLSHhoSWtFN3VTQit4RnhDY1BlTUZWOTV4Vzhnd0xSbkYr?=
 =?utf-8?B?aU1ZeFcxRVkxanlRR2gvQXBCU3dxbjVCeXdzeVNIc3BGazVydWpLaVBsMmRa?=
 =?utf-8?B?d04xYlJIajVzRTgvSFdvMlJBS0tVSHlHbmx3VFhFR0lON2FybzZZTzl3KzQ1?=
 =?utf-8?B?cHdrUG9FOXYwNGNUR1VNWjF6Zis1TnQyVW16d2Q0OWVDSHFxaWhpQTdQdFpO?=
 =?utf-8?B?M24ySDZiUURhWTBadG5CMWtWeW5OR2dENGQxMzFvcE5CY21wTVdFUzNqQ1dM?=
 =?utf-8?B?cE8ydjJQUGxOb2FqTkNZY3FZcTllK2V4RnZkZzlSdmhoVmRlWkExQm5HYlhz?=
 =?utf-8?B?WWE5N0Z3VXJVZ0JaNlhvYUZZWUpUc0FtQTNMWXdmUVRHRzFNNmhrM3BQZVQ1?=
 =?utf-8?B?VHpuTWYzYkRDWkFlQWhyblBETzJXV2ppTXlZWHQ1WnZ6WjhZS1E0U0U2Zmxp?=
 =?utf-8?B?Y1M1RXBBYUlUWHM4M3FHZDlRVkh0SDdlYWRpOFQ0Z0dzbEZQTktmQ0hTc2sx?=
 =?utf-8?B?diszMEZGVDJKbVRuVEh5bWFZb0NGczVraG5aZG51NWE2Tjd4T1duNzdpY3ZK?=
 =?utf-8?B?enV2aWIzZnk4WnhpOTVSQi9rbDZFQmFBVDI0cGpYRmorZU4zOWFFb3cwVXI4?=
 =?utf-8?B?cUxCRXJpbVhEdTNaWldlWjIwOXVBaHBYNnJLTUNSS1BYYUdaVmhLaHlwMWE2?=
 =?utf-8?B?U0FWT2xxcVREQVY5NUlCQ000ZEhzak9uaGZpRXAzRHBnVVZVZ3ErOEd4WTBl?=
 =?utf-8?B?dVdhQXRYQ2xoS21acERmU0JPZlZqVEozMFJsOGRpV0srOCtyTUNUNHNSWnhD?=
 =?utf-8?B?emhqKzQ4ZDV0eHZUWHdxOGxZWjlBanZFRW5wUFoxUWYxQzRhaUFUcWY1VDFz?=
 =?utf-8?B?cUJ2a2NGTjhHQndYbklyTnExMTZYTVFNWXBxMGgwdk8vdE1ULzdab3JpWU1M?=
 =?utf-8?B?amFVc0NsM3hMc0tVZ1JrdEMwT2Fucit1ejBISHNLRUVqcGNseGVyS0dpWW56?=
 =?utf-8?B?SEZSU2MxMmpod2s5UkhRUFd0N2VSYW9td0tFQllEb2hwcXdMUGpmT09VbVV3?=
 =?utf-8?B?aW90c0kzMlh1MTJ4UENyTFBlVHdDTnRCZmJCV2tRVFVVakoybFFidGozOWxz?=
 =?utf-8?B?MnRCNmpLVXVyTDU2KzUyZnRGSkxwRDJtRWx3WDdsTzlhUXExN2VQQWNzdDFJ?=
 =?utf-8?B?WE9zVUg0VTdKWjJGSGpnaUw3TGJaaDdLY0IzK1dBMjBUS3NoNEI3ZlpNVlQ2?=
 =?utf-8?B?TTVVRjZKOU1zd3ozd3c3SHpUUjVYY2Niamc3VWlaSStIUkV2c2dYK0dvczVh?=
 =?utf-8?B?ak1aZTI5TFdHVHc0Rlp1WkxSMTVRMTJMWHFGUFNUTitEWjBUVGZibzJHY0RP?=
 =?utf-8?B?QlVVVlJjV3BkZkdML01aaEM3NG9TVnQ3RHVLNzYwZnJXU3J3OS96ai9Pb1RU?=
 =?utf-8?B?NHVMeDJ4bkN6UTN0dlFuaWJncUttSDZwdFBmLzI4ZXhWM2dWZmJIZHhSSVJP?=
 =?utf-8?B?S1pReXdLeDdkM0UvQkdhQzBrKzdpbjNaNmZNWU4yb1hFUkh3ZEIwMUx0Wmdp?=
 =?utf-8?B?WFhDbndiOXM5aUsrZzRsOUdTZlJLdDVOTzF3T1VXQjZmdjV2a2R4U21kVjRh?=
 =?utf-8?B?NDZjSytoT2dsZnFkVHJxbTc0QnAzbi9yV1BxcnVIWDJsaGpPVWIrZDh1ZXBH?=
 =?utf-8?B?bEZQc1orMG9hbzhRQmlhSFhIc010U3BDTXhTOTN4SXVVMytEdWFmVUN4VVJE?=
 =?utf-8?B?MU01eVpsellsSTFMdG8yTDhFeUhRa2JxUWpjcSt5VG9RNlI1Z0VjM0dIQnpo?=
 =?utf-8?B?NlJ1MXF5SUMzdzRMRGFOYzVielZJWjF6VXhxQ1o5ajE3ZkJOblJKTUREKy9P?=
 =?utf-8?B?L3dEZ29XSTZkcmthQnhDT0hyRFRWY2EyODVieGRrVnlxNUNHSHZVNVlmVVND?=
 =?utf-8?B?cXFPQlJldCttaWdLY21GaXpraEN0d09RRzVVTDRIQlgzOEIyejBwU09lb1Ar?=
 =?utf-8?B?b1pjczBlZHg1VEdTRE5mbGo2WEdLSWxtRFRsUFgzMnJCSHZaUUkxdVNJQXR6?=
 =?utf-8?B?VG5xU2FEQzQzUVhtd1JyYk9rWVJuektiSzBNcEtRQlFTZHkzUWZkREM4U2ht?=
 =?utf-8?B?a0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b72f2e3-f8a4-4f87-2861-08dc8aa525eb
X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 06:01:49.1984
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HZ0+sMAJFuncbHHjaH9XvE5Sif7FqGro77wCPohHkda1qTwncOiCa+rVC3NRAP7SSJ6N3DBLci02vEzuhWqetg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8094
X-OriginatorOrg: intel.com

hi, Yang Shi,

On Wed, Jun 05, 2024 at 08:44:37PM -0700, Yang Shi wrote:
> Oliver Sang <oliver.sang@intel.com>于2024年6月5日 周三19:16写道：
> 
> > hi, Yang Shi,
> >
> > On Tue, Jun 04, 2024 at 04:53:56PM -0700, Yang Shi wrote:
> > > On Mon, Jun 3, 2024 at 9:54 AM Yang Shi <shy828301@gmail.com> wrote:
> > > >
> > > > On Mon, Jun 3, 2024 at 7:02 AM Oliver Sang <oliver.sang@intel.com>
> > wrote:
> > > > >
> > > > > hi, Yang Shi,
> > > > >
> > > > > On Fri, May 31, 2024 at 01:57:06PM -0700, Yang Shi wrote:
> > > > > > Hi Oliver,
> > > > > >
> > > > > > I just came up with a quick patch (just build test) per the
> > discussion
> > > > > > and attached, can you please to give it a try? Once it is
> > verified, I
> > > > > > will refine the patch and submit for review.
> > > > >
> > > > > what's the base of this patch? I tried to apply it upon efa7df3e3b or
> > > > > v6.10-rc2. both failed.
> > > >
> > > > Its base is mm-unstable. The head commit is 8e06d6b9274d ("mm: add
> > > > swappiness= arg to memory.reclaim"). Sorry for the confusion, I should
> > > > have mentioned this.
> > >
> > > I just figured out a bug in the patch. Anyway, we are going to take a
> > > different approach to fix the issue per the discussion. I already sent
> > > the series to the mailing list. Please refer to
> > >
> > https://lore.kernel.org/linux-mm/20240604234858.948986-1-yang@os.amperecomputing.com/
> >
> > got it. seems you will submit v2? should we wait v2 to do the tests?
> 
> 
> The real fix is patch #1, that doesn’t need v2. So you just need to test
> that.

we've finished tests and confirmed patch #1 fixed the issue.
we also tested upon patch #2, still clean.

our bot applied your patch upon 306dde9ce5c951 as below

5d45cc9b1beb57 mm: gup: do not call try_grab_folio() in slow path
fd3fc964468925 mm: page_ref: remove folio_try_get_rcu()
306dde9ce5c951 foo

on 306dde9ce5c951, we still observed the issue we reported. clean on both patch
#1 and #2

306dde9ce5c9516d fd3fc96446892528af48d6271a3 5d45cc9b1beb57386992c005669
---------------- --------------------------- ---------------------------
       fail:runs  %reproduction    fail:runs  %reproduction    fail:runs
           |             |             |             |             |
         47:50         -94%            :50         -94%            :50    dmesg.Kernel_panic-not_syncing:Fatal_exception
         47:50         -94%            :50         -94%            :50    dmesg.Oops:invalid_opcode:#[##]KASAN
         47:50         -94%            :50         -94%            :50    dmesg.RIP:try_get_folio
         47:50         -94%            :50         -94%            :50    dmesg.kernel_BUG_at_include/linux/page_ref.h


> 
> For patch #2, I haven’t received any comment yet and I’m going to travel so
> I’m not going to submit v2 soon .
> 
> And I heard if hugepd is going to be gone soon, so I may wait for that then
> rebase on top of it. Anyway it is just a clean up.
> 
> 
> 
> >
> > sorry that due to resource constraint, we cannot respond test request very
> > quickly now.
> >
> > >
> > > >
> > > > >
> > > > > >
> > > > > > Thanks,
> > > > > > Yang
> > > > > >
> > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > --
> > > > > > > > Cheers,
> > > > > > > >
> > > > > > > > David / dhildenb
> > > > > > > >
> > > > >
> > > > >
> > >
> >