Received-SPF: pass (google.com: domain of linux-kernel+bounces-210964-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <dc0f11ba-2ca7-498a-b2dd-26a48e9cdf90@quicinc.com>
Date: Wed, 12 Jun 2024 14:07:19 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] scsi: ufs: core: quiesce request queues before check
 pending cmds
To: Bart Van Assche <bvanassche@acm.org>, <quic_cang@quicinc.com>,
        <mani@kernel.org>, <beanhuo@micron.com>, <avri.altman@wdc.com>,
        <junwoo80.lee@samsung.com>, <martin.petersen@oracle.com>,
        <quic_nguyenb@quicinc.com>, <quic_nitirawa@quicinc.com>,
        <quic_rampraka@quicinc.com>
CC: <linux-scsi@vger.kernel.org>, Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Peter Wang
	<peter.wang@mediatek.com>,
        Manivannan Sadhasivam
	<manivannan.sadhasivam@linaro.org>,
        Maramaina Naresh
	<quic_mnaresh@quicinc.com>,
        Asutosh Das <quic_asutoshd@quicinc.com>,
        "open
 list" <linux-kernel@vger.kernel.org>,
        <quic_richardp@quicinc.com>
References: <1717754818-39863-1-git-send-email-quic_ziqichen@quicinc.com>
 <7ba3bbb8-a5c3-4ecd-9c2a-c9586c9d6bf2@acm.org>
 <6d636c36-ce05-4825-b916-b97484c41c5b@quicinc.com>
 <16b2cd1b-8f1a-4fb1-823f-a73463c6f7a0@acm.org>
Content-Language: en-US
From: Ziqi Chen <quic_ziqichen@quicinc.com>
In-Reply-To: <16b2cd1b-8f1a-4fb1-823f-a73463c6f7a0@acm.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 6/11/2024 9:51 PM, Bart Van Assche wrote:
> On 6/11/24 04:02, Ziqi Chen wrote:
>> As for removing the rest calls to ufshcd_scsi_block_requests() and 
>> ufshcd_scsi_unblock_requests(), I think you are right, but I am not 
>> quite sure because we haven't seen issue reported w.r.t those spots. 
>> If possible, we can co-work on this sometime later.
> 
> If you want I can work on the removal of the
> ufshcd_scsi_block_requests() and ufshcd_scsi_unblock_requests()
> functions.

Thank you, Bart. I will help to review and give you support as possible 
as I can.

BRs,

Ziqi
> 
> Thanks,
> 
> Bart.
>