Received-SPF: pass (google.com: domain of linux-kernel+bounces-210968-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <ef71090e-13c7-4ef1-b34e-d6fe9546b705@axis.com>
Date: Wed, 12 Jun 2024 08:18:40 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 0/2] hwmon: (ina2xx):Add Suppor for passing alert
 polarity from device tree to driver
To: Krzysztof Kozlowski <krzk@kernel.org>, Jean Delvare <jdelvare@suse.com>,
 Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley <conor+dt@kernel.org>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, kernel@axis.com
References: <20240611-apol-ina2xx-fix-v4-0-8df1d2282fc5@axis.com>
 <34fe20d5-c67a-44e6-8ec1-566d80e25447@kernel.org>
Content-Language: en-US
From: Amna Waseem <Amna.Waseem@axis.com>
In-Reply-To: <34fe20d5-c67a-44e6-8ec1-566d80e25447@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TVVUbEkwU0tjaFhRZXNDekkzSklENllZTkxsbFFTMDlRZ2pBMjZEK3pEWVFq?=
 =?utf-8?B?RVRKejMwZTZKRkxTSFMxMk5seXZEb1lKTnJReS82TG0xWUJtaXNFYTN3a0tE?=
 =?utf-8?B?a3FaaHp4OEdycUovd1RvcUlaNlJyMmhHVlUvWXFGem5XdmFhVEhza3Yrc0h4?=
 =?utf-8?B?cHJFNUEvNjUzay93L2NIZ2hDQVlqdThWSGR6SWY0YlJ3RUlBa3U0b1d3TXRs?=
 =?utf-8?B?Z09oUHNNcDhyK0sxZGFRZm9Xc0FSUVhmUmZSWWNqeG52L3YwS2FLQjdKWjVk?=
 =?utf-8?B?L01iUEZJVDNvUDRKZXpxOWZRQ0JOd0E1ZWF3ZFcyamh5WmlBZlZMZXdrNDZv?=
 =?utf-8?B?TmZ2OU9RV092bytSQ3RkSUs2Z052V2hRRlVFQUNBWU9kWlF3c0JlUy90b0lJ?=
 =?utf-8?B?N1ltSTV4NnFIUTNiUHhPWWE3Sm1sUmx6aXRKcHNRbzhwSEVBTUU5cEdZTFpz?=
 =?utf-8?B?UlA0UTVqWE9adHBMOFBzV3RhTjV0Mmw2TWI3WktLVFFCTXNPZEVBQm1IRGlV?=
 =?utf-8?B?TUhpT002K1BUZ1lOUVdaYmg5VTVnS3FuaXhiVFZmV1N0ZkpkRkRORGI3ZGxn?=
 =?utf-8?B?Y0dGY2toSUs0WmlPQ2N4K3l4dUd5N1ZRMU95MVAwbjNOT2p0OFFFdzZ5WXJh?=
 =?utf-8?B?OVVkNENqNFlFR00rakhJTWYrRnNkNUsvVmZvcWxLbkIweHNFQlQrQnIwcE5p?=
 =?utf-8?B?QlFMa3MzUm5jMHcvQnRBVEFVRmxqamNUYUhHUjNBK05zMFRQb3B5bSt4eGtT?=
 =?utf-8?B?ZzZJdUpyQ2Z1RTdEZ0llV2YxMWh5ZlFEUThueFhCTThFMXVBRE1tQVhXTC9L?=
 =?utf-8?B?RzdVcHdCZk80czhOTEI1NEFoMkk0Y0o1bmpJemQ3V2s2Vld1V013eGlvT05x?=
 =?utf-8?B?bjUybCsyZ2VRUnovT2oxWnM0K2xzQzZKakFVQk5iNkpxbzUrWDZnSEY4TUZ4?=
 =?utf-8?B?RWNueVFBVUswWjBYQkZtTmdQd1pXTk9KOG40cS8yQzhnRXVEaE5nQmR5bjhN?=
 =?utf-8?B?eGwyMkpUcEVYSVdtY1ZFZElyd0FjcUdudVBZNVMySkdicGdIWFVXbysrYzJE?=
 =?utf-8?B?WENKWFNMVXNzTS9UcEZwelh0cEx4K0FaZmNOZTJseXkyYWhoekEzZWMxTlQ4?=
 =?utf-8?B?cng4aWhtNzZrNm1uTUpGa2dmVDBTNWxmNWk4VFZrSjh6aXdZODNiUmRaQWl1?=
 =?utf-8?B?OEQ4M0pQZUM1c2pKRnlKNHYyMWNqRm54ellaWERkazViRW1NOEhkUHZVelZ4?=
 =?utf-8?B?TlJvODgzdmozKyt1TG5LVytWL3hNOUM0c2FadHJBeDViWkpsdWNhamRpSi9N?=
 =?utf-8?B?dEkyUklMZ0FhT2RSWmFrd1RvTy9FL1lUQkc3R0VHdkpFTFZlWUg3SEpPZzJ4?=
 =?utf-8?B?K1pLWWRlTTkrR0pNbmh1c2JQWGNWc1FodzVyRFJxMFZ3K1hnZ281WCtDcTJu?=
 =?utf-8?B?UnhhTnZHcDAxalJsdzdJM1ArOUVnM09wQjU3dEgrQnE3SEhkd3l2QUlHQkNX?=
 =?utf-8?B?OHVla1JJVkNHakFwSGNlNnhXT25Kck1LU0NwMkwzRjNDTWtXWXE4ZHcrMXVu?=
 =?utf-8?B?NUowcWw5OVZNN1VadnJBZmFiZmVTejZXL2lCS2ZHWE9SWDhhUWVJMHZ1THhH?=
 =?utf-8?B?blRIVi9TVitLc0pLTkM0OXJCWk5jdkRDekpPUHNGbUJHM2s0aDQ3NmRpWGll?=
 =?utf-8?B?ZFh1MW5LR1VqdmhRNnorQWVneHFqOFdFeGtkdmlKZnhXWllhdEEwaE5QVjN2?=
 =?utf-8?B?MCtWVml5OElzT25lNWxHUEFOaUhPdUJzSXJ2RUJIK0FzaDVPTzlnaFZaMDZU?=
 =?utf-8?B?cTVtemorOHVYRDIxUWVrUi9Xamp2Ni8zcFFuZzNGandBWVZVc2lBUjlKeHdq?=
 =?utf-8?B?TVBoVVBtQTNzT1JUVkYrRDFHRDh0L1ZPcnNYTkh1WTV6dTV5M3FacjRJeDJU?=
 =?utf-8?B?MldmbTF4L09QeS9ubjd3MGFwdkY4MklFNFc4c3dVN3ZvN0hSZHVNcHhPeDR6?=
 =?utf-8?B?VTNrRW1FUEhTMTRDeDlkSVhyelZCMmMrVmJBMEF6NWNFQ2ZMWU82L0E2bDNI?=
 =?utf-8?B?aCt5a3dqSDlCOEtEZ3hqb1VpRG9JaHM5R0YvNUNTSy83NGJneW96Mzg5a001?=
 =?utf-8?Q?b95k=3D?=
X-OriginatorOrg: axis.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12a7bf82-35ec-4af8-620d-08dc8aa781cd
X-MS-Exchange-CrossTenant-AuthSource: DB9PR02MB9994.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 06:18:42.3691
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hp+z80wQ0k+LQXNSJRhp4sqAs0j9KIQL+oavmoKAZ9tio3OoKrNl9CiJKsACbWTx
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR02MB11008

On 6/11/24 14:49, Krzysztof Kozlowski wrote:
> On 11/06/2024 11:36, Amna Waseem wrote:
>> The INA230 has alert polarity bit in Mask/Enable register which can be
>> configured to be active high or active low depending upon the requirements
>> of the hardware using this chip. The patches in this series adds the support
>> for passing alert polarity value from device tree to the driver. Alert polarity
>> property is added device tree bindings and the driver is modified to read
>> this property and set the Alert polarity (APOL) bit value in Mask/Enable register
>> of INA230.
>>
>> Signed-off-by: Amna Waseem <Amna.Waseem@axis.com>
>> ---
>> Changes in v4:
>> - Remove unnecessary checks while setting alert polarity bit
>> - Link to v3: https://lore.kernel.org/r/20240603-apol-ina2xx-fix-v3-0-b9eff3158e4e@axis.com
> <form letter>
> This is a friendly reminder during the review process.
>
> It looks like you received a tag and forgot to add it.
>
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> versions, under or above your Signed-off-by tag. Tag is "received", when
> provided in a message replied to you on the mailing list. Tools like b4
> can help here. However, there's no need to repost patches *only* to add
> the tags. The upstream maintainer will do that for tags received on the
> version they apply.
>
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
>
> If a tag was not added on purpose, please state why and what changed.
> </form letter>
>
> Missing this is really odd, considering you are using b4. Please read
> the b4 guide.
>
> Best regards,
> Krzysztof
>
Thanks Krzysztof for the information. I have read the documentation in 
the link you provided and I will keep it in mind next time if I submit 
patches.

Regards

Amna