Received: by 2002:ab2:6c55:0:b0:1fd:c486:4f03 with SMTP id v21csp245622lqp; Tue, 11 Jun 2024 23:24:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWR55vIc+81svskB1feC0ESFVfyLJlLK3y4eutbMIFk2h7LlT1Y8/d0V4+NerkdwyAkxsA0jcT/DKMHBbaQlf6AnHLAhZdhjjDkIKbJJw== X-Google-Smtp-Source: AGHT+IGqR26pXnHVDAdk++Mb16324OvwXyTtkjIrOB/khIl6sFgufTPeVyRnjC+Uk5NlVDGHaICm X-Received: by 2002:a05:620a:4692:b0:795:ca3c:2f13 with SMTP id af79cd13be357-797f6172a1dmr94204885a.57.1718173470514; Tue, 11 Jun 2024 23:24:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718173470; cv=pass; d=google.com; s=arc-20160816; b=CEJt6BxxHSs14o499KIp4mhZDpFyKnCIx7GlqbcEBJXOG5JzyNmP7LYMQ4HmDSTrrx OPuqqf6vp+E9Va6W3sz0zo9/Z2Y1KCJnX+xwrd09Zsxsnsumig25clLO33tL4loJYA+/ DLGmWLcVx883wE4Tb4qZlV5apDbBJj0Vpcj4KGVPSbGKkDjtopDcXncZH/OeWBKU/kNA CGzgTz1MX5vuSMPnL1gT8s9UrltBCAElG7YjJ1XkEY1c7GseDCFxYESKKexISiEqzycL tF/b+EEOLEGsq3lhYFqGftGcmPbHRp6j2TlH/SUKNpt7HReyYbo2/Pbk9pT+VRlEOcw+ YmjQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=z8HigS3vsEIa0qF6/umS9YqXDrpCLWqrULTYOhmxkNA=; fh=8ByhRz8m9b5LpQPxXsbirl57VaHd2Yl1Nz6e3dUCoO8=; b=ZL/TixN1Fgtcxjw/skPvIYv8EwaGEDXqPgHRodAhQ+UJrPVJe1SCAuMlQ7bDy/tCdG UQelJ0VHofwXrAZyZ6L3CxKb3+JpkdS2TMF57WuNECd3afGRIAt2DS/Yuorlymtkd0l+ kYLHy5o3+c9HqVhJT87eygzWnA09U5QxeICW1WyxztwDU9NSGZ4wkAYp8ijXYe9ytKMK O3Sg9Gwj5vzjICDUx351/jlT6DKTW7IgT74sFK5cMMcHWKIKw8eXdpmbHiEDEZOuV68B IevuDlokVQVbIIegQ001fHcrcZ4kwWHKp9GIx9ICDrZkrYH5bcaOCkCh9NlgiA2ewJy/ 0BCA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m4vdQMR7; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-210973-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210973-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id af79cd13be357-79538489b86si1060254385a.590.2024.06.11.23.24.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 23:24:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-210973-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m4vdQMR7; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-210973-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210973-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DD1501C21499 for ; Wed, 12 Jun 2024 06:24:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6D27A1369AF; Wed, 12 Jun 2024 06:24:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="m4vdQMR7" Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45AEB168C0B for ; Wed, 12 Jun 2024 06:24:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718173449; cv=none; b=nJ6VX0nDzfBl/uCxMUUwVW5o59CY8XQ62mUDcRmV7nR7t44FVTiyHQGMRcZfoBoEz8pq4/TRVOe3MLEVzEz6I8QeA6q0Ghzcw5vFim+GkuZYe9/xDRUmN13Jlg/TMQycoKMxLfHA3caD9qRvt0J/QNyVX5UoVm3ZRs+uVV9FguA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718173449; c=relaxed/simple; bh=lkhq4cjoU+wR78ATPynQEfivjyNaE/5Cv79pLJI/qWo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tuTo+EKuzusktjt43Mhzdr+TA4MBIwpnVOnFgDG0G3gnLlZLLYySb7whDdtgz6751irCXFpIN0hupKiG7wir94vW2etsOisTazb/OsQm+LJm/yiZQEi7InMRPzOjAromUzZX4DOGWEDFKyI5CLm6vUKQWI6DBjd+1/CE+6A/Yh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=m4vdQMR7; arc=none smtp.client-ip=209.85.160.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-2550aa6f994so523004fac.3 for ; Tue, 11 Jun 2024 23:24:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718173447; x=1718778247; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=z8HigS3vsEIa0qF6/umS9YqXDrpCLWqrULTYOhmxkNA=; b=m4vdQMR7GSz29fQHS4InnzM5v9aGslbQ3atBrQP5AztWo9TrOwlB45QInGrso5FPhx mDb1Pu+Nbbolo8yNFtGJwoRzlcGdudzLYI+W9M4HTW0HSGWg86MzvqccXOKPcBzdu81O rNTqzBVpnJajGgjkA6BS2rclUbZE18/VkLY/XZjgTLR1j/OI2mKmUqvr9MkXSY4Bo1zI +zVlaH9AqMJovNJiGIey/e/ZnSxI2tE07zE4T1/W+bTFXiEi8ZvpvVSpKtaXdpAEvuXm mJ9CE63CfAsrrNntW9TDysh/M68/oWyXLeBLPwD6Q35jo8ehk3aoXN6qTVQIOu+inP41 CFkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718173447; x=1718778247; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=z8HigS3vsEIa0qF6/umS9YqXDrpCLWqrULTYOhmxkNA=; b=ZLV3uZtRzqb6idyCmZnhST3O/hfQ0MlmWrnhGNQ6ihly+8TYcXnCCTo+MX05163mec PVzQb48SshQYJyaU58kAAv5B34CgwxKodkQa3BnME0wzgc+4wjLgugao3Zrb3cnHcPUJ HbHF2MMpZ+VxO1glSzz2PLK1TOIEOdVgBVKMFhPr4ttE05C3inf4HAqL5IQOV5IWaTYM yE5xYaFkrCc3QQ5nto2o+bzg1uFdfnekvfA3XWMCfDsTd/pnhcOqYMMhZeDtyUKwVlQj VA1Fv9FESEVN0XXP1y4dvvxLJvTHPDDQM7xrU6ugE6EpdC8UYRRZYNCZyFMKjkw5QOZ6 glMQ== X-Forwarded-Encrypted: i=1; AJvYcCWxsz4eN49pikUzqGl7JSGZ5dU81YgflUUaVX6AFXwdFjpIunqtLwwNdZ3/J4yYrNNrjnqKP+PrjICy885Z1wxo16xHbljcY5rMvEDY X-Gm-Message-State: AOJu0YzkLJJwVAvsvkmCBTc2idFZlKtoViEDp/jHUf81ENY53a+G8Fg1 wbDBB3f1922SGglrhPGlpBp2Eb+WIsLckcFkHo4g6kjM3ePgsF5iPpTZz3hC9Hw= X-Received: by 2002:a05:6871:593:b0:254:a753:d1c0 with SMTP id 586e51a60fabf-25514ef95c6mr1230263fac.48.1718173447130; Tue, 11 Jun 2024 23:24:07 -0700 (PDT) Received: from localhost ([122.172.82.13]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e52500c4easm6187784a12.36.2024.06.11.23.24.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 23:24:06 -0700 (PDT) Date: Wed, 12 Jun 2024 11:54:04 +0530 From: Viresh Kumar To: Riwen Lu Cc: Ionela Voinescu , beata.michalska@arm.com, rafael@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, hotran@apm.com, Riwen Lu Subject: Re: [PATCH v3] cpufreq/cppc: Remove the desired_perf compare when set target Message-ID: <20240612062404.yjfduze4bvgyts6a@vireshk-i7> References: <20240530061621.36byo5a2iqc6o2az@vireshk-i7> <20240606090737.z3qenphikjs5ijj4@vireshk-i7> <20240611091049.lrypvvluntf37uff@vireshk-i7> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 12-06-24, 10:52, Riwen Lu wrote: > I think it's no need to remove the "desired_perf" local variable here, the > code is seems more readable. There is no need of a temporary variable and I don't think it increases readability at all. Moreover, same needs to be done in cppc_cpufreq_fast_switch() too. -- viresh