Received: by 2002:ab2:6c55:0:b0:1fd:c486:4f03 with SMTP id v21csp254022lqp; Tue, 11 Jun 2024 23:48:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVI5TpuIxQchwPRrJYiPtzDnxvX0ZzE8ZTHtIwgVM6YcfEKYPZI5hurqi6YCQiPUtFwCK7nEI45Yj7QKOdJOki+oWVWsC2AbeMhWRIldA== X-Google-Smtp-Source: AGHT+IFBNnY4QTID70c+WGdFj/jlM+973SbrWNQ4fhovm9Bir1nXJ9jFazeAATc1WESE+2iMpWfU X-Received: by 2002:a05:6a00:2d9b:b0:704:34c2:b0bd with SMTP id d2e1a72fcca58-705bcee93a1mr1118717b3a.27.1718174894311; Tue, 11 Jun 2024 23:48:14 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718174894; cv=pass; d=google.com; s=arc-20160816; b=u8+KTZcq5//x1sUsEGtX2aGIOpDF6LM1kLTO5f1iTclwQZrTGRyMHpehT+V4aatUGi a21kC+HbzkFGeLLzw1M3wm/1+PvmXAKNCFqW2UZYkwvN/GlnJO7I9VUkd5C3qvFXVXi7 tSDKT2oPhH4RhDqsISp0gKe4mFfRxvzfdtm/evnr+DrLEsl7IaJgp7spaNroI9qwjB74 0XYekWgm49IT+4t/ScuS2QDPBe12PMlB9FBf8GM2nkDph1CPrgo/lW3IJp1SDhJl3Rk0 7pZ2mDbr5pu17QTRT6fpINRBEoYwL3oGJm/tJPvLi25OzGkIEQrfWdQx9iLl8n0jaaiR k/8g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=pvLnwTafypJgBacbbF6XVnH7hSs8WZbnLIkz2LjARgk=; fh=ZBHHCiMwYFzh22p9KdmsA8KS9ljAbi6rlBHc134BUWY=; b=JZaBWhz6ADmBx9SOVSoHcYcFF5JQLcEwtV9QS9xiKie77SGgHgNRSXf0wOsDt0ba3j o9THfGs9T40A40FcYnZygZk3BfsGIaeIXn7uGwaPD+83km/LSM6uA7Q3FK8r7suQgE9F 023hu+We7fNq4LNQPPTlqzkiMKxFVRy6f7BYqoGjYn/CCtwQ5tN2yK+V+r5Dqab2CItq ri5V8AUT6wGwKGaPApvNhz+ctNC4F/QX5vUGa0gPPisWQEfU4ZYSZf/HXYc3i/8xbpuw Sdq/bjQ/tywyPlOg20pYvXs7adnMymF6e4FZpWmKq19MX3qtC+7xK6GJGcG6lh+FgTLC KDHw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@leemhuis.info header.s=he214686 header.b=R462js79; arc=pass (i=1 spf=pass spfdomain=leemhuis.info dkim=pass dkdomain=leemhuis.info); spf=pass (google.com: domain of linux-kernel+bounces-210998-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210998-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-6de261cad36si6933193a12.323.2024.06.11.23.48.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 23:48:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-210998-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@leemhuis.info header.s=he214686 header.b=R462js79; arc=pass (i=1 spf=pass spfdomain=leemhuis.info dkim=pass dkdomain=leemhuis.info); spf=pass (google.com: domain of linux-kernel+bounces-210998-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-210998-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id EF5B3B21086 for ; Wed, 12 Jun 2024 06:46:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7A7B516B740; Wed, 12 Jun 2024 06:46:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=leemhuis.info header.i=@leemhuis.info header.b="R462js79" Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE70F25622; Wed, 12 Jun 2024 06:46:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.237.130.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718174790; cv=none; b=AbwGQxo9dTw5nKjIsd0fNEXuvQ5TGSFdkcAV1jL/4m/FKbLys4dGUV+njdGjoxuRbl6/a+mB6KFSBB2Xm1lHi9L6hT49ke4OtWGKwQ0xQ0eO6nJk9AoIzWgVoCel1n8cB1dF5ufXUBqk04EA07WcI6x3HpQgfAxL4JqUHfo7fF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718174790; c=relaxed/simple; bh=AP4H2PJybdyXI48p76JqtAskkZZNNPRy/HmyCOgf1gM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tiLdLL9I+vaxK1pG+JRsnCQ9uki0uESOJaNNciMoofT+3uUsIzFkIhBvQJTSsWfGaSpvaBQ3sh8M4/Btk2l16ziZfHc3WWracsTf4M58MtP3oel1O5vYhvbcnrJfOMtbu8vYceatYvzLHHEsVain1S1LanpMzwYuSkswcihvUKs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=leemhuis.info; spf=pass smtp.mailfrom=leemhuis.info; dkim=pass (2048-bit key) header.d=leemhuis.info header.i=@leemhuis.info header.b=R462js79; arc=none smtp.client-ip=80.237.130.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=leemhuis.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=leemhuis.info DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=leemhuis.info; s=he214686; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:In-Reply-To: References; bh=pvLnwTafypJgBacbbF6XVnH7hSs8WZbnLIkz2LjARgk=; t=1718174788; x=1718606788; b=R462js79Jn7g3mPIUvD10Lv+Y7f8TZoKvCWFCKqgWgONHRtFFengDVJJWShat S1egMhzbWbIlirPmyq84ZEtbsbhZSfqb7KhoqiaoJVIDR2osdq/6/dxxAZv3+rMARdb38zN9h6lYI qJpNcGCVJ762TeuO44cOsNgKc74jwipuIrj1GWh60VXr/CfP5Jlp2R6HKCWue3urJTYzPl7ayhqbY 7VsS9xnO30W2IU9V1dv/ETaedBATyU+Tx40kO/XuUYcNa5vxvwoRcJK6YKccxV+bcDyunm+4fOLAk APpOcqihG1P3Pgx6q8KQ1/uMnuTULvdxo/bEKIxP0vrniK3m8w==; Received: from [2a02:8108:8980:2478:8cde:aa2c:f324:937e]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1sHHkX-000557-GK; Wed, 12 Jun 2024 08:46:25 +0200 Message-ID: Date: Wed, 12 Jun 2024 08:46:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] checkpatch: check for missing Fixes tags To: Andrew Morton , Dan Carpenter Cc: Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Arnd Bergmann , Kees Cook , Sasha Levin , Tom Gall , kernel-janitors@vger.kernel.org References: <20240611113855.b63a6015b26a0dad49d9f2a7@linux-foundation.org> From: Thorsten Leemhuis Content-Language: en-US, de-DE Autocrypt: addr=linux@leemhuis.info; keydata= xsFNBFJ4AQ0BEADCz16x4kl/YGBegAsYXJMjFRi3QOr2YMmcNuu1fdsi3XnM+xMRaukWby47 JcsZYLDKRHTQ/Lalw9L1HI3NRwK+9ayjg31wFdekgsuPbu4x5RGDIfyNpd378Upa8SUmvHik apCnzsxPTEE4Z2KUxBIwTvg+snEjgZ03EIQEi5cKmnlaUynNqv3xaGstx5jMCEnR2X54rH8j QPvo2l5/79Po58f6DhxV2RrOrOjQIQcPZ6kUqwLi6EQOi92NS9Uy6jbZcrMqPIRqJZ/tTKIR OLWsEjNrc3PMcve+NmORiEgLFclN8kHbPl1tLo4M5jN9xmsa0OZv3M0katqW8kC1hzR7mhz+ Rv4MgnbkPDDO086HjQBlS6Zzo49fQB2JErs5nZ0mwkqlETu6emhxneAMcc67+ZtTeUj54K2y Iu8kk6ghaUAfgMqkdIzeSfhO8eURMhvwzSpsqhUs7pIj4u0TPN8OFAvxE/3adoUwMaB+/plk sNe9RsHHPV+7LGADZ6OzOWWftk34QLTVTcz02bGyxLNIkhY+vIJpZWX9UrfGdHSiyYThHCIy /dLz95b9EG+1tbCIyNynr9TjIOmtLOk7ssB3kL3XQGgmdQ+rJ3zckJUQapLKP2YfBi+8P1iP rKkYtbWk0u/FmCbxcBA31KqXQZoR4cd1PJ1PDCe7/DxeoYMVuwARAQABzSdUaG9yc3RlbiBM ZWVtaHVpcyA8bGludXhAbGVlbWh1aXMuaW5mbz7CwZQEEwEKAD4CGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AWIQSoq8a+lZZX4oPULXVytubvTFg9LQUCX31PIwUJFmtPkwAKCRBytubv TFg9LWsyD/4t3g4i2YVp8RoKAcOut0AZ7/uLSqlm8Jcbb+LeeuzjY9T3mQ4ZX8cybc1jRlsL JMYL8GD3a53/+bXCDdk2HhQKUwBJ9PUDbfWa2E/pnqeJeX6naLn1LtMJ78G9gPeG81dX5Yq+ g/2bLXyWefpejlaefaM0GviCt00kG4R/mJJpHPKIPxPbOPY2REzWPoHXJpi7vTOA2R8HrFg/ QJbnA25W55DzoxlRb/nGZYG4iQ+2Eplkweq3s3tN88MxzNpsxZp475RmzgcmQpUtKND7Pw+8 zTDPmEzkHcUChMEmrhgWc2OCuAu3/ezsw7RnWV0k9Pl5AGROaDqvARUtopQ3yEDAdV6eil2z TvbrokZQca2808v2rYO3TtvtRMtmW/M/yyR233G/JSNos4lODkCwd16GKjERYj+sJsW4/hoZ RQiJQBxjnYr+p26JEvghLE1BMnTK24i88Oo8v+AngR6JBxwH7wFuEIIuLCB9Aagb+TKsf+0c HbQaHZj+wSY5FwgKi6psJxvMxpRpLqPsgl+awFPHARktdPtMzSa+kWMhXC4rJahBC5eEjNmP i23DaFWm8BE9LNjdG8Yl5hl7Zx0mwtnQas7+z6XymGuhNXCOevXVEqm1E42fptYMNiANmrpA OKRF+BHOreakveezlpOz8OtUhsew9b/BsAHXBCEEOuuUg87BTQRSeAENARAAzu/3satWzly6 +Lqi5dTFS9+hKvFMtdRb/vW4o9CQsMqL2BJGoE4uXvy3cancvcyodzTXCUxbesNP779JqeHy s7WkF2mtLVX2lnyXSUBm/ONwasuK7KLz8qusseUssvjJPDdw8mRLAWvjcsYsZ0qgIU6kBbvY ckUWkbJj/0kuQCmmulRMcaQRrRYrk7ZdUOjaYmjKR+UJHljxLgeregyiXulRJxCphP5migoy ioa1eset8iF9fhb+YWY16X1I3TnucVCiXixzxwn3uwiVGg28n+vdfZ5lackCOj6iK4+lfzld z4NfIXK+8/R1wD9yOj1rr3OsjDqOaugoMxgEFOiwhQDiJlRKVaDbfmC1G5N1YfQIn90znEYc M7+Sp8Rc5RUgN5yfuwyicifIJQCtiWgjF8ttcIEuKg0TmGb6HQHAtGaBXKyXGQulD1CmBHIW zg7bGge5R66hdbq1BiMX5Qdk/o3Sr2OLCrxWhqMdreJFLzboEc0S13BCxVglnPqdv5sd7veb 0az5LGS6zyVTdTbuPUu4C1ZbstPbuCBwSwe3ERpvpmdIzHtIK4G9iGIR3Seo0oWOzQvkFn8m 2k6H2/Delz9IcHEefSe5u0GjIA18bZEt7R2k8CMZ84vpyWOchgwXK2DNXAOzq4zwV8W4TiYi FiIVXfSj185vCpuE7j0ugp0AEQEAAcLBfAQYAQoAJgIbDBYhBKirxr6Vllfig9QtdXK25u9M WD0tBQJffU8wBQkWa0+jAAoJEHK25u9MWD0tv+0P/A47x8r+hekpuF2KvPpGi3M6rFpdPfeO RpIGkjQWk5M+oF0YH3vtb0+92J7LKfJwv7GIy2PZO2svVnIeCOvXzEM/7G1n5zmNMYGZkSyf x9dnNCjNl10CmuTYud7zsd3cXDku0T+Ow5Dhnk6l4bbJSYzFEbz3B8zMZGrs9EhqNzTLTZ8S Mznmtkxcbb3f/o5SW9NhH60mQ23bB3bBbX1wUQAmMjaDQ/Nt5oHWHN0/6wLyF4lStBGCKN9a TLp6E3100BuTCUCrQf9F3kB7BC92VHvobqYmvLTCTcbxFS4JNuT+ZyV+xR5JiV+2g2HwhxWW uC88BtriqL4atyvtuybQT+56IiiU2gszQ+oxR/1Aq+VZHdUeC6lijFiQblqV6EjenJu+pR9A 7EElGPPmYdO1WQbBrmuOrFuO6wQrbo0TbUiaxYWyoM9cA7v7eFyaxgwXBSWKbo/bcAAViqLW ysaCIZqWxrlhHWWmJMvowVMkB92uPVkxs5IMhSxHS4c2PfZ6D5kvrs3URvIc6zyOrgIaHNzR 8AF4PXWPAuZu1oaG/XKwzMqN/Y/AoxWrCFZNHE27E1RrMhDgmyzIzWQTffJsVPDMQqDfLBhV ic3b8Yec+Kn+ExIF5IuLfHkUgIUs83kDGGbV+wM8NtlGmCXmatyavUwNCXMsuI24HPl7gV2h n7RI In-Reply-To: <20240611113855.b63a6015b26a0dad49d9f2a7@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;linux@leemhuis.info;1718174788;97890b0f; X-HE-SMSGID: 1sHHkX-000557-GK On 11.06.24 20:38, Andrew Morton wrote: > On Tue, 11 Jun 2024 16:43:29 +0300 Dan Carpenter wrote: > >> This check looks for common words that probably indicate a patch >> is a fix. For now the regex is: >> >> (?:(?:BUG: K.|UB)SAN: |Call Trace:|stable\@|syzkaller)/) >> >> Why are stable patches encouraged to have a fixes tag? Some people mark >> their stable patches as "# 5.10" etc. This is useful but a Fixes tag is >> still a good idea. > > I'd say that "# 5.10" is lame Documentation/process/stable-kernel-rules.rst documents this use to "Point out kernel version prerequisites". > and it would be good if checkpatch could > detect this and warn "hey, use a proper Fixes:". Because > >> It helps people to not cherry-pick buggy patches without also >> cherry-picking the fix. > > seems pretty important. Hmmm. That would lead to false positive when it comes to changes that for example just add a device ID (and thus do not "Fix" anything) while having prerequisites that are only available in a specific version. Ciao, Thorsten