Received-SPF: pass (google.com: domain of linux-kernel+bounces-211011-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <82269717-ab49-4a02-aaad-e25a01f15768@oracle.com>
Date: Wed, 12 Jun 2024 07:55:31 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 08/21] xfs: Introduce FORCEALIGN inode flag
To: Long Li <leo.lilong@huawei.com>, david@fromorbit.com, djwong@kernel.org,
        hch@lst.de, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
        chandan.babu@oracle.com, willy@infradead.org
Cc: axboe@kernel.dk, martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, tytso@mit.edu, jbongio@google.com,
        ojaswin@linux.ibm.com, ritesh.list@gmail.com, mcgrof@kernel.org,
        p.raghav@samsung.com, linux-xfs@vger.kernel.org,
        catherine.hoang@oracle.com
References: <20240429174746.2132161-1-john.g.garry@oracle.com>
 <20240429174746.2132161-9-john.g.garry@oracle.com>
 <20240612021058.GA729527@ceph-admin>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240612021058.GA729527@ceph-admin>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Q1BxQmRXUWc1T3Zzc2pHdlhZMFFJdU5iSWhlbnZuZnFGbVB0dWxtOWdZWWRz?=
 =?utf-8?B?TWd6VWdyL1lHVlNHVDRCbll5RXpIbnByQmlXamtSeS9UNnI1Y0Y1OHhTZnpP?=
 =?utf-8?B?SzNpWDdjMFRoVm0wT1JkVTREaURhSkJmVjN3VXo1QytzWG80OUd3UHFkR1Ex?=
 =?utf-8?B?aG5TRU41R2Z5dzlwaGtIUzB2dlA4dzlia2I3cGhVaHpkaHh4bU9Ga2NhTGxk?=
 =?utf-8?B?dDVGS1lhM3kwbGFQQnUzM1lrYzRCUG9HWkNzb3gxM1RLNjJyckl2VHlBd2Vi?=
 =?utf-8?B?RVBSSHdydDFHa3k5UCtadHhFYlBLd3J1dHp5RVlsaWpMdngrOVpIM2VPZ0dQ?=
 =?utf-8?B?S2lUb3lRSWdjZ0hobk9iekNXMkNEUVA5ckh2azljeVFnd2wvOWc3KzZsVXIr?=
 =?utf-8?B?Vlp3WVAzN1VYODdtTW1zODIzMW03UjdIWXJ2UGNiZzg1R1lxdVFCczBna2Ri?=
 =?utf-8?B?ckEzSUlJR2plRVJwbGpoMWtGNC9weHhSNTJOREN2TjhYU0FCdjJkRzV5UjhZ?=
 =?utf-8?B?TFUvRmpKWTlOSDM0WTNSZlhQR0RWQ1F2NDJKOUZsTzgvQXBFNUVhU2RYeHBs?=
 =?utf-8?B?eUdpQ2pNQUgyME53WG01WVMwYUVESlNwbldIQk5IWm4zbGliZHEvRThLMkFp?=
 =?utf-8?B?U2I0R0VaejlDTTdUZFNHbFI0NTZMdlNRTTRub1lzTXZPdkR5aE5OaTY4YTg2?=
 =?utf-8?B?Tm4wdDB0aVNsQTBoRlpMMEhIa0hQdWJzL2taamNydXEwTVNLZzdkUGMvUllT?=
 =?utf-8?B?ZkRJWGtHejZjMktBU1FNN2tIQW14ZGFSd0VxdHZxTnlKS2NaNGhJM01kZ2RB?=
 =?utf-8?B?Vm5GWGtwS0tyZ3Vjcm13NEFkVW1kMlc5a2V0aSttd3RSaE5laTBNZGVnSkE5?=
 =?utf-8?B?MjZXVEpLNHpUSE9LSCtUWm1lcndVcFU1YXNGZTVXcTZVT0ZTUlZ6R0dTb0po?=
 =?utf-8?B?clJSYlBnbkROL3U4RnRGWkdjZElCOGU1TzZCd3VPNWc3TFIzdnhCTllkd2VG?=
 =?utf-8?B?WjExOTNVS2pYRVVFNm9aYkdiRnBBWlpicDVlUnJxKzE1Q2xUOFkwQ3BuakI5?=
 =?utf-8?B?Y2lScjhKYkF5UGQrYTJGNzBIMUh2NGc1bS95Nkh0M3RWaElVNmI3cTFRSEdX?=
 =?utf-8?B?T0VFMzdLbG10TlBjUkxhaWU3NDNDTjhMMTJHaU53YnhGamZnYkpETVJOdWJE?=
 =?utf-8?B?UDZPOEFmd3UvL1ZLWGZJNG15WUhtaTZPbkFzMTVhRW5lb050MU9QMUZxUnFh?=
 =?utf-8?B?SnJCN0R5dFVxZmVrNEw5TytrMXhRSmUyMnRHbWtSak9hWGJrZkJ5ZU9zWEpr?=
 =?utf-8?B?NVR5U0hRR0RaWDRsMzhoVWs1NU85ZUIzQWlJVEpJclFLQ2JNOWdxUWFoZnk1?=
 =?utf-8?B?SjRac2p4NUlQR091MU1NazFKbWw4TjE2MnEwRE9rSDBUZmZRTVRIWHBNbkFi?=
 =?utf-8?B?cjU2UGxucjNjYU1SWE1Eem9QVUVDWDlDY3RReEI5aGdDVXMyUmEzdUEva0lt?=
 =?utf-8?B?KzJmM2RXOFFNQUUvcmQ3RFZmRDU1MzkrWkZLcWJaZFZBV0RubVdEeldMRzdT?=
 =?utf-8?B?OEJwWFN4VjhkNlNTcWFobGdFaER3VS9seUZJOWYxek9NVmFCNXdpMjZSNjR3?=
 =?utf-8?B?UE5YRzR0QlUrMTdzYkJxVkpZeHRxMFhZNjZxNmorNWNHa0VoMEpmcE0vODhU?=
 =?utf-8?B?aGZFQUY0UEh5eHQwTWFhZDg0eUUxNnk5N2pma0VIa2oyVnhtNVdyek5uWHRj?=
 =?utf-8?B?R3h6OEo4TXc0c2liZ1hsWVAwcG9iTUZnUXdldFhkSjFBNzNlVjZ5M2RJbVNa?=
 =?utf-8?B?QnlWbXN1aVVOdWNEcVNzNkprZVJ4OVRtVXdrbDJ5SlY4dklNd1hydzhiS3BI?=
 =?utf-8?B?cVlSaHQ5K05wc1AzekZFbnlFRDQ5NEZpWWs2QTdMUTdyekFsZlR1KzJJVjZQ?=
 =?utf-8?B?bkpUZG01ZjF2TUZ0eUd3OG5JSlhxelhnbDJ4bGRDR3Qwa3p3cno5ZFBwQytt?=
 =?utf-8?B?WkxrV3E2Q2t5bG1JWFFIMHpuTHhGbWhWTUE1YWhwMnpWbzdXVWkwdlF5SXBJ?=
 =?utf-8?B?WHJ3ZzdDdnJlTGdpdXpDdGxEckZ0Q29EUHBpTldHQWltb3ZUcVdKVEtaSzIw?=
 =?utf-8?Q?0ucjAZwnF4h1y4QizsxN1S/tN?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	IGlUE1afmpFl+8U0trItYDc6OA0BnUUG5nWGlTo9bKl5oAF7yTWN9z/W6RJ47n/SG0ieUPWZl5iht2NLWp7Cbj+tincGr3spol0LDEp9iJ1cjYSslrVz7lgmGMUeZ0MZgVuzw80ATkn6LUuFU8JViY/1xtjAkdUxYKONk3a7Hxk/I0RVtDf3XUkqE+dc/VFCgz4z7IXBowa6mRYrsX81RW3KVMCmQIOOYMNf6hkYARCqpZuh7fste7jUL5GWAW59bkpaQ3JNrPS9kIU4wDNvjHzM+wCtD6Z3Gr69P1Dn3cEZVQVPImT3eA6SXhcewFsLjBlnz3iPg3icgTssbCDJZT0G131TiQmkN+DFNCXPdn+bddQ1bk/Zs8yHp8CH2xSGw1+UUUesburNN25f4l+eAWcnHtLv4fmQugQmQ22a0KWWWYvJ/xtqLDsWkR0TD11LAH48xPVljQ8DZP/KAob5EhvFnsfXDqjhZyUKbXE8hiy5v4QpboH2OHn3/I883SyqBOqm7Zvz2pwR2odVjHzFezl1pMAikUbRrTPZOgjR7t19j0Qat/tFiCGZ/9+DdoO3zSahMFojVwO3572ZK9zkDI9wEJWVl7niu2F2rf4k530=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65329672-6d43-4cc2-4eb2-08dc8aacab2d
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 06:55:39.2613
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 64moRg7xdco8EbH6vnAz5VVbgXf4GL3VsOAZBLTBdnSeNNjOYzZ+YkUsspxhN5Na6jKInZKFgiIpXf3lwntgPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB7814
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-12_03,2024-06-11_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 adultscore=0
 mlxscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406120048
X-Proofpoint-GUID: Vbzg51UC_qqaiQJMSe_EjL7nXo47JuHF
X-Proofpoint-ORIG-GUID: Vbzg51UC_qqaiQJMSe_EjL7nXo47JuHF

On 12/06/2024 03:10, Long Li wrote:
> On Mon, Apr 29, 2024 at 05:47:33PM +0000, John Garry wrote:
>> From: "Darrick J. Wong"<djwong@kernel.org>
>>
>> Add a new inode flag to require that all file data extent mappings must
>> be aligned (both the file offset range and the allocated space itself)
>> to the extent size hint.  Having a separate COW extent size hint is no
>> longer allowed.
>>
>> The goal here is to enable sysadmins and users to mandate that all space
>> mappings in a file must have a startoff/blockcount that are aligned to
>> (say) a 2MB alignment and that the startblock/blockcount will follow the
>> same alignment.
>>
>> jpg: Enforce extsize is a power-of-2 and aligned with afgsize + stripe
>>       alignment for forcealign
>> Signed-off-by: "Darrick J. Wong"<djwong@kernel.org>
>> Co-developed-by: John Garry<john.g.garry@oracle.com>
>> Signed-off-by: John Garry<john.g.garry@oracle.com>
>> ---
>>   fs/xfs/libxfs/xfs_format.h    |  6 ++++-
>>   fs/xfs/libxfs/xfs_inode_buf.c | 50 +++++++++++++++++++++++++++++++++++
>>   fs/xfs/libxfs/xfs_inode_buf.h |  3 +++
>>   fs/xfs/libxfs/xfs_sb.c        |  2 ++
>>   fs/xfs/xfs_inode.c            | 12 +++++++++
>>   fs/xfs/xfs_inode.h            |  2 +-
>>   fs/xfs/xfs_ioctl.c            | 34 +++++++++++++++++++++++-
>>   fs/xfs/xfs_mount.h            |  2 ++
>>   fs/xfs/xfs_super.c            |  4 +++
>>   include/uapi/linux/fs.h       |  2 ++
>>   10 files changed, 114 insertions(+), 3 deletions(-)
>>
>> diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h
>> index 2b2f9050fbfb..4dd295b047f8 100644
>> --- a/fs/xfs/libxfs/xfs_format.h
>> +++ b/fs/xfs/libxfs/xfs_format.h
>> @@ -353,6 +353,7 @@ xfs_sb_has_compat_feature(
>>   #define XFS_SB_FEAT_RO_COMPAT_RMAPBT   (1 << 1)		/* reverse map btree */
>>   #define XFS_SB_FEAT_RO_COMPAT_REFLINK  (1 << 2)		/* reflinked files */
>>   #define XFS_SB_FEAT_RO_COMPAT_INOBTCNT (1 << 3)		/* inobt block counts */
>> +#define XFS_SB_FEAT_RO_COMPAT_FORCEALIGN (1 << 30)	/* aligned file data extents */
>   
> Hi, John
> 
> You know I've been using and testing your atomic writes patch series recently,
> and I'm particularly interested in the changes to the on-disk format. I noticed
> that XFS_SB_FEAT_RO_COMPAT_FORCEALIGN uses bit 30 instead of bit 4, which would
> be the next available bit in sequence.
> 
> I'm wondering if using bit 30 is just a temporary solution to avoid conflicts,
> and if the plan is to eventually use bits sequentially, for example, using bit 4?
> I'm looking forward to your explanation.

I really don't know. I'm looking through the history and it has been 
like that this the start of my source control records.

Maybe it was a copy-and-paste error from XFS_FEAT_FORCEALIGN, whose 
value has changed since.

Anyway, I'll ask a bit more internally, and I'll look to change to (1 << 
4) if ok.

Thanks,
John