Received-SPF: pass (google.com: domain of linux-kernel+bounces-211017-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 12 Jun 2024 08:56:38 +0200
From: Larysa Zaremba <larysa.zaremba@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: <intel-wired-lan@lists.osuosl.org>, Jesse Brandeburg
	<jesse.brandeburg@intel.com>, Tony Nguyen <anthony.l.nguyen@intel.com>,
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Alexei Starovoitov <ast@kernel.org>, "Daniel
 Borkmann" <daniel@iogearbox.net>, Jesper Dangaard Brouer <hawk@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>, Maciej Fijalkowski
	<maciej.fijalkowski@intel.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>,
	<magnus.karlsson@intel.com>, Michal Kubiak <michal.kubiak@intel.com>
Subject: Re: [PATCH iwl-net 0/3] ice: fix synchronization between .ndo_bpf()
 and reset
Message-ID: <ZmlGppe04yuGHvPx@lzaremba-mobl.ger.corp.intel.com>
References: <20240610153716.31493-1-larysa.zaremba@intel.com>
 <20240611193837.4ffb2401@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240611193837.4ffb2401@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iMG/zpBmfGhJSMMb7ynyuwPUBXFrLbtM9aiKCEViXueFs/p2pMkyEhJ2V0OB?=
 =?us-ascii?Q?Pky1sw1+Xdp6Hd3torm9z2szDHt3FjKf54UTtxAIcFm/O/BjLMMPX8eKths8?=
 =?us-ascii?Q?eJ5/Xu5Mdsttpe7/Bb2h9BowhRbzBL7nshlVcQEpnbqFNik6TY0bHy5WZD+y?=
 =?us-ascii?Q?jf7CjwG/DfmVuuyG7ZLEWGgKS9xGkJYZ/PZLZpfR4dngTNJr9mQ8rK6XJB+K?=
 =?us-ascii?Q?7SxwScT18DKIwc5QcrU0pznCwuzbdgXw4KeoiQBoVUbP0fznGq3oj9TbuZw2?=
 =?us-ascii?Q?4BoWz4JIbxhh4Kjx7gNMsqz5Rum7CehsUsq8fSKKktx0fJfxoFKKgLI6gg4e?=
 =?us-ascii?Q?7jwS1so4yWzJL6jZWRXbydE3R+1AnDO7uCvqEX3qo9TbX3R+4Budp+kSQJgd?=
 =?us-ascii?Q?5FUVsIYKXeSKTWNrBDbOW60sua7BnpT+wa/WayC2DT7AD9SxJNx6BPL2Fqjy?=
 =?us-ascii?Q?vmLUlH48w/JKSsloGXdOjKR0tceHIjUzVBmqjMrXlb+DLMoKtq66jLIzsJ59?=
 =?us-ascii?Q?ijF06PEpgzxtVQk25KjI02UDcBI0Ohyf/45ta4ilFythNklEUp1F2WC5a9ve?=
 =?us-ascii?Q?9JkKQatTdk5TgfkDqcXE15kfXxf1XDM0NIcTV2xz4U5kmGP4Fa8r9i3ooq0Q?=
 =?us-ascii?Q?etAqzs6Y+17sCsM0s5xMfu80BZ3f3Kqt7JsPjQkyGgWENCtJOQ59/6mtdCh2?=
 =?us-ascii?Q?K/NRg5Hj2hui8sqW9WgVB/WUEmYYMjYReiOAioz1pTFKiXTkElVC1cX4VeOI?=
 =?us-ascii?Q?oS3d8mEBZelkIL1WjddGyQKwPNT5CodYXlODocv6Wcf6BJ7BzEl50MXHWZMw?=
 =?us-ascii?Q?uLzX7dI9b7/aHZ0lZvd55mMtg1iR4cBdc8EIImxm/TWlcJCRGyHZ8xIzb6O/?=
 =?us-ascii?Q?fi5sOrHfjVVTsVwQ+njxk2eNuVQdPTW7BIcRTmuf7LWt1fyIYLt41XHujMO6?=
 =?us-ascii?Q?wFyIwv/k5jBF46YuPQE0zDC0tNbFFEbw5YtR7fM6mR0gfXDnsR49vPI9CZ1R?=
 =?us-ascii?Q?Luw2pXvhdt2sy8ROzfzXfHXNZFWnFkb9G1oIjETaV1DG466bx0Uk+GyOtcQU?=
 =?us-ascii?Q?FyWmwqmQTAOyccgruXm09xhQ6jdt19g+3q5qu8RqEFlejVF9wlVJJ1tbGmPj?=
 =?us-ascii?Q?P8nKiQTxV9PuA30A5vMR4O/A3eZ1s/HokL8vhqshWcDC9LnOY1wah9xAkx/y?=
 =?us-ascii?Q?tQsbCOKqU4Bk0sWlPiArGuZMLrUE6aeod4BZuWGmtE1LOACoD4OuNI5xwo78?=
 =?us-ascii?Q?+97GGDw8WH2QTqLAZ1GM5V+jTP3HJN0x65CzIw0r8Mv0JbxktMHsMOmhG7Eb?=
 =?us-ascii?Q?1AU/i5Y1hmID3DqYQM8OKGGHdHANycWhF1trpHrvk8DQcazd69cmtdAnAGVN?=
 =?us-ascii?Q?pOiDc/D4NNtWSB0Ol91Q//twY1nnkp+wfbV46PrlS80E4PDpa9JjHv3AANgQ?=
 =?us-ascii?Q?VaL51kXcKbXTMe6ddLbysiY5VzlWdjfiVOPlTcnGXTq37VJCkCtRQLVUQ2Yn?=
 =?us-ascii?Q?kfdLxwzgyHeCu4MN99IPX0/0sK6ZHwIcbWj80WssWKpeVDyGw/dl3lAvxnS7?=
 =?us-ascii?Q?aM/l0j1V8cibEYQKkPVQXIZqO9bwBtlCLGYzXM4AceLklvmfo27iXOwGeyWT?=
 =?us-ascii?Q?1w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c1736f1-33c6-4249-3fb7-08dc8aacd434
X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB7540.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 06:56:48.0334
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NHVW6vNwowt4AJskQSVbzPBT3vcNQmR3Oh7cXruTwYzqsUX+Y1F2Q151wXHKOwpWWPiE2jwslL3X6877zm4DAEXewsgAojIcBxwOklY9VmI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4684
X-OriginatorOrg: intel.com

On Tue, Jun 11, 2024 at 07:38:37PM -0700, Jakub Kicinski wrote:
> On Mon, 10 Jun 2024 17:37:12 +0200 Larysa Zaremba wrote:
> > Fix the problems that are triggered by tx_timeout and ice_xdp() calls,
> > including both pool and program operations.
> 
> Is there really no way for ice to fix the locking? :(
> The busy loops and trylocks() are not great, and seem like duct tape.
> 

The locking mechanisms I use here do not look pretty, but if I am not missing 
anything, the synchronization they provide must be robust.

A prettier way of protecting the same critical sections would be replacing 
ICE_CFG_BUSY around ice_vsi_rebuild() with rtnl_lock(), this would eliminate 
locking code from .ndo_bpf() altogether, ice_rebuild_pending() logic will have 
to stay.

At some point I have decided to avoid using rtnl_lock(), if I do not have to. I 
think this is a goal worth pursuing?