Received-SPF: pass (google.com: domain of linux-kernel+bounces-211099-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 12 Jun 2024 09:47:46 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Zhai He <zhai.he@nxp.com>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"sboyd@kernel.org" <sboyd@kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Zhipeng Wang <zhipeng.wang_1@nxp.com>,
	Jindong Yue <jindong.yue@nxp.com>
Subject: Re: [EXT] Re: [PATCH] Supports to use the default CMA when the
 device-specified CMA memory is not enough.
Message-ID: <2024061215-strum-quarry-c574@gregkh>
References: <20240612023831.810332-1-zhai.he@nxp.com>
 <2024061228-unburned-dander-c9a2@gregkh>
 <AS1PR04MB955995BF689849177D95DE28EAC02@AS1PR04MB9559.eurprd04.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <AS1PR04MB955995BF689849177D95DE28EAC02@AS1PR04MB9559.eurprd04.prod.outlook.com>

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Wed, Jun 12, 2024 at 07:34:56AM +0000, Zhai He wrote:
> Thanks Greg for your review.
> The reason I changed the error level is because these logs will be printed
> when memory allocation from the specified device CMA fails, but if the
> allocation fails, it will be allocated from the default cma area. It can
> easily mislead developers' judgment, so I changed it to debug level.

Then you need to explain this in the changelog text :(

thanks,

greg k-h