Received: by 2002:ab2:6c55:0:b0:1fd:c486:4f03 with SMTP id v21csp279298lqp; Wed, 12 Jun 2024 00:57:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXbmSoaCZeC4RDfojKW/U6ATriaXhnkUkBc9ycDTKRXYmmjNFVDBk6UqmCEOFR3lmOnQAQZF/Ykez8pL/eV/GSmWdvodS5+2lgaEyPTmQ== X-Google-Smtp-Source: AGHT+IHsFl/3lpcsrCYRsVjhf8M5qrxgMYxPRh7jqH3x7R1Kc3U09QVqnPrEKY7reVVQQgB95hPW X-Received: by 2002:a17:906:3e4a:b0:a6f:1a1a:d3f5 with SMTP id a640c23a62f3a-a6f47d4ef5emr82080166b.8.1718179035060; Wed, 12 Jun 2024 00:57:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718179035; cv=pass; d=google.com; s=arc-20160816; b=tSgxakLGYGXcku39ZH+/69W1qbZMME2HUOAKYWVgSsuxJKwfDWId/nj2NdyvifW505 5S+1GRt1/CiYmCoM76ak7u5ghQkLDjBKk42sLp962AYmKDnE0lmnPMIuU3OvtFrbQttw A7HOaFQI0ly2hVkYzA7FfFu2+8n0usaCK93xqhG/PFZi/ZlniQTe4JHaWDSQH77R+gUl 675I3a24wCQjXhVvqwe4Q0LxXLTBmmWEPNnJ6CVVlZNMLCIRK0o3UKf4fm3DI/VpwTmN JWsA9RMyFOlBmKx/Fg8uOwLrow40qe7EKZyhFrcvrGF5O/zGO1kE1EX13lXhlMoJLZAS GN5A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=ssaxYkVceyn7ICHHraGM/vbLmPV2xtb883mRncUVHuQ=; fh=6WsNjFHYOgJwDipR1GlR22sG9i8aAYQcB+DTpuZOb9I=; b=hL5HGKW4vLCjvL9dI7C9H5qwmTaugkZR3UXIpkT6CQ0U6UrQCMBD4VcPRKkwOOPzYH qD978c53IemSHSBEB4AsTE3FMGe5shbqH5VacBGU/FCgWfN7nOO/0JpZ42cfjrwhMmgP ceZxj/9BbD9oO2vfwnfw+uWuYqNIDn0m7Ztjcoppbi4qBBM5hZIMjI+QQH4Fovtgf1Ms Loi4w22cFA8jmmf2SuPepngcqF4CK4WtwF8JYd13/LmDHObYLpI1uicGJtt55KCtfuBN XdzIaVh2GGAt7tn6URWeFAUWWbuOeuPqhhCliF9M+AmcuDFP3zEUY3cgEirtRYxGpP9F sAYw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="QCw/Q+Ks"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-211111-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-211111-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a640c23a62f3a-a6ec4d6aeb2si480892666b.661.2024.06.12.00.57.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 00:57:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-211111-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="QCw/Q+Ks"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-211111-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-211111-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id BC6F51F23354 for ; Wed, 12 Jun 2024 07:57:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 310F316C6A5; Wed, 12 Jun 2024 07:57:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QCw/Q+Ks" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A69216C69A for ; Wed, 12 Jun 2024 07:57:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718179026; cv=none; b=AgTZHK58oO+2ULII/NkrIXsE/DG0LKqN4qvC2wxPsc1QlxNfUCCd4lGhvQo4OPnyNGvjRY7J0zRW6MNsZxpyQWoFGxdasEZqDZAxnpqxcycGyJQhMGltEZWkTJjN7lZb1Pj2xzDv6+2TdLQih8RJzZQFCGJekzbT7ipAUHaey18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718179026; c=relaxed/simple; bh=hESmEHrQk7WtxKynr/6hcy4GMsBs6FznD7ZDEnXzOqo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=u6/UVyZULDTxTC8wBZKHWDwKOxzwYOMTicWsvjHI/ZSpXTZYs/k4h3Sfzpk4+F6XAqyiPuRM4dOj3Z3gbFz5L8gwHSlBj4yDbs/2eXn8rLMm74zT6nslPSrESNNyxXtar3o39VDIjAQHRRWT7IhtFoNNSMt6Y3+Fi5dx4i0rsQI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QCw/Q+Ks; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 955CAC3277B; Wed, 12 Jun 2024 07:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718179025; bh=hESmEHrQk7WtxKynr/6hcy4GMsBs6FznD7ZDEnXzOqo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QCw/Q+KsYXtgn/fPiS76aWlM7QL+2rbkPu2yKxx35dexv6Lv+6l2LUysiI38vX3BB Xg3MqkGpvtDom18PuFoW68C8QU2J0EYMFOliXNfuXTPzWycZmErA9cCKg2Cqcfck3c WfdZqZN0RtNAEfvbsUcNkQ38oOUtFucjri3wZFoZxKPhK0gQAv/v25YlHkI2nMbIPk Q341ZJdXEmFJwKGFC4t3YNEUOInpFeJNKMrhx0C/WWMGMq3p1fpY8EXO3V0SQ0tSn7 vtqqOElOkUObCTrFTzyjU/5hGBWffuaN9iLQknLnH8KIVp0MhpwIfwWoHi7yYCy/f3 QU7C2lCnYZBQw== From: Maxime Ripard To: Chun-Kuang Hu , Philipp Zabel , Douglas Anderson Cc: Maxime Ripard , Linus Walleij , Neil Armstrong , Fei Shao , AngeloGioacchino Del Regno , Daniel Vetter , David Airlie , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: (subset) [PATCH v2] drm/mediatek: Call drm_atomic_helper_shutdown() at shutdown time Date: Wed, 12 Jun 2024 09:56:59 +0200 Message-ID: <171817900323.766520.11311110578010469430.b4-ty@kernel.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240611102744.v2.1.I2b014f90afc4729b6ecc7b5ddd1f6dedcea4625b@changeid> References: <20240611102744.v2.1.I2b014f90afc4729b6ecc7b5ddd1f6dedcea4625b@changeid> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Tue, 11 Jun 2024 10:27:44 -0700, Douglas Anderson wrote: > Based on grepping through the source code this driver appears to be > missing a call to drm_atomic_helper_shutdown() at system shutdown > time. Among other things, this means that if a panel is in use that it > won't be cleanly powered off at system shutdown time. > > The fact that we should call drm_atomic_helper_shutdown() in the case > of OS shutdown/restart comes straight out of the kernel doc "driver > instance overview" in drm_drv.c. > > [...] Applied to misc/kernel.git (drm-misc-fixes). Thanks! Maxime