Received: by 2002:ab2:6c55:0:b0:1fd:c486:4f03 with SMTP id v21csp279729lqp; Wed, 12 Jun 2024 00:58:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWmSAx9MTii2RFIkWE8q66K74siFpgx8RhU8LnqV9Pknf3dKa+BYUvxOqXZRA4O38HaMAR9CQtr1eJAoa32BleaOCp2notSsxR2OHsSxw== X-Google-Smtp-Source: AGHT+IGsSkztEt9ajU9w8tjSSDNRJR3kuci1Oe74Pu4mdt9vGsu1DFAcNMRfGz2e6kDZ1nbLkekc X-Received: by 2002:a50:ba85:0:b0:57a:33a5:9b71 with SMTP id 4fb4d7f45d1cf-57caa9becd6mr951224a12.33.1718179113930; Wed, 12 Jun 2024 00:58:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718179113; cv=pass; d=google.com; s=arc-20160816; b=iyv6C7NpFT6d98dVf6FbBh3HDDyliC8SpGbQzKORqX6mvxyOk9DvW9u8gEJBEQazhs yOv120uS+h4SYtMvjSaYshxwDiDLA+3gWwB5YaHVlBBbulFu+S5jGzUH1Sa8IqhO+S/F aO99y6k+oKpaApGfiSa94rvifi1+3pThxsNsJczmk/xu3wLA6ObXCWEjAsCqfqRN5EOs AQgw+Sn2rLnZ89PaXJ0Ao/B4VdCLNNI1uocovg65sV+a2a+DtpZef024kz2ZbvQZN06b T//AcQlRVuZyDjrvJDxRISUNlb68YqxCN5s8k22YfyBH64C/BfnHDWz3GqXJrje2zxqK o6gw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=VyY5oqk8iIx8vYzUkWdXMR4N3hC4esoehJ74Syz16is=; fh=aQ+TmfztNRw4il+fB1p/sQxHUzPy2VupzoniTcbcFWw=; b=JZEWp6+whvSuPalAHedt0jsYhrI16wdCu1Cp6KutU9KGmt6VLswQPtqx/XdrW3l/ZX E3vi8o4yXnjbnNFp6XBdvK0v/ztYLDqhoQX0ZPij4QbJLbcjGbwG1q1dwq528PxSQVNu EBJ0tczUd8e+iWAphQcXWuOhSuaft1BxEPrI2YgA9I7BeuGXfkk7ZHgKUmM8U+0Oa5bT hj/hCk8/gCqr4ehPOeeUTHpn+qLHRUonx87W3wjOPgJdSzSWbiFXyGIhD+TgPT/RRPSk cgeG1H87cBlOdk2/C6KAwSCIG3zmSx2dcS3XLINUElZrPm++rEPSL2f/DX9hxcZZVqtl kgNQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="se3m/+I1"; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-211113-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-211113-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57c8fe50ca0si2086200a12.152.2024.06.12.00.58.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 00:58:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-211113-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="se3m/+I1"; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-211113-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-211113-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 729AB1F23DDE for ; Wed, 12 Jun 2024 07:58:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A040716C86D; Wed, 12 Jun 2024 07:58:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="se3m/+I1" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A95B816C6BE; Wed, 12 Jun 2024 07:58:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718179093; cv=none; b=ghtp/g1fqp40vcvTyPdFbf1vvjmnuXGSayMzQOvrWUAHdgM+YKGWGWvB5fTBwKveLdJiPqSe5O6yNIEfrj2rtbgm4BTJn451eK5ooHPRUKp4TM/8sDgCEp/j7AU/7A9TYN60BCiwTf8lI6cUKFuHD1UZQn2wrGa78hh5y5jDaOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718179093; c=relaxed/simple; bh=OknuNNK6uKLrZGWMzcve3pAdEC6a+jZCzFuUAGM0Ipw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Pu38KHQhGFmQVXT4mhyxH9a4nbkJUw2QZISJAMsybpSsSRRNY20Eq6sAF1P0XYzzUHODkXH/1050HfdALc8RpSQoXPLqCocJ2ghDtDuSgi/W5vJu0v0zZzWkeCYixBlwtROM1JMU6qRQprVvRotCIftMAcZnLsG77OUFsRYr8xc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=se3m/+I1; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 201A9C3277B; Wed, 12 Jun 2024 07:58:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1718179093; bh=OknuNNK6uKLrZGWMzcve3pAdEC6a+jZCzFuUAGM0Ipw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=se3m/+I1/51CyWYewGMwD1WNe7WIJWRqspVpvn8k3yTPWa7WQvJSpkFjjUYsNx3s9 2rDM1spM2i6oNdvCV6cHc8l7yevsUj1hAJ0DJUr+J8QtCRcmARc1zRkTMAHbS9bqn/ veY/zAQtP7Nf+E3xMa+5BbTjj2eCA2+RMe5JBXsQ= Date: Wed, 12 Jun 2024 09:58:10 +0200 From: Greg KH To: joswang Cc: Thinh.Nguyen@synopsys.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jos Wang Subject: Re: [PATCH v3, 3/3] usb: dwc3: core: Workaround for CSR read timeout Message-ID: <2024061247-geranium-unstaffed-ff09@gregkh> References: <20240601092646.52139-1-joswang1221@gmail.com> <20240611142953.12057-1-joswang1221@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240611142953.12057-1-joswang1221@gmail.com> On Tue, Jun 11, 2024 at 10:29:53PM +0800, joswang wrote: > From: Jos Wang > > This is a workaround for STAR 4846132, which only affects > DWC_usb31 version2.00a operating in host mode. > > There is a problem in DWC_usb31 version 2.00a operating > in host mode that would cause a CSR read timeout When CSR > read coincides with RAM Clock Gating Entry. By disable > Clock Gating, sacrificing power consumption for normal > operation. > > Signed-off-by: Jos Wang > --- > v1 -> v2: > - add "dt-bindings: usb: dwc3: Add snps,p2p3tranok quirk" patch > v2 -> v3: > - code refactor > - modify comment, add STAR number, workaround applied in host mode > - modify commit message, add STAR number, workaround applied in host mode > - modify Author Jos Wang > --- > drivers/usb/dwc3/core.c | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) Should this have a cc: stable line? thanks, greg k-h