Received-SPF: pass (google.com: domain of linux-kernel+bounces-211130-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 12 Jun 2024 10:03:22 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: lakshmi.sowjanya.d@intel.com
Cc: tglx@linutronix.de, giometti@enneenne.com, corbet@lwn.net,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	andriy.shevchenko@linux.intel.com, eddie.dong@intel.com,
	christopher.s.hall@intel.com, pandith.n@intel.com,
	subramanian.mohan@intel.com, thejesh.reddy.t.r@intel.com
Subject: Re: [PATCH v10 2/3] Documentation: driver-api: pps: Add Intel Timed
 I/O PPS generator
Message-ID: <2024061215-deflected-dimness-a317@gregkh>
References: <20240612035359.7307-1-lakshmi.sowjanya.d@intel.com>
 <20240612035359.7307-3-lakshmi.sowjanya.d@intel.com>
 <2024061230-thimble-oxymoron-3beb@gregkh>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2024061230-thimble-oxymoron-3beb@gregkh>

On Wed, Jun 12, 2024 at 10:02:46AM +0200, Greg KH wrote:
> On Wed, Jun 12, 2024 at 09:23:58AM +0530, lakshmi.sowjanya.d@intel.com wrote:
> > From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>
> > 
> > Add Intel Timed I/O PPS usage instructions.
> > 
> > Co-developed-by: Pandith N <pandith.n@intel.com>
> > Signed-off-by: Pandith N <pandith.n@intel.com>
> > Signed-off-by: Lakshmi Sowjanya D <lakshmi.sowjanya.d@intel.com>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Acked-by: Rodolfo Giometti <giometti@enneenne.com>
> > ---
> >  Documentation/driver-api/pps.rst | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> > 
> > diff --git a/Documentation/driver-api/pps.rst b/Documentation/driver-api/pps.rst
> > index 78dded03e5d8..75f7b094f963 100644
> > --- a/Documentation/driver-api/pps.rst
> > +++ b/Documentation/driver-api/pps.rst
> > @@ -246,3 +246,27 @@ delay between assert and clear edge as small as possible to reduce system
> >  latencies. But if it is too small slave won't be able to capture clear edge
> >  transition. The default of 30us should be good enough in most situations.
> >  The delay can be selected using 'delay' pps_gen_parport module parameter.
> > +
> > +
> > +Intel Timed I/O PPS signal generator
> > +------------------------------------
> > +
> > +Intel Timed I/O is a high precision device, present on 2019 and newer Intel
> > +CPUs, that can generate PPS signals.
> > +
> > +Timed I/O and system time are both driven by same hardware clock. The signal
> > +is generated with a precision of ~20 nanoseconds. The generated PPS signal
> > +is used to synchronize an external device with system clock. For example,
> > +it can be used to share your clock with a device that receives PPS signal,
> > +generated by Timed I/O device. There are dedicated Timed I/O pins to deliver
> > +the PPS signal to an external device.
> > +
> > +Usage of Intel Timed I/O as PPS generator:
> > +
> > +Start generating PPS signal::
> > +
> > +        $echo 1 > /sys/devices/platform/INTCxxxx\:00/enable
> > +
> > +Stop generating PPS signal::
> > +
> > +        $echo 0 > /sys/devices/platform/INTCxxxx\:00/enable
> 
> Why is this not described in Documenation/ABI/ ?

Oops, that was patch 3/3, sorry.