Received: by 2002:ab2:6c55:0:b0:1fd:c486:4f03 with SMTP id v21csp299630lqp; Wed, 12 Jun 2024 01:47:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVKJW0hiPUwF2lRkcVcBJP/0otVU/5C+zwgid32xcj1/23e1mqyobWS57ROD73SDT2FZ9Xz9lHOCJAIxlQdGpEc0hV8YByqOPDg6n8ySA== X-Google-Smtp-Source: AGHT+IH+OcifcVhhMRJq3Dzt8sWSnQ3mUiefZqm8hpgQZ3xijSwJAbfDqas9XJMOU9Zp9KcOpuk3 X-Received: by 2002:a05:6214:2f86:b0:6af:3d00:bbfd with SMTP id 6a1803df08f44-6b0d3d191c4mr18897696d6.27.1718182066755; Wed, 12 Jun 2024 01:47:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718182066; cv=pass; d=google.com; s=arc-20160816; b=U5K66T6IoD+cx60S47+oiGadmXCcaFwNJSBWfIUp6ZggqIGO7J5H+snTza1SZxEOhe cBmxm4YcquEuxfqdhrTEpRFupgKMYx5bWudPJkxwJi56iDwXlxPfetuETf3q/fGKwntv 1kEncxGaJd6q9+xWQx3hZT1iFqNyFaUg5fWlBk5p0XICVnG4mRMJ2g61V3BJaYECvFoI nTr/4OtK2RRHkMZVu2q9WvpwmVZzlEC+OoiaB8ekTU5uNyYxULa3ZTA5L0NiFqoTu+ww cbkY6qVB0s4QVTo4fJdWF2aLRkIwwAyFxPmBrzIuYjA0kioCS/CWqZbdXHy+EzIYFbo8 QVhQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=hpYxsqepRZpn/4oxNpupSBAJdfrKtBfgkfp6t0rsS5g=; fh=SpR7rd+yumm7lRKIGES5hVRl8roPI5yU3HU/uV05/Q0=; b=vGqNrG0/w12tuT6JkewZcNU8whhS5lfPibUS+5sjyd/k5vNyg/cnrGYEbhmGy0iolT ES8DwbzPnqV+bWKOGp2xym8jGcFjCSuLXnkbgcarz8vRyWDeyadmVSKKAJKbe9Rmy4a4 mxFOc3bjupICxSrWUZJjqCqE+eqZwyV+y7WFUwzttaERVF34FksaANbsnqZaSQqIzmcU o7am483QqplsNbgLhrywgRf4MFLPG0JamgmMtYkZDlq7efRKYYRIIXXR/C+7y4TCux2K lx4nZ+zyr821UvZ/jonn4xdYFi0IK7DtLuKvUAzkeMHrxTqLhkAkFUbponGbbTwiciRX FxLA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=H22nylHd; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-211203-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-211203-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 6a1803df08f44-6b088f4d176si45009236d6.333.2024.06.12.01.47.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 01:47:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-211203-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=H22nylHd; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-211203-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-211203-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 785E21C23AF1 for ; Wed, 12 Jun 2024 08:47:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7F7AF16D9A8; Wed, 12 Jun 2024 08:47:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H22nylHd" Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1444E16D4DF for ; Wed, 12 Jun 2024 08:47:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718182045; cv=none; b=i3kiXKfREchAujkOM9NgFa0BksekNWO7kns5U3WVM6GI3MgjzIu7wSP6hQlH2L4+wUQpm9DFgSP9NxYoblimiizBd/1iqJlPNmvG6A49To2W1Mp7jHwWYxF5fiO5p+Nqc3ddvjGn753tHnItyWj9NUfMZFr+5nvn1+GtAjFOM1Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718182045; c=relaxed/simple; bh=thEY5o/ShqkcdWv9f38FwQGucHRsZQowS1ike3Px+EU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=QvoyrbLgXd2Z1PnAWO1+wDxZvYvaN1nY845qgSxsqAIhEQBVWl3tJl/QZDywO4ZyQqz+DVnXut9rTjCa9gWuGnqyVEPmGHkqeGPOdttbDKVijvfanFVty8I8yTsaLEHUc4LTFMhIezZ5LGorCL/qidepNu0eXj4cbBjKk/wjxK8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=H22nylHd; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-421f4d1c057so23310285e9.3 for ; Wed, 12 Jun 2024 01:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718182042; x=1718786842; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hpYxsqepRZpn/4oxNpupSBAJdfrKtBfgkfp6t0rsS5g=; b=H22nylHd2+1k7I9MAfh0w+tRHiz7xiNXxRCFJiVuORvYH5SFjAoHkjdngaH7B5yERn cQmgOoN31+7IV4df4Ef35rbNFy4aUOxZB7MZCWoLqHh9Pq1kAKfA0jHueSGzI9U36Sfi THpzPHn4Ns8B8d6jmpkKSzdPEWEuZTjDy+8cUmxEDodI0IJxXDW7nRuxjtINN35d/m6o +KDIklvLdjn5lg9YIhdtKcGSFKZZtQv1kJDUDKjJL5FN8jqfXvJuvJsLSiFJ4Si5duyf hHBX8nhmet8jJSYmGpZjgkZ6j6N3da83ghPbiKN2u3p67Fuh79C8r8g55ZXU2BkkyNFO ILKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718182042; x=1718786842; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hpYxsqepRZpn/4oxNpupSBAJdfrKtBfgkfp6t0rsS5g=; b=WPCgkNTNOGe5g9H/wMXU9AhSn4yQcQfgcBY+czuxzZaZv2Ty6k2AMKhlVNkauU5AI8 chHOFTodV1eR5DoGWKsqIy+T8rDa+4YzkdkeKdekf2fq795Oyyu5ay/NlBEgeGmzMp2u cHJljh5NmhkjxZxMoU1S3p/pG+Ssakr1HD3iAH4UvPQBA/jKeDyIepNAC0kzOzmjhPBT NQyMJjyFz7flTJZ1n+2zD/ScYPZ2D53sqyQz6CHo3+GEUVpX+nfG+qIwc6HKZI8oYvDB kpirBHqa+KYpp59dLMuQyHSDv1iWG1mmzNFsxADFqSBROZcxQrCWCI9RaqoaykpDFxXJ DTaA== X-Forwarded-Encrypted: i=1; AJvYcCV4xy83lQrpbM9pOS4cN7KflPrwGmtLr5SmnK+eiTw8DHVsAse5Zb+OFrjgJ+aEY4gPZQWZTby5F7IM42c7n/AIeA1Ka2l4y/kb/99a X-Gm-Message-State: AOJu0Yx3rV2Imp1enjkqoeJTt7zTuLDnInnA14SDkHHEqSjNKWYkSQPU Qg3SZJOCfQJXz+b1cuSN0gsKKbPzAsQdkfWZ7lSah1kP5c8g7Et1W0x3+iqEnof6n4Cs+ZF3xAY az9RBeyhcG/uUMAGeKtHoMshfJcw0hf8fWv3myYaWkivHqriaKts= X-Received: by 2002:a50:96cf:0:b0:57c:4867:6738 with SMTP id 4fb4d7f45d1cf-57ca973f532mr916036a12.2.1718182021586; Wed, 12 Jun 2024 01:47:01 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240507-samsung-usb-phy-fixes-v1-0-4ccba5afa7cc@linaro.org> <20240507-samsung-usb-phy-fixes-v1-3-4ccba5afa7cc@linaro.org> In-Reply-To: <20240507-samsung-usb-phy-fixes-v1-3-4ccba5afa7cc@linaro.org> From: Peter Griffin Date: Wed, 12 Jun 2024 09:46:49 +0100 Message-ID: Subject: Re: [PATCH 3/5] phy: exynos5-usbdrd: make phy_isol() take a bool for clarity To: =?UTF-8?Q?Andr=C3=A9_Draszik?= Cc: Vinod Koul , Kishon Vijay Abraham I , Krzysztof Kozlowski , Alim Akhtar , Sam Protsenko , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Andr=C3=A9, On Tue, 7 May 2024 at 15:14, Andr=C3=A9 Draszik = wrote: > > on / not on is just a boolean flag and is a bit misleading as currently > on=3D=3D1 means to turn off the power, and on=3D=3D0 to turn power on. > > Rename the flag and make it a bool to avoid confusion of future readers > of this code. No functional change. > > While at it, fix a whitespace issue in nearby comment. > > No functional change. > > Signed-off-by: Andr=C3=A9 Draszik > --- Reviewed-by: Peter Griffin regards, Peter [..]